603898 - After unpinning an App Tab, the page is no longer into its initial group tab.

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Teodosia Pop]

User-Agent:       Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0b8pre) Gecko/20101012 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0b8pre) Gecko/20101012 Firefox/4.0b8pre

If I unpin an App Tab, the page is put into new group instead of being in the initial group.

Reproducible: Always

Steps to Reproduce:
1.Open several tabs.
2.Make one of the tabs an app tab.
3.Enter group view
4.Exit group view.
5.Unpin the app tab.
6.Enter group view.
Actual Results:  
The unpinned tab is placed in a new and small group in the upper left corner of the view.

Expected Results:  
The unpinned app tab should be placed into its original group.

Note: see screenshots
Groups should inherit both normal and app tabs despite pinning/unpinning process.

Comment 1

[Teodosia Pop]

Attachment: screenshot

Comment 2

[Teodosia Pop]

Attachment: screenshot 2

Comment 3

[Kevin Hanes]

Note that this bug may be resolved by Bug 598600. Assigning to Ian.

Comment 5

[Dietrich Ayala (:dietrich)]

Would be nice polish, but not holding back the release for this, blocking-.

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Bug 598600 landed, and it seems to work for me. Can anyone else reproduce?

Comment 7

[Maniac Vlad Florin (:vladmaniac)]

This is reproducible on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10) Gecko/20100101 Firefox/4.0b10 

[4b10] candidates for mac os x 10.6. Removing [WFM?] and setting the bug as reproducible for this os.

Comment 8

[Ian Gilman [:iangilman]]

(In reply to comment #7)
> This is reproducible on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10)
> Gecko/20100101 Firefox/4.0b10 
> 
> [4b10] candidates for mac os x 10.6. Removing [WFM?] and setting the bug as
> reproducible for this os.

Maniac, you can reproduce the issue shown in attachment 482799 [details]? Or you can reproduce that it doesn't go back into its original group?

As far as I can see, an app tab when unpinned goes into whatever group you're currently looking at, which means the original bug shown in comment 0 through comment 2 has been fixed, but the design question of whether it should go into the current group or its original group remains. 

As for the design question, I think going into the current group is actually better; otherwise the tab would appear to disappear. Also, the original group may not even still exist, or it may have been created months ago and the user doesn't remember that's where it came from.

Comment 9

[Maniac Vlad Florin (:vladmaniac)]

(In reply to comment #8)
> (In reply to comment #7)
> > This is reproducible on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10)
> > Gecko/20100101 Firefox/4.0b10 
> > 
> > [4b10] candidates for mac os x 10.6. Removing [WFM?] and setting the bug as
> > reproducible for this os.
> 
> Maniac, you can reproduce the issue shown in attachment 482799 [details]? Or you can
> reproduce that it doesn't go back into its original group?
> 
> As far as I can see, an app tab when unpinned goes into whatever group you're
> currently looking at, which means the original bug shown in comment 0 through
> comment 2 has been fixed, but the design question of whether it should go into
> the current group or its original group remains. 
> 
> As for the design question, I think going into the current group is actually
> better; otherwise the tab would appear to disappear. Also, the original group
> may not even still exist, or it may have been created months ago and the user
> doesn't remember that's where it came from.

Ian, the exact behavior as shown in the screenshot (as attachment 482799 [details]) is reproducible. I've retested on different mac machines and of course, using clean profiles.

Comment 10

[Raymond Lee [:raymondlee]]

Maniac:  What version of Firefox you can reproduce this bug?

Comment 11

[Raymond Lee [:raymondlee]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11pre) Gecko/20110130 Firefox/4.0b11pre

I couldn't reproduce the STR but the unpinned tab doesn't appear in the correct position in the Panorama view.  I filed a bug 630102 for that.

Comment 12

[Raymond Lee [:raymondlee]]

Please re-open it if you still see the issue