603942 - (fx40-p12n-ast) [ast] Firefox 4.0 productization review for Asturian

Status: RESOLVED FIXED

(Mozilla Localizations :: ast / Asturian, defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Asturian and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/ast>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Asturian builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[marquinos]

Hi! Updated the Asturian:
BlogLines:
   FF   4: http://bit.ly/9sY3xJ
   FF 3.6: http://bit.ly/9bLhCJ
Bing:
   FF   4: 
       Updated list.txt file: http://bit.ly/a0FqUV & 
       Add bing.xml file:     http://bit.ly/9Nia7Y
   FF 3.6: 
       Updated list.txt file: http://bit.ly/d67kJo & 
       Add bing.xml file:     http://bit.ly/d2KkSN  
Best regards and thanks!

Comment 2

[Seth Bindernagel]

Hi Marquinos,  You may have missed Stas's specific instructions from comment 0, so let me repaste it here:

"Please make suggestions for changes and attach patches that Seth, Axel or I
will review. Please note that since Bing provides a global plugin which does
the locale detection itself, you will only need to add "bing" to your list.txt
if you decide to include it. The XML file will be automatically pulled from
en-US.

"Once a review is granted, you can land the patch on l10n-central if your locale
actively maintains it. Otherwise, please wait for further instructions which
will be put in the comments of this bug and announced in mozilla.dev.l10n
(we're still unsure when the branching will happen). Please do not land any
changes except for the required ones (google.xml, Bloglines) on 1.9.2."

You have landed a Bing change on 1.9.2.  We will not take that change since it is not required for the 1.9.2. branch.  You will need to back out that change and can do this by attaching a patch for 1.9.2 making the updated changes, asking for a review, and then checking in *after* we r+ that new patch.

For l10n-central, if you want to add bing, you do not need an xml file.  Please remove that.  You only need to amend the list.txt file.  Please attach that for review as well.  

Lastly, make sure that Bloglines is removed from both and also that any unnecessary XML files are not present.

Comment 3

[marquinos]

Hi Seth! I'm so sorry!

I removed Bing for 1.9.2.

I removed the bing.xml for FF4 too ;)

I kept the "bing" string in the list.txt file < Is this correct, isn't?

Best regards and thanks!

Comment 4

[Seth Bindernagel]

OK, thanks for doing this and please don't forget to sign off using Pike's sign off application or else these changes will not get picked up.  I will resolve this as fixed for now.  In the future, please attach patches that have an impact on productization changes so we can review the together.  :)

Comment 5

[Seth Bindernagel]

Actually, there are two more things that you should amend on your l10n-central region.properties file.  

Can you add the exclamation point to My Yahoo! for the feed reader option?  And, since the keyword URL is not a feature in the upcoming release, please remove that line, too.  If you can attach a quick patch, I'll review it and r+.

Comment 6

[marquinos]

Hi Seth!
I removed the URL in My Yahoo! & Google.
http://hg.mozilla.org/l10n-central/ast/pushloghtml?changeset=9b40bddf541b
Thanks and best regards!

Comment 7

[Seth Bindernagel]

That change is incorrect.  You *need* those URLs.  Please attach a patch this time to this bug.  That patch should include the following:

browser.contentHandlers.types.0.title=My Yahoo!
browser.contentHandlers.types.0.uri=http://add.my.yahoo.com/rss?url=%s
browser.contentHandlers.types.1.title=Google
browser.contentHandlers.types.1.uri=http://fusion.google.com/add?feedurl=%s

Lastly, we are removing the "Keyword URL" feature, so you need to remove these lines:

# Keyword URL (for location bar searches)
keyword.URL=http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&gfns=1&q=

Please generate a patch and attach it for my review and then you can check that change in.

Comment 8

[marquinos]

Sorry Seth, and thanks very much for your help!!
I think is fixed now :$
http://hg.mozilla.org/l10n-central/ast/pushloghtml?changeset=ef8020b2529b
Best regards.

Comment 9

[Seth Bindernagel]

OK, that looks OK.  Please test and sign off when done testing.

Is there a reason you continue not attaching patches for review?  I have asked a few times and you haven't responded by doing that.  I can help if you don't know how to do that, but I am not sure since you are ignoring my requests.

Comment 10

[marquinos]

Hi! I don't know how attach a patch :$ Sorry.

Comment 11

[Staś Małolepszy :stas]

LSV updated:
https://hg.mozilla.org/l10n/l10n-src-verification/rev/1de7de57568d
https://hg.mozilla.org/l10n/l10n-src-verification/rev/aba1f382e9ff

Marquinos: ping me on IRC (stas) next time a bug like this pops up, I'll be happy to help you out with a patch.

Comment 12

[Axel Hecht [:Pike]]

Reopening, region.properties broke again. Marcos, can you investigate what makes it that you're hitting this repeatedly?

http://hg.mozilla.org/l10n-central/ast/log/default/browser/chrome/browser-region/region.properties shows two landings post ef8020b2529b, both of which aren't really right. http://hg.mozilla.org/l10n-central/ast/diff/a7e0e4419a6d/browser/chrome/browser-region/region.properties is straight out wrong, http://hg.mozilla.org/l10n-central/ast/diff/d3c1f572e9b8/browser/chrome/browser-region/region.properties isn't really a fix.

Comment 13

[marquinos]

Hi Axel!
I committed some times because I did wrong the change
https://bugzilla.mozilla.org/show_bug.cgi?id=603942#c2

Iñigo & me were worked together in FF4, I'll check this afternoon in home ;)
Thanks Axel!

Comment 14

[marquinos]

Hi! I think It's fixed: 
@Axel: Could you check, please? Thanks in advance!
Best regards.

Comment 15

[Axel Hecht [:Pike]]

http://hg.mozilla.org/l10n-central/ast/rev/c055c0c58d89 changes "My Yahoo!" to an asturian translation of that, not sure if that's cool. Seth? I found a Spanish translation on http://es.yahoo.com/, but not sure if there's Asturian.

The latest bustage is that the search order names don't match the search engines. browser.search.order.2 in region.properties needs to match <ShortName>Yahoo.es</ShortName> in searchplugins/yahoo-es.xml.

Also, you added and modified a bing.xml, that's not going to be picked up by the build. It should either be removed, or fixed. Seth?

Lastly, this is the last review I'm doing post landing. Marcos, attach patches to this bug instead of making us hunt down regressions in the code over and over. This is the third time we tell you now, should be enough.

Attach patches, and request review from seth, he's leading those reviews in the ramp up to Firefox 4.

Comment 16

[marquinos]

Attachment: Patch

Comment 17

[marquinos]

Hi! I uploaded a patch (503214) for this. I'll wait that this will be the correct :$
@Axel: Not exists an asturian version of Yahoo :( I changed to "My Yahoo!"
@Seth: Do you need that I push this change?
Thanks in advance!

Comment 18

[Axel Hecht [:Pike]]

Comment on attachment 503214 [details] [diff] [review]
Patch

I don't see anything wrong ad-hoc.

Seth, can you do a real review?

Comment 19

[Seth Bindernagel]

Comment on attachment 503214 [details] [diff] [review]
Patch

This looks very close and we are nearly completed with this task.  

But, before I r+ this, Marquinos, can you tell me if we should use "Mi Yahoo!"?  Does that work for an Asturian reader?  I assume it is better than "My Yahoo!".  When I checked the es site that Pike mentions, I can find several instances where they use "Mi Yahoo!".

Comment 20

[marquinos]

Hi Seth, Iñigo and me were disscussing about that.

The important points:
  1. There isn't an Asturian version of Yahoo!
  2. "Mi Yahoo!" is in Spanish for Spain, it isn't Asturian.
  3. "Mi Yahoo!" & "My Yahoo!" are foreign expressions in Asturian language. 
  3. The asturian users will use Yahoo.es as engine search.

In our opinion, "My Yahoo!" or "Mi Yahoo!" will be fine. We prefer keep "My Yahoo!" and in the future, if Yahoo! creates an Asturian site, then translate it. 
Best regards :)

Comment 21

[Seth Bindernagel]

Comment on attachment 503214 [details] [diff] [review]
Patch

Patch looks good and the explanation in comment 20 seems good.  Please check this into l10n-central and 1.9.2.  Please add a comment to both checkins that references bug 603942, this change, and r=sethb.

After you land these changes, please test the new build (with changes), and if successful, then sign off.  (Don't forget to sign off.  We will not ship the official version without a sign off.)  

After sign off, please resolve this fixed.

Comment 22

[Axel Hecht [:Pike]]

Is http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ast/rev/2eaad86320c8 part of this bug? Can't tell from the comment.

Comment 23

[marquinos]

@Pike: Yes Pike, it is.
I'll put a better comment for others commit. Sorry!
I'm waiting because I think I can't add flags for reviews.
Best regards.

Comment 24

[marquinos]

Hi! I checked in FF 4 & FF 3.6.X. Works.
Best regards and thanks for your patience ;)

Comment 25

[marquinos]

The commits for the 2 branch are here:
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ast/rev/2eaad86320c8
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ast/pushloghtml?changeset=2eaad86320c8

Comment 26

[Axel Hecht [:Pike]]

FTR, I've undid the yahoo! branding change for the mail handler, too, http://hg.mozilla.org/l10n-central/ast/rev/81fadb7f5452. I'll take the sign-off with that.

Seth, lsv needs another update, though.