603943 - (fx40-p12n-be) [be] Firefox 4.0 productization review for Belarusian

Status: RESOLVED FIXED

(Mozilla Localizations :: be / Belarusian, defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Belarusian and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/be>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Belarusian builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Axel Hecht [:Pike]]

Both http://hg.mozilla.org/l10n-central/be/diff/a54c8ee132a9/browser/chrome/browser-region/region.properties and http://hg.mozilla.org/l10n-central/be/diff/3280a71f1ef2/browser/chrome/browser-region/region.properties landed without review, and are likely not right.

Please back both changes out?

I'm rejecting the latest sign-offs based on this.

PS: Which toolchain are you using? It looks clearly like a tool-induced issue.

Comment 2

[Seth Bindernagel]

Siarhei, please attach a patch and flag me (:sethb) for review.  Once I give an r+, you can check in the changes.  But, we won't be able to accept anything that doesn't get a positive review.

(Thanks for catching this one, Axel.)

Comment 3

[Siarhei]

(In reply to comment #1)
> Both
> http://hg.mozilla.org/l10n-central/be/diff/a54c8ee132a9/browser/chrome/browser-region/region.properties
> and
> http://hg.mozilla.org/l10n-central/be/diff/3280a71f1ef2/browser/chrome/browser-region/region.properties
> landed without review, and are likely not right.
> 
> Please back both changes out?
> 
> I'm rejecting the latest sign-offs based on this.
> 
> PS: Which toolchain are you using? It looks clearly like a tool-induced issue.

Yes, it is Mozilla Translator caught changes from en-US. I will look for proper modification and pass it for review.

Comment 4

[Axel Hecht [:Pike]]

CCing Ricardo, as that change to region.properties sounds like an MT bug.

Comment 5

[RickieES aka Ricardo Palomares]

(In reply to comment #4)
> CCing Ricardo, as that change to region.properties sounds like an MT bug.


Partly, at least. I have in my TODO list to implement a control in MT. MT actually presented to Siarhei the changes in en-US, but it is true that MT doesn't prevent nor warn at all when exporting those changes. I have filed this bug:

http://kenai.com/bugzilla/show_bug.cgi?id=3479

and I will try to fix it as soon as I can find some time (a couple of weeks, I hope).

In the meanwhile, Siarhei, I know this is not a convenient workaround, but you may try to export files individually instead of exporting the whole product. In the mid term, this other feature:

http://kenai.com/bugzilla/show_bug.cgi?id=3097

should help too for those files not requiring review but "unwanted" to be replicated, like default searchplugins like Google and Yahoo! ones.

Sorry for the inconvenience.

Comment 6

[Siarhei]

(In reply to comment #5)
> 
Ricardo, thank you.

Really I should be more careful when I translate the changes got from en-US. And I shouldn't to push the changed file.

Comment 7

[Siarhei]

Attachment: patch for region.properties

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 488687 [details]
patch for region.properties

I don't think we want to remove netvibes.

The browser.search.order.3 doesn't make any sense, we should just stick with two ordered plugins for now.

I think we should just revert the last landing to start with.

Comment 9

[Siarhei]

Attachment: patch for region.properties

Here is a list of changes:

1) removed 
   browser.contentHandlers.types.2.title
   browser.contentHandlers.types.2.uri
2) added
   browser.search.order.3 = be.wikipedia.org

Comment 10

[RickieES aka Ricardo Palomares]

(In reply to comment #7)
> Created attachment 488687 [details]
> patch for region.properties


Just to clarify the L10n tool role here, MozillaTranslator can't know if adding or removing keys present in en-US is right or not (that's why it sticks to replicate in ab-CD the en-US structure). So, marking the file as "Don't export" enables you to edit region.properties outside of MT and be confident that it won't overwrite on successive exports.

Therefore, please feel safe editing region.properties with a UTF-8 text editor and removing browser.search.order.3. Also, since you was granted to ship three feed readers before (NetVibes, My Yahoo! and Google Reader), there should be no need to touch them. This is what Axel has managed to say with fewer words than me. :-)

Comment 11

[Siarhei]

(In reply to comment #8)
> Comment on attachment 488687 [details]
> 
> I think we should just revert the last landing to start with.

How should I revert the landing? Is it ok, if I push revision 0d77b07fefcb of region.properties back?

Comment 12

[Seth Bindernagel]

Comment on attachment 488688 [details]
patch for region.properties

Hi Siarhei:  I don't see any need to add this line:

browser.search.order.3 = be.wikipedia.org

Also, why are you removing Google from the browser.contentHandlers.types?  You don't need to do that unless you think the Google user experience for their reader app is not good for Belarusian.  Is that what you are doing here?  If not, let's just leave the Google Reader in its position.

I don't think we need this patch at all.

Comment 13

[Seth Bindernagel]

By the way, I was adding my comments to this bug, in addition to what has already been added.  I just attached me exact comments to the patch that had no review.

Comment 14

[Siarhei]

(In reply to comment #13)
> By the way, I was adding my comments to this bug, in addition to what has
> already been added.  I just attached me exact comments to the patch that had no
> review.

Hi Seth,

I removed ask for review before. I have landed last approved version of region.properties and now I am not going to land any changes.

http://hg.mozilla.org/l10n-central/be/file/14ba9e98fa76/browser/chrome/browser-region/region.properties

Comment 15

[Seth Bindernagel]

Thanks, Siarhei.  Please reopen this if you have any changes to suggest for Firefox 4.

Comment 16

[Staś Małolepszy :stas]

There's been a couple of changes to region.properties and search engines that landed without a review on l10n-central/be in the following changesets:

https://hg.mozilla.org/l10n-central/be/rev/f9fa70a3c373
https://hg.mozilla.org/l10n-central/be/rev/cc3a36907324

Since they all look good, I'm going to give them a post-factum r+. However, in the future please attach a patch in Bugzilla and ask us for a review before making any changes to theses files.

Comment 17

[Staś Małolepszy :stas]

lsv updated in https://hg.mozilla.org/l10n/l10n-src-verification/rev/fab9bcd4362f