Closed Bug 603959 (fx40-p12n-es-ES) Opened 14 years ago Closed 14 years ago

[es-ES] Firefox 4.0 productization review for Spanish (Spain)

Categories

(Mozilla Localizations :: es-ES / Spanish, defect)

Product:
Mozilla Localizations
Component:
es-ES / Spanish
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: stas, Assigned: willyaranda)

References

Details

(Keywords: productization, Whiteboard: [l10n-src-verif updated])

Attachments

(2 files)

Removing bloglines and make Google Reader default
1.04 KB, patch
Pike
: review+
Details | Diff | Splinter Review
Adding bing as 3rd search engine and removing CC
874 bytes, patch
Pike
: review-
Details | Diff | Splinter Review 
As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Spanish (Spain) and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/es-ES>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Spanish (Spain) builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!
Any deadline set for this? Not that we expecto to delay our proposal a lot, but it would be good to know how much time do we have for this. :-)
For 1.9.2, I would say that is a simple change that we'd like to see ASAP.  Clean up any XML files and remove Bloglines if necessary.  That's all for 1.9.2.

For an l10n-central (and eventual Firefox 4) patch, we have time.  I'd like any productization changes to get into a beta, but I think it is safe to say we will have one (if not two) more of those.  So...a couple weeks?
Attachment #484411 - Flags: review? → review?(l10n)
Attachment #484411 - Attachment is patch: true
Attachment #484411 - Attachment mime type: application/octet-stream → text/plain
The patch doesn't apply correctly in 1.9.2 branch, should I need to post another patch? or just backport it when I get a r+
Comment on attachment 484411 [details] [diff] [review]
Removing bloglines and make Google Reader default

r=me.

Is there a reason why this file doesn't have any comments anymore? Stas was wondering.

Would be cool to get a follow up to add them back in.
Attachment #484411 - Flags: review?(l10n) → review+
About the comments, we are using Mozilla Translator, and this tool doesn't keep the comments and identation in localized files.

adding Ricardo because he's the actual developer of MT
Pushed:

http://hg.mozilla.org/l10n-central/es-ES/rev/e385163713b1

Asking again for 1.9.2 branch. Can I land a similar patch without review or should I attach another patch for 1.9.2?
(In reply to comment #5)
> Is there a reason why this file doesn't have any comments anymore? Stas was
> wondering.
> 
> Would be cool to get a follow up to add them back in.


As Guillermo has told you, MozillaTranslator reads and presents to the localizer the comments marked as LOCALIZATION_NOTE, but doesn't export them. I guess it could be possible to export them, but keep in mind the impact that would have in the entire repository for ab-CD, with a miriad of changes in ab-CD files consisting in comments not present before.
Willyaranda: if the change is the same, feel free to land on 1.9.2. The r+ carries over.
Landed on 1.9.2:

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/es-ES/rev/1987d0bba4f5

Waiting for an internal discussion about Bing and other search plugins, so keeping new (or open if Ricardo could change the state)
Assignee: rpmdisguise-otros → willyaranda
It is all up to you. :-)
Status: NEW → ASSIGNED
Ricardo has asked some questions in our mailing list:

1) Could we have 7 search plugins (including Bing)?

2) If we want to add a search plugin for a shop (books, electronics, anything we haven't discussed yet), is it mandatory that the shop have a physical store? or could be virtual like Amazon?

Final question, 3) should have Bing more priority to be included (due to an agreement) rather than other plugins?

Regards!
(In reply to comment #12)
> Ricardo has asked some questions in our mailing list:


Just to clarify, these are not internal questions in our mailing list, but doubts we have about Firefox p12n policies:


> 1) Could we have 7 search plugins (including Bing)?


That would be 3-2-2:

- Google
- Yahoo!
- Bing

- RAE Spanish Dictionary
- Wikipedia Spanish

- eBay
- (still deciding options)


> 2) If we want to add a search plugin for a shop (books, electronics, anything
> we haven't discussed yet), is it mandatory that the shop have a physical
> store? or could be virtual like Amazon?


Actually, this is an internal question for our maling list, indeed. :-)


> Final question, 3) should have Bing more priority to be included (due to an
> agreement) rather than other plugins?


I guess (and hope) that it won't be that way, but it would be nice to know it.
(In reply to comment #13)
> > 1) Could we have 7 search plugins (including Bing)?
> 
> 
> That would be 3-2-2:
> 
> - Google
> - Yahoo!
> - Bing
> 
> - RAE Spanish Dictionary
> - Wikipedia Spanish
> 
> - eBay
> - (still deciding options)

Our productizaiton guidelines are simply guidelines.  If there is a compelling need for one more ecommerce plugin, we can consider.  

How popular is Yahoo?  Does it need to be there?

> > Final question, 3) should have Bing more priority to be included (due to an
> > agreement) rather than other plugins?
> 
> 
> I guess (and hope) that it won't be that way, but it would be nice to know it.

Bing doesn't need to have priority because of an agreement with Mozilla.  The decision is about what is best for Mozilla users.  So, if you feel Bing is one of the best user experience options in your locale, then include it.
Whiteboard: [l10n-src-verif updated]
Any updates on the productization changes discussed in this bug?
Not yet, thanks for the reminder, Seth
Attachment #491502 - Flags: review? → review?(stas)
Comment on attachment 491502 [details] [diff] [review]
Adding bing as 3rd search engine and removing CC

This is a small nit, but can you see the "\ No newline at end of file" at the end of the file?  Can you remove that by adding a newline?  Thanks.  I will r+ it with that small change.
If I add a new line, the diff is:

diff -r 31937c354d07 browser/searchplugins/list.txt
--- a/browser/searchplugins/list.txt	Wed Nov 17 00:44:16 2010 +0100
+++ b/browser/searchplugins/list.txt	Thu Nov 18 14:45:19 2010 +0100
@@ -1,6 +1,7 @@
 google
 yahoo-es
+bing
 drae
 eBay-es
 wikipedia-es
-creativecommons
\ No newline at end of file
+

I don't know how to solve it, any idea?
I had this problem myself a few months back.  The only way I was able to solve it was to use vi to add a new line.  So, what I did was run the following command from your terminal

# od -c list.txt

That should show you the characters in the file.  Then, I opened that file with vi, added the newline and saved.  When I ran #od -c again, the "\No Newline at end of file" was gone.  I have no idea why this works.
I'm totally unable to do that. I've tried on my MacBook (where I usually work, but this days were with an AirPort problem) and I have the same diff from hg…
Comment on attachment 491502 [details] [diff] [review]
Adding bing as 3rd search engine and removing CC

Axel, can you advise on how to get rid of the "\ No newline at end of file".  I used to be able to do this, but Willy cannot figure it out and my advice did not help.
Attachment #491502 - Flags: review?(stas) → review?(l10n)
Comment 19 looks right.

The "no newline" thing is gonna be there at least for the part of the existing file, so you won't get rid of the comment until you fixed it.

Once you have it fixed locally, it'll just look different.

I'll usually just open the file in vi, and save. Then I'm good.
Attachment #491502 - Flags: review?(l10n) → review-
I've open the file with "vi" in mac and then :wq to write and close.

Still the problem.

The only workaround I'm seeing is delete the file in one commit, and adding in the next commit (pushing both commits together). That solves the problem, but I don't know if that's a good idea…

Pike?
You want to delete the entire list.txt file and then recommit it?  If that is the way to get it working, you can do that.  List.txt is not such a complex file that this idea worries me.  I would just do that to get it correct and the commit.
Yes, that's my idea. But the main problem is that the history of the file will be deleted, I don't know if that's good for Pike.
(In reply to comment #26)
> Yes, that's my idea. But the main problem is that the history of the file will
> be deleted, I don't know if that's good for Pike.

Axel, do you have any objections to Willy removing the existing list.txt file and adding a new one.  He can't seem to fix the "\ No Newline..." issue.
I can't say anything without data. Also, pinging me is best with me on CC :-)

I can only reiterate, you will always see something about "no newline" as long as the original file has that. No way to work around that. The question on how that looks when the new modified doesn't, that's something different.
Please add a new version of list.txt without the no newline issue.
The point (I'm repeating) is that I'm totally unable to get rid of that "No newline" string if I just edit the file adding a newline, nor removing it… nothing.

I can remove that *only* if I do two commits:

1) remove the file list.txt
2) adding the file list.txt

I've tested it on local repositories and everything works.
Yes, do that then.
So:

http://hg.mozilla.org/l10n-central/es-ES/rev/a0536f762b48
Removing list.txt to get rid of the No newline nightmare for bug 603959 a=sethb r=l10n

and

http://hg.mozilla.org/l10n-central/es-ES/rev/6bdc7b77a7b6
Adding list.txt for bug 603959. Removing creativecommons searchplugin and adding bing as the 3rd searchplugin a=sethb r=l10n

I think everything is fine now.
ftr, at that point, just make a patch that fixes the line ending, and then patch on top.

With this approach, you destroyed hg annotate, which is not a good thing. But that's spilled milk now.
Anyway, I looked at the hg annotate command before commiting any changes, and it gived me just your first import when we switch from cvs to hg, there were no other changes in that file after that revision0.

http://mxr.mozilla.org/l10n-central/source/es-ES/browser/searchplugins/list.txt
Can this bug be closed now?
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: