Closed Bug 603962 (fx40-p12n-eu) Opened 14 years ago Closed 14 years ago

[eu] Firefox 4.0 productization review for Basque

Categories

(Mozilla Localizations :: eu / Basque, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stas, Unassigned)

References

Details

(Keywords: productization, Whiteboard: [l10n-src-verification updated])

Attachments

(2 files)

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Basque and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/eu>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Basque builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!
Just a quick note to say that I'll work on this once the branching happens.
Thanks Julen. May I still recommend that you have the discussion part sooner than later? We can surely wait for branching for the implementation part, but if the outcome of the review is a wish to add a new service, we will have to go through a process of obtaining a permission and technical specification from the provider, which usually takes some time. Knowing that you would like to add a new service early will help us get these things from the provider in a timely manner.
Sure -- I was just referring to actual patches.
Sounds great!
Waiting for the branch won't help here, sadly. We don't know when we're going to branch for gecko2, some folks lobby to do that as late as RC.

Julen, could you start with bringing the region.properties file onto the same state as 1.9.2 on l10n-central? There's a whitecard to land those fixes in the newsgroup, so no need to go through a patch, same goes for the keyword.URL removal. Right now, folks will get a confusing experience when using a profile back and forth between 3.6 and 4, worse than necessary. I'll block your sign-off based on this, too.
(In reply to comment #5)
> Waiting for the branch won't help here, sadly. We don't know when we're going
> to branch for gecko2, some folks lobby to do that as late as RC.

Sure, I already started working on l10n-central after the branching schedule was uncertain.

Our team has also discussed what we want in and out from the p12n point of view too, so I guess I'll work on this bug once b7 is out.

> Julen, could you start with bringing the region.properties file onto the same
> state as 1.9.2 on l10n-central? There's a whitecard to land those fixes in the
> newsgroup, so no need to go through a patch, same goes for the keyword.URL
> removal. Right now, folks will get a confusing experience when using a profile
> back and forth between 3.6 and 4, worse than necessary. I'll block your
> sign-off based on this, too.

So basically you want me to revert the first part of this? (lines 1.7-1.16)
http://hg.mozilla.org/l10n-central/eu/diff/37a55ef9fc87/browser/chrome/browser-region/region.properties
Sorry, Julen, all is good for now.

I had a local repo that didn't update to the newest changeset, so my local diffs were broken.

Took the sign-off, keep on the discussion. Sorry for the noise, again.
(In reply to comment #5) 
> Julen, could you start with bringing the region.properties file onto the same
> state as 1.9.2 on l10n-central? There's a whitecard to land those fixes in the
> newsgroup, so no need to go through a patch

Just to avoid any confusion in this bug, you can see from comment 0 that Stas asks for a patch to review when making changes to Bloglines and any extraneous xml files that might exist in your 1.9.2 repo.  For l10n-central, you can make the same changes, and add Bing to list.txt.  You can also change xml plugins if necessary.

Quote:

"Please make suggestions for changes and attach patches that Seth, Axel or I
will review. Please note that since Bing provides a global plugin which does
the locale detection itself, you will only need to add "bing" to your list.txt
if you decide to include it. The XML file will be automatically pulled from
en-US.

"Once a review is granted, you can land the patch on l10n-central if your locale
actively maintains it. Otherwise, please wait for further instructions which
will be put in the comments of this bug and announced in mozilla.dev.l10n
(we're still unsure when the branching will happen). Please do not land any
changes except for the required ones (google.xml, Bloglines) on 1.9.2."
Hi Julen, I was looking at your region properties file:

http://hg.mozilla.org/l10n-central/eu/file/default/browser/chrome/browser-region/region.properties

and I noticed that you have listed Bing as "browser.search.order.3=Bing".  And, you did not list it in your list.txt file.  I think you were trying to place the Bing changes on 1.9.2, but they are only relevant for the upcoming Firefox 4 release. 

This line "browser.search.order.3=Bing" should not be in your file.  Can you remove that from your branch please?

Lastly, if you have any productization changes to make for Firefox 4 (like the Bing suggestion for Firefox 4) please provide a patch to make that change on l10n-central.  Thank you.
Sorry, that went in in the file conversion phase and didn't notice it when pushing the changes.

If you're ok with this, I'll review all the productization stuff this week and respond on the bug. After all, we have already made our choices for fx4 p12n.
Works for me.  Please let me know what the changes will be for Firefox 4 for productizaiton elements.  Thanks, Julen.
region.properties reverted to its previous state in http://hg.mozilla.org/l10n-central/eu/rev/d9fa334976f8
As per our internal discussions, these are the changes we want to do:

Search engines:
+ Add Bing
= Keep CreativeCommons
- Remove Answers

Feed readers:
+ Add Google Reader

Please let us know if there are any problems. Otherwise I'll shortly attach the needed patches.
Looks fine to me.  Attach a patch when read and I will review.
Attached patch that removes Answers and adds Bing to the search engines (note the reordering in list.txt in order to have the list alphabetically sorted as in en-US), and adds Google Reader to the list of feed handlers.
Attachment #491658 - Flags: review?(sethb)
Comment on attachment 491658 [details] [diff] [review]
Productization changes for the Basque locale

Looks good.  Please check this into l10n-central only.  Add a comment to the checkin that references bug 603962 and this change.  Don't forget to sign off.
Attachment #491658 - Flags: review?(sethb) → review+
Changes pushed in http://hg.mozilla.org/l10n-central/eu/rev/aa6e028a04c2

Also signed off this changeset in the dashboard.

Will mark the bug fixed once the nightly build includes this change and all works correctly. Please verify on your side too.
Verified, all works as expected. Marking fixed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reopening.

Julen, could you also attach a patch that removes Bloglines from 1.9.2? Please don't add the Google Reader there, just remove Bloglines. Thanks!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated lsv for central/2.0: https://hg.mozilla.org/l10n/l10n-src-verification/rev/1bca4d41048b. Still waiting on 1.9.2 as per comment 19.
Whiteboard: [update l10n-src-verification]
(In reply to comment #19)
> Reopening.
> 
> Julen, could you also attach a patch that removes Bloglines from 1.9.2? Please
> don't add the Google Reader there, just remove Bloglines. Thanks!

Sorry, is that really needed? AFAIK Bloglines isn't finally being discontinued. What are the plans in that aspect?
Bloglines informed Mozilla about 2 months ago that they would discontinue service.  We filed bugs across all locales to remove it.  About 10 days ago, the people who acquired Bloglines then told us it would remain in service.  Due to the shifting position, we think it is best to remove them.  But, you can keep it if you want it.
FWIW, we're removing Bloglines in all other locales and it's our recommendation to do it in Basque as well.
Ok, no problems. Here's the patch to remove Bloglines from the 1.9.2 branch.
Sorry, I thought I attached the patch in the previous message.
Attachment #493641 - Flags: review?(stas)
Comment on attachment 493641 [details] [diff] [review]
Patch to remove bloglines from the 1.9.2 branch

r=me, thanks. Please land this on 1.9.2 mentioning this bug in the commit message and my review. And don't forget to sing off :)
Attachment #493641 - Flags: review?(stas) → review+
Pushed and signed off.

https://hg.mozilla.org/releases/l10n-mozilla-1.9.2/eu/rev/c0410fcf143d

Marking fixed.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Thanks Julen!

lsv updated in https://hg.mozilla.org/l10n/l10n-src-verification/rev/181168c39afd
Whiteboard: [update l10n-src-verification] → [l10n-src-verification updated]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: