603963 - (fx40-p12n-fa) [fa] Firefox 4.0 productization review for Persian

Status: RESOLVED FIXED

(Mozilla Localizations :: fa / Persian, defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Persian and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/fa>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Persian builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Behnam Esfahbod [:zwnj]]

Ehsan, would you please take care of this one too?  I wouldn't be able to help here for at least a few months.  Or if you know someone interested who could help here?

Thanks in advance.

Comment 2

[(no longer active)]

(In reply to comment #0)
> Here's what we're interested in:
> * search engines,

Here's my proposal:

We should remove creativecommons and add bing.

> * protocol handlers,
> * feed readers,
> * live bookmark.

I don't think we need to change any of these for Firefox 4 Persian.

> There's two things I would like to draw your attention to (if applicable):
> 
> 1) if you have a google.xml file in your `searchplugins` directory, please
> remove it,

Which repository is this about?  l10n-src-verification?  or l10n-central/fa?  If the latter, should this be removed from branch repositories as well?

> 2) Bloglines is closing down on November 1st and we need to remove it from the
> feed reader options for all locales (see bug 595485). We suspect that it will
> make sense to move Google Reader up to the first position (if your locale has
> it). We will be offering technical help with this change, either in form of
> ready-made patches or a mass-landing by one of the l10n-drivers. If you don't
> think that moving Google Reader up is a good idea for your locale, please let
> us know!

Seems like a good idea to me.

http://hg.mozilla.org/l10n-central/fa/rev/902aba922889

Let me know if this needs to happen on branches as well.

I'll attach a patch for the search engines.

Comment 3

[(no longer active)]

Attachment: Patch (v1)

Comment 4

[Seth Bindernagel]

Comment on attachment 485752 [details] [diff] [review]
Patch (v1)

I am going to r- this patch.  There are actually a lot of extraneous XML plugins in your searchplugins directory that you can remove.  The only file that needs to be in there is the wikipedia-fa.xml.  

List.txt will list all the plugins you want to ship, and that file lists mostly the en-US set, which ship with the browser.

Also, Bloglines is still listed in your 1.9.2 repository.  You can clean up the xml files and remove Bloglines and submit a new patch for review.

Comment 5

[(no longer active)]

Attachment: l10n-central patch

Comment 6

[(no longer active)]

Attachment: 1.9.2 patch (checked in: comment 18)

Comment 7

[(no longer active)]

Attachment: l10n-central patch (checked-in: comment 20)

Comment 8

[Seth Bindernagel]

Comment on attachment 487363 [details] [diff] [review]
l10n-central patch

Looks good.  Please check this into l10n-central and add a comment that references bug 603963 and this change.

Comment 9

[Seth Bindernagel]

Comment on attachment 487366 [details] [diff] [review]
l10n-central patch (checked-in: comment 20)

I am seeing some font issues on this patch.  I don't know if that is because I don't have the proper fonts installed or if it is a Bugzilla issue.  I am going to ask Axel for some feedback on this patch before we give it an r+ because I think he figured this issue out one time.

Comment 10

[Seth Bindernagel]

Comment on attachment 487365 [details] [diff] [review]
1.9.2 patch (checked in: comment 18)

Same thing, I need some feedback from Pike on this patch.  I am seeing some font issues in the patch in the browser.contentHandlers.types and browser.search.order.   Pike, feedback please.

Comment 11

[(no longer active)]

(In reply to comment #9)
> Comment on attachment 487366 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=487366
> l10n-central patch
> 
> I am seeing some font issues on this patch.  I don't know if that is because I
> don't have the proper fonts installed or if it is a Bugzilla issue.  I am going
> to ask Axel for some feedback on this patch before we give it an r+ because I
> think he figured this issue out one time.

The problem is that the patch is not served as UTF-8, and bugzilla has a bug which causes it to not accept anything other than "text/plain" for patches, so setting the mimetype to "text/plain; charset=utf-8" won't work.  :(

Comment 12

[(no longer active)]

https://bugzilla.mozilla.org/attachment.cgi?id=487366&action=diff and https://bugzilla.mozilla.org/attachment.cgi?id=487365&action=diff don't have the encoding issue, because bugzilla pages are served as UTF-8, FWIW.

Comment 13

[Seth Bindernagel]

I wanted to add one more issue to this bug.  

I see you have translated the brand names Google and Yahoo.  But, I can't seem to find cases where either firm translates their brand name.  It seems those companies leave it untranslated, but will translate services like "Mail" in "Yahoo! Mail".  See Maktoob, in Arabic, for an example:  http://www.maktoob.com/?lang=ar

Ehsan, have you seen the bran names translated somewhere on one of either of their properties before?  If so, can you link me to it?  Thanks.

Comment 14

[(no longer active)]

Google seems to be inconsistent in this regard.  For example, on this page <http://www.google.com/webhp?hl=fa> they use the untransliterated name, and in this other one <http://www.google.com/intl/fa/about.html> they use the transliterated name (گوگل).

Yahoo doesn't provide a Persian website, AFAIK.

Comment 15

[Seth Bindernagel]

Kev, Do you have any contacts at Google, Yahoo, and now Microsoft, who can tell us if we should use the transliteration of their brand names?  For instance, how we use them in region.properties?  And, what about translations of brand named features like "My Yahoo!".  It'd be great if you could find out their policy.  Thanks.

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 487365 [details] [diff] [review]
1.9.2 patch (checked in: comment 18)

feedback+ on me, because there's no regression here. I'm not sure on the brand names here, but, it's not a regression, so feedback+ from me.

Comment 17

[Seth Bindernagel]

Comment on attachment 487365 [details] [diff] [review]
1.9.2 patch (checked in: comment 18)

Please check this into 1.9.2.  If Kev replies, we can change it later.  Please add a comment with your checkin that references this change and bug 603963.

Comment 18

[(no longer active)]

(In reply to comment #17)
> Comment on attachment 487365 [details] [diff] [review]
> 1.9.2 patch
> 
> Please check this into 1.9.2.  If Kev replies, we can change it later.  Please
> add a comment with your checkin that references this change and bug 603963.

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/fa/rev/12bfb0b952a6

Comment 19

[Seth Bindernagel]

(In reply to comment #8)
> Comment on attachment 487363 [details] [diff] [review]
> l10n-central patch
> 
> Looks good.  Please check this into l10n-central and add a comment that
> references bug 603963 and this change.

Ehsan, I don't know if you got a chance to check this in on l10n-cnetral as well, but go for it.

Comment 20

[(no longer active)]

Comment on attachment 487366 [details] [diff] [review]
l10n-central patch (checked-in: comment 20)

(In reply to comment #19)
> (In reply to comment #8)
> > Comment on attachment 487363 [details] [diff] [review] [details]
> > l10n-central patch
> > 
> > Looks good.  Please check this into l10n-central and add a comment that
> > references bug 603963 and this change.
> 
> Ehsan, I don't know if you got a chance to check this in on l10n-cnetral as
> well, but go for it.

Oh, I had missed it indeed.  Thanks for bringing it to my attention:

http://hg.mozilla.org/l10n-central/fa/rev/4a0db3130104

Comment 21

[(no longer active)]

So, can we close this bug now?

Comment 22

[Seth Bindernagel]

Yes.  Resolved fixed.