603965 - (fx40-p12n-fr) [fr] Firefox 4.0 productization review for French

Status: RESOLVED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for French and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/fr>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in French builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Antoine Turmel [:GeekShadow]]

why remove google.xml ?

Comment 2

[Seth Bindernagel]

(In reply to comment #1)
> why remove google.xml ?

It's extraneous.  Since the Google plugin ships as the global default with Firefox, we only need to list Google in the list.txt and it will be placed automatically in your localized version.  Google's locale detection combined with their geo-IP technology is good enough that it provides the localized Firefox with the proper localized version of Google search.

This request is to clean up the set of xml files in your searchplugins directory.

Comment 3

[Seth Bindernagel]

But, as it turns out, the Google.xml file is not in the fr/searchplugins directory:

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/fr/file/d2629e173f2f/browser/searchplugins

Comment 4

[Benoit]

Attachment: Adds Bing to the fr searchplugins

Patch adding Bing based on the en-GB bug.

We would like to add Bing in third position without removing any other plugin. Answers.com and Creative Commons already didn't exist in the fr version, and the other plugins are still useful to our users.

Comment 5

[Seth Bindernagel]

Comment on attachment 485530 [details] [diff] [review]
Adds Bing to the fr searchplugins

This looks good to me.  Can you check this in on l10n-central *only*?  When you check-in, please add a comment that references this change and bug 603965.

You have not made any of the changes recommended in comment 0 that would apply to 1.9.2, so you don't need to check-in there.

Comment 6

[Benoit]

Checked-in on l10n-central:
http://hg.mozilla.org/l10n-central/fr/rev/c3c81fe38570

Comment 7

[Staś Małolepszy :stas]

https://hg.mozilla.org/l10n/l10n-src-verification/rev/332865f56b8b

Comment 8

[Kev Needham [:kev]]

Reopening (sorry)

Per eBay's request, please update the search plugin to be included with Mozilla
products per the attached patch. The changes add suggested search, an updated
favicon, and reduce the number of redirects from the initial search from 4 to 1. This change should block the release of Fx4 for the fr locale.

If there are any questions, please let me know.

Comment 9

[Kev Needham [:kev]]

Attachment: Updated eBay search plugin

Comment 10

[Benoit]

Pushed on l10n-central:
http://hg.mozilla.org/l10n-central/fr/rev/b8da938c71b1

Comment 11

[Seth Bindernagel]

Comment on attachment 503190 [details] [diff] [review]
Updated eBay search plugin

post-checkin approval.  Benoit, please make sure to test your next nightly build and then sign off for beta.  Thanks!

Comment 12

[Benoit]

Seth: sorry for not having waited for your approval, I didn't realize it wasn't granted yet at the time.

This updated plugin seems to work well in the nightlies. The icon changed, I got search suggestions and the right page showed up. The new revision was just signed off by Cedric.

Marking fixed again.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Note: the added |type="image/x-icon"| on the <Image> is unnecessary - the search service does not make use of the "type" attribute on Image elements. You should feel free to remove it.

Comment 14

[Cédric Corazza]

Fixed comment#13. http://hg.mozilla.org/l10n-central/fr/rev/2111af736710. gavin=r+ on irc.