Closed Bug 603992 (fx40-p12n-ml) Opened 12 years ago Closed 12 years ago
[ml] Firefox 4
.0 productization review for Malayalam
As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Malayalam and make any changes that you think will be good for our users. What is a productization review? ================================ Here's what we're interested in: * search engines, * protocol handlers, * feed readers, * live bookmark. You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/ml> Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too. Required changes ================ There's two things I would like to draw your attention to (if applicable): 1) if you have a google.xml file in your `searchplugins` directory, please remove it, 2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know! Changes in en-US and en-GB ========================== Here's the changes that we will be making in en-US and en-GB: * add Bing as the 3rd general search engine (see bug 603298), * remove Answers, * remove Creative Commons. We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Malayalam builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug. Implementation ============== Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US. Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2. If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines. Thanks!
Hi Ani, Bloglines still remains in your 1.9.2 repository. Please prepare a patch to remove it. However please note the new update about Bloglines below. Mozilla has been contacted by the new owners of Bloglines who have said they will keep the service running. If you have no other options, you can consider leaving it. However, it is hard to say whether that team who is now in control of Bloglines will change their mind again. The l10n-drivers feel that it would be best to remove it altogether. Also, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central. Thank you.
Seth, discussion going on with the community. I will revert on this in a day or two. Thanks :)
Apologies for the delay in replying. Got confirmation from community for the same: 1. Remove bloglines. 2. Add bing. 3. Add ml.wikipedia.org along with English wikipedia Hope this looks ok. Thanks!
Hi Ani, This looks fine, so let's prepare a patch for l10n-central that 1. Remove bloglines. 2. Add bing. 3. Add ml.wikipedia.org along with English wikipedia I will also need a patch for your 1.9.2 repository that removes bloglines. That's two patches you should attach here and flag me for a review. Do you need any help preparing those patches?
Hi Seth, would really appreciate if you could please help me preparing those patches. I did this once, but forgot and so I dont want to mess it up :( Thanks in advance!
Ani, please take a look at this patch and tell me if it looks good. If so, we can check it into your 1.9.2 repository.
Attachment #493378 - Flags: review?(apeter)
Hi Ani, please provide feedback on this patch and tell me if it looks like what you want. If it is, Stas please give it an r+. See comment 4 for the background. If Stas provides an r+, we can check in this change, adding a comment referencing bug 603992 and the changes we are making.
Comment on attachment 493381 [details] [diff] [review] Malayalam productization changes to Firefox 4 r=me. You could also add browser.search.order.3 = Bing if Ani wishes so. But, even without that, Bing will be on the 3rd spot anyways (at least for now, with the current set of the plugins).
Attachment #493381 - Flags: review?(stas) → review+
Looks good Seth. Thanks for the patch :) (In reply to comment #6) > Created attachment 493378 [details] [diff] [review] > Removing Bloglines from ml 1.9.2 > > Ani, please take a look at this patch and tell me if it looks good. If so, we > can check it into your 1.9.2 repository.
This also is good Seth. Please go ahead :) Thanks! (In reply to comment #7) > Created attachment 493381 [details] [diff] [review] > Malayalam productization changes to Firefox 4 > > Hi Ani, please provide feedback on this patch and tell me if it looks like what > you want. If it is, Stas please give it an r+. See comment 4 for the > background. > > If Stas provides an r+, we can check in this change, adding a comment > referencing bug 603992 and the changes we are making.
Ani, are you going to push these changes to the ml repository on Mercurial?
Seth, as discussed please go ahead. Thanks :) (In reply to comment #11) > Ani, are you going to push these changes to the ml repository on Mercurial?
Pushed changes to 1.9.2 with this changeset bd8347f3faa2
I pushed changes on behalf of Malayalam to l10n-central with changeset 8f9343e5beac.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [update l10n-src-verification]
Whiteboard: [update l10n-src-verification] → [l10n-src-verification updated]
Thanks Stas :)
You need to log in before you can comment on or make changes to this bug.