604055 - Installed skin/theme being used, despite being version incompatible. As a result, incorrect menu shown when right-clicking on empty space on tab bar.

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Kai Engert [:KaiE:]]

I've just recently started to use my primary Firefox work profile with Firefox 4.

In this profile, when I right-click on any tab in the tab bar, I get the toolbar menu, not the tab menu.

In other words, the menu shown offers
  "nav toolbar, bookmarks toolbar, tabs on top, customize"

But I expect it show a menu that contains the usual tab options like
  "New Tab, ..., Close Tab, ..., Undo closed Tab"

Comment 1

[Kai Engert [:KaiE:]]

This is seen with Firefox 4 Beta 6 on Linux, using a contributed Fedora build.

I did some experiments in order to find the culprit.

* Disabled all add-ons => still same bug
* Reset toolbars and controls => still same bug
* Reset all user preferences to Firefox defaults => makes it work


Obviously I don't want to lose all my individual preferences that I've collected over time, I've restored a backup that I made prior to the above experiments.


This bug requests that we track down the old preference or migrated preference that is responsible for showing the incorrect menu.

Comment 2

[Kai Engert [:KaiE:]]

Found the culprit.

I have preference
  general.skins.selectedSkin
set to
  "charamel"

The "charamel" skin is installed, but it is disabled, according to the add-one manager, because it's incompatible with ff4b6.

Despite being disabled, it still has the effect to disturb the right click menus.

Comment 3

[Kai Engert [:KaiE:]]

While add-on manager claimed the skin/theme is incompatible, it was used. I saw the non-standard user interface colours.

As far as I understand, I *don't* have any prefs set that would disable addon compatibility checking as explained in http://kb.mozillazine.org/Updating_extensions#Completely_disabling_the_compatibility_check

Comment 4

[Kai Engert [:KaiE:]]

Ok, maybe I did something in the past that I shouldn't have done.

Here is how this issue can be reproduced:

- start firefox 3.6.x with a fresh profile
- install https://addons.mozilla.org/en-US/firefox/addon/14313/
- restart
- uninstall the "addon", but keep the "theme"
- restart
- you still have the charamel colours
- quit
- now start firefox 4 with the same profile
- you still see the charamel colours and you see the bug

Comment 5

[Dave Townsend [:mossop]]

Bug 565064 was meant to have fixed this but that landed for b2.

Can you attach a copy of extensions.sqlite from your profile folder.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Works fine for me with Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101012 Firefox/4.0b8pre. The migration wizard correctly identifies the Carmel theme as incompatible and disables it. Kai, can you please test with a todays Minefield build?

Comment 7

[Kai Engert [:KaiE:]]

I just ran into this again, with the latest Linux nightly build from mozilla.org

I had only one incompatible addon installed (littlefox), it was disabled, but still, I had the incorrect menu (missing undo-tab-close).

In order to fix it for me, I had to:
- uninstall littlefox
- restart
- still broken
- install a random theme compatible with 4.0,
  I picked https://addons.mozilla.org/en-US/firefox/addon/191969/
- restart
- get the black theme, menu still broken
- go to addon-manager, enable the default theme
- restart
- finally I get the expected menu

Comment 8

[Kai Engert [:KaiE:]]

Attachment: extensions.sqlite.zip

I'm  still able to reproduce the bug with a fresh profile and the steps from comment 4.

Here is a zipped extensions.sqlite as requested, from that broken profile.

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 490270 [details]
extensions.sqlite.zip

I still can't reproduce this and the database appears to match what I get after following the steps so I'm not sure why we're not switching back to the default theme. Could you try the process again with extensions.logging.enabled set to true and then when you start Firefox 4 for the first time on the profile do so from a terminal and copy anything that gets logged.

Comment 10

[Kai Engert [:KaiE:]]

Maybe this is invalid.

Today I realized I specific behaviour of the right click menus.
It might be that this special behaviour had confused me in the past when reporting this bug.

My observation:

- a right click on an open tab bar produces the expected tab menu

- a right click on the empty area to the right on tabs produces the
  unexpected toolbar selector menu


I have verified, using old Firefox 3, the same menu was displayed for both areas.


If this new behaviour is the intended behaviour, then this bug is invalid, but more people might experience the same confusion .

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right, this is invalid and is not related to any theme/skin installed. This is a change on purpose implemented on bug 578614.