604201 - browser_tabview_snapping.js test fails if you run it by itself

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Ian Gilman [:iangilman]]

The test runs fine when run with all of the other tabview tests, but when run by itself, it gives these errors:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Right under: Moving up 10 should not snap
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Right under: Moving up 10 again should snap!
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Offset: Moving up 10 should not snap
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Offset: Moving up 10 again should snap!

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Ian, this worksforme, at least right now on m-c. Can you reproduce it now?

I'm pretty sure we modified this test very slightly to make it more robust recently... can't remember for which bug, though.

Comment 2

[Ian Gilman [:iangilman]]

Mitcho, you don't have any other patches on your local m-c, and you're running just the snapping test with this command line?

TEST_PATH=browser/base/content/test/tabview/browser_tabview_snapping.js make -C obj-ff-dbg mochitest-browser-chrome

I've just tried that again with a fully up to date and clean m-c, and I'm getting the same errors:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Right under: Moving up 10 should not snap
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Right under: Moving up 10 again should snap!
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Offset: Moving up 10 should not snap
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Offset: Moving up 10 again should snap!

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Log from running the snapping test alone

This is m-c revision 3094ee9b5868 (a few days old) on Mac OS X 10.6.4.

Comment 4

[Raymond Lee [:raymondlee]]

(In reply to comment #3)
> Created attachment 489502 [details]
> Log from running the snapping test alone
> 
> This is m-c revision 3094ee9b5868 (a few days old) on Mac OS X 10.6.4.

It runs fine on my local machine as well.

Comment 5

[Ian Gilman [:iangilman]]

Well, I guess if it's only causing trouble on my machine, we can let it be...

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Reopening to make the test more robust by making it run in its own window...

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch to make snapping test run in its own window

Already pushed to try with today's m-c and it passed.

Comment 8

[Ian Gilman [:iangilman]]

Comment on attachment 497899 [details] [diff] [review]
Patch to make snapping test run in its own window

Looks great. Doesn't require approval of course, as it's a test.

Comment 9

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Comment 10

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/eae26f4fac41