Closed Bug 604201 Opened 14 years ago Closed 14 years ago

browser_tabview_snapping.js test fails if you run it by itself

Categories

(Firefox Graveyard :: Panorama, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iangilman, Assigned: mitcho)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 2 obsolete files)

The test runs fine when run with all of the other tabview tests, but when run by itself, it gives these errors: TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Right under: Moving up 10 should not snap TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Right under: Moving up 10 again should snap! TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Offset: Moving up 10 should not snap TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Offset: Moving up 10 again should snap!
Ian, this worksforme, at least right now on m-c. Can you reproduce it now? I'm pretty sure we modified this test very slightly to make it more robust recently... can't remember for which bug, though.
Mitcho, you don't have any other patches on your local m-c, and you're running just the snapping test with this command line? TEST_PATH=browser/base/content/test/tabview/browser_tabview_snapping.js make -C obj-ff-dbg mochitest-browser-chrome I've just tried that again with a fully up to date and clean m-c, and I'm getting the same errors: TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Right under: Moving up 10 should not snap TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Right under: Moving up 10 again should snap! TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Offset: Moving up 10 should not snap TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Offset: Moving up 10 again should snap!
This is m-c revision 3094ee9b5868 (a few days old) on Mac OS X 10.6.4.
(In reply to comment #3) > Created attachment 489502 [details] > Log from running the snapping test alone > > This is m-c revision 3094ee9b5868 (a few days old) on Mac OS X 10.6.4. It runs fine on my local machine as well.
Well, I guess if it's only causing trouble on my machine, we can let it be...
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
Reopening to make the test more robust by making it run in its own window...
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Already pushed to try with today's m-c and it passed.
Attachment #489502 - Attachment is obsolete: true
Attachment #497899 - Flags: review?(ian)
Comment on attachment 497899 [details] [diff] [review] Patch to make snapping test run in its own window Looks great. Doesn't require approval of course, as it's a test.
Attachment #497899 - Flags: review?(ian) → review+
Attachment #497899 - Attachment is obsolete: true
Blocks: 608184
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: