604587 - bullets of nested not ordered lists have one and the same character

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

We expose 0x2022 character for any bullet of not ordered lists, taking into account neither list level nor bullet graphics. I think it makes sense to expose the character that corresponds to visual presentation of bullet, that could be corresponding unicode symbol.

The bullet text presentation is in nsBlockFrame::GetBulletText() (http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsBlockFrame.cpp#6526).

Robert, is unicode characters are used to draw bullets or is it an image? Is there a nice way to convert list style types like NS_STYLE_LIST_STYLE_DISC to unicode?

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We draw circles, squares etc explicitly.

There probably are circle and square Unicode characters you could use here. I don't know if that would actually help ATs at all.

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> I don't know if that would actually help ATs at all.

This was requested by AT vendor. I guess they have either an ability to pronounce unicode characters or want to use them to differentiate list bullets form nested lists without accessible tree traversal.

Comment 3

[alexander :surkov (:asurkov)]

We could use the following unicode characters:

'•' - 2022 - bullet - NS_STYLE_LIST_STYLE_DISC
'▪' - 25AA - black small square - NS_STYLE_LIST_STYLE_SQUARE
'◦' - 25E6 - white bullet - NS_STYLE_LIST_STYLE_CIRCLE

Jamie, is NVDA fine with that?

Comment 4

[James Teh [:Jamie]]

(In reply to comment #3)
> '•' - 2022 - bullet - NS_STYLE_LIST_STYLE_DISC
> '▪' - 25AA - black small square - NS_STYLE_LIST_STYLE_SQUARE
> '◦' - 25E6 - white bullet - NS_STYLE_LIST_STYLE_CIRCLE
> Jamie, is NVDA fine with that?
NVDA/eSpeak isn't currently reading the last two. However, we can add these when we rework our punctuation/symbol handling. In short, I support this change; we should fix the reading of these characters on our side. :)

Comment 5

[alexander :surkov (:asurkov)]

Great, thank you.

Comment 6

[James Teh [:Jamie]]

(In reply to comment #3)
> '◦' - 25E6 - white bullet - NS_STYLE_LIST_STYLE_CIRCLE
White bullet, eh? I assume this is just a hollow circular bullet? "White bullet" is not a particularly descriptive name. :) Is there a better symbol we can use or does this actually look closest?

Comment 7

[James Teh [:Jamie]]

Just for another reference, OpenOffice.org uses:
* Solid small circular bullets: '•' (2022)
* Solid large circular bullets: '●' (25cf)
* Solid large square bullets: '' (e001)
NVDA still doesn't read the last two, though. :)

Comment 8

[alexander :surkov (:asurkov)]

(In reply to comment #6)
> (In reply to comment #3)
> > '◦' - 25E6 - white bullet - NS_STYLE_LIST_STYLE_CIRCLE
> White bullet, eh? I assume this is just a hollow circular bullet?

right.

> "White
> bullet" is not a particularly descriptive name. :) Is there a better symbol we
> can use or does this actually look closest?

it's just a name from Arial font in charmap util. It looks close enough, it's a bit smaller than drawn circle but I think it doesn't make a difference, especially because character visual presentation should depend on chosen font.

Comment 9

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 483432 [details] [diff] [review]
patch

This did not need superreview.

Comment 11

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 483432 [details] [diff] [review]
patch

r=me. (I don't think we heard back from all vendors right?)

Comment 12

[alexander :surkov (:asurkov)]

(In reply to comment #11)
> Comment on attachment 483432 [details] [diff] [review]
> patch
> 
> r=me. (I don't think we heard back from all vendors right?)

not all, but some of them, OpenOffice makes similar things, I don't think that's what we should check with all AT vendors. Just that should be documented.

Comment 13

[alexander :surkov (:asurkov)]

landed  on 2.0 - http://hg.mozilla.org/mozilla-central/rev/c051f575d22f