Created attachment 483659 [details]
testcase (crashes Firefox when loaded)
This is crap left over from XBL form controls. We should make this interface noscript as a quick fix, imo.
I have patches to remove nsISelectElement altogether, but I guess that won't fly for 2.0.
Probably not. Want to do a patch per comment 1? ;)
We have a systematic problem we need to fix that will resolve this issue: bug 605271. It's a blocker, so minusing this one.
It doesn't seem to crash the 1.9.2 branch, do we still want to make the interface [noscript] anyway just in case? Any others in the same family we should do the same to?
We should make this noscript on branch, yes. imo.
This is fixed by Bug 605271.
bug 605271 is a lot more than making the iface [noscript]. Is it necessary (and if so, is it a safe change for the branch?) or is there a quick IDL fix along the lines of comment 1?
Created attachment 488440 [details] [diff] [review]
Comment on attachment 488440 [details] [diff] [review]
Do we want/need to take that on 2.0?
Created attachment 488570 [details] [diff] [review]
Patch for checkin
Comment on attachment 488570 [details] [diff] [review]
Patch for checkin
Four addons tried to fool my search by doing this:
const nsISelectElement = Components.interfaces.nsIDOMHTMLSelectElement;
(and then using nsISelectElement) but none use the real nsISelectElement so we look OK going this route.
Approved for 184.108.40.206 and 220.127.116.11, a=dveditz for release-drivers
Leaving open for trunk until bug 605271 has landed (or this patch is landed in the interim?). I believe checkin-needed referred only to the branches so I'm removing that keyword, but if we want this interim patch meanwhile it could be re-added.
We should just land this patch on trunk. Bug 605271 isn't going to make it.
This should be blocking since 605271 isn't anymore.
Jonas, Johnny, this should block, isn't it?
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
Readding everything that got stripped ...