The default bug view has changed. See this FAQ.

Remove nsISelectElement

RESOLVED FIXED in mozilla5

Status

()

Core
DOM: Core & HTML
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla5
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments)

(Assignee)

Description

6 years ago
As noted in bug 604807, we could remove it. Patches coming up.

Updated

6 years ago
No longer blocks: 604807
Blocks: 604807
(Assignee)

Comment 1

6 years ago
Created attachment 507560 [details] [diff] [review]
Part a: Remove unnecessary inclusions of and references to nsISelectElement.h
Attachment #507560 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

6 years ago
Created attachment 507561 [details] [diff] [review]
Part b: make nsHTMLOptionElement::GetSelect return nsHTMLSelectElement.
Attachment #507561 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

6 years ago
Created attachment 507562 [details] [diff] [review]
Part c: stop using QueryInterface on nsHTMLOptionElement::GetSelect's return value.
Attachment #507562 - Flags: review?(bzbarsky)
(Assignee)

Comment 4

6 years ago
Created attachment 507563 [details] [diff] [review]
Part d: use nsHTMLSelectElement::FromContent in nsListControlFrame.
Attachment #507563 - Flags: review?(bzbarsky)
(Assignee)

Comment 5

6 years ago
Created attachment 507564 [details] [diff] [review]
Part e: make nsSafeOptionListMutation::mSelect a nsHTMLSelectElement.
Attachment #507564 - Flags: review?(bzbarsky)
(Assignee)

Comment 6

6 years ago
Created attachment 507566 [details] [diff] [review]
Part f: kill layout/forms/resources.
Attachment #507566 - Flags: review?(bzbarsky)
(Assignee)

Comment 7

6 years ago
Created attachment 507567 [details] [diff] [review]
Part g: Kill nsISelectElement.
Attachment #507567 - Flags: review?(bzbarsky)
Comment on attachment 507560 [details] [diff] [review]
Part a: Remove unnecessary inclusions of and references to nsISelectElement.h

r=me
Attachment #507560 - Flags: review?(bzbarsky) → review+
Comment on attachment 507561 [details] [diff] [review]
Part b: make nsHTMLOptionElement::GetSelect return nsHTMLSelectElement.

>+    if (aContent &&
>+        aContent->NodeInfo()->Equals(nsGkAtoms::option, kNameSpaceID_XHTML))

As long as you're here:

  if (aContent && aContent->IsHTML(nsGkAtoms::option))

>+++ b/content/html/content/src/nsHTMLSelectElement.h

>+    if (!aContent ||
>+        !aContent->NodeInfo()->Equals(nsGkAtoms::select, kNameSpaceID_XHTML))
>+      return NULL;

Again, IsHTML().  And let's stick with nsnull until the mass-change.  ;)

r=me with the nits picked.
Attachment #507561 - Flags: review?(bzbarsky) → review+
Comment on attachment 507562 [details] [diff] [review]
Part c: stop using QueryInterface on nsHTMLOptionElement::GetSelect's return value.

r=me
Attachment #507562 - Flags: review?(bzbarsky) → review+
Comment on attachment 507563 [details] [diff] [review]
Part d: use nsHTMLSelectElement::FromContent in nsListControlFrame.

r=me, if you check that stuff like SetOptionsSelectedByIndex can't trigger script (e.g. via onchange events).  If it can, you need to hold strong refs in soe places here...
Attachment #507563 - Flags: review?(bzbarsky) → review+
Comment on attachment 507564 [details] [diff] [review]
Part e: make nsSafeOptionListMutation::mSelect a nsHTMLSelectElement.

r=me
Attachment #507564 - Flags: review?(bzbarsky) → review+
Comment on attachment 507566 [details] [diff] [review]
Part f: kill layout/forms/resources.

r=me; can't believe this was still around.
Attachment #507566 - Flags: review?(bzbarsky) → review+
Comment on attachment 507567 [details] [diff] [review]
Part g: Kill nsISelectElement.

r=me
Attachment #507567 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 15

6 years ago
http://hg.mozilla.org/mozilla-central/rev/83b87584d902
http://hg.mozilla.org/mozilla-central/rev/ac5c47d204dc
http://hg.mozilla.org/mozilla-central/rev/98c2bd7b6d53
http://hg.mozilla.org/mozilla-central/rev/e8ac4db006eb
http://hg.mozilla.org/mozilla-central/rev/b71908ead27b
http://hg.mozilla.org/mozilla-central/rev/7ddc7042d30e
http://hg.mozilla.org/mozilla-central/rev/83692ba345d4
http://hg.mozilla.org/mozilla-central/rev/55f92ef9873c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.