604866 - Zoom-in not working above a certain preview size

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Michael Monreal [:micmon]]

Have (at least) one group in panorama with one tab in it. Size the group in a way that the tab preview is small, say 200 pixels wide: the zoom-in effect works fine.

Now enlarge this tab group to make the tab preview big, about 700-750 pixels wide. Now click the tab. Instead of expanding, to all sides, the tab preview actually shrinks and moves to the top left corner which is exactly the opposite of what makes sense.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

I've seen this and it's bothered me... I'll take it.

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1

To test the effects of this patch, try zooming in or out on a tab whose thumbnail in Panorama is greater than 1/1.7 (~60%) of the width of the window.

Comment 3

[Ian Gilman [:iangilman]]

Comment on attachment 485602 [details] [diff] [review]
Patch v1

>+    if (scaleCheat === undefined)
>+      scaleCheat = 1.7;

This should be ...typeof scaleCheat == "undefined"... I mean, I suppose as long as no one has created a variable named "undefined" then it is in fact undefined, but it seems kind of sketchy to me.

Otherwise looks good. Bravo for reducing our redundancy!

Comment 4

[Ian Gilman [:iangilman]]

Comment on attachment 485602 [details] [diff] [review]
Patch v1

if (!scaleCheat)... would be fine as well in this context; you don't want to be dividing by zero anyway.

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v2

Comment 6

[Ian Gilman [:iangilman]]

Comment on attachment 487248 [details] [diff] [review]
Patch v2

Canceling approval now that it's blocking. Mitcho, please package. Does it need try?

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch 2, updated for rot

Updated for rot so sent to try, just in case: ca073655dc07

Comment 8

[Michael Yoshitaka Erlewine [:mitcho]]

Try was inconclusive (with a lot of intermittent orange) so sent again: 8340b5949ef2

Comment 9

[Michael Yoshitaka Erlewine [:mitcho]]

One (different) intermittent orange again, so running again: 5cb1c0e374ff

Comment 10

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Finally got a completely clean try. Ready for checkin.

Comment 11

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/70489f92c25f

Comment 12

[Tracy Walker [:tracy]]

Verified in recent nightly minefield build