605100 - Add services & sync folders to mobile/build.mk

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[ahoza]

Device: Nokia N900
BuildID: Mozilla /5.0 (Maemo;Linux armv7l;rv:2.0b8pre)Gecko/20101018
Firefox/4.0b8pre Fennec /4.0b2pre 

Device: HTC Desire
BuildID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre) Gecko/20101018
Firefox/4.0b8pre Fennec /4.0b2pre 

Steps reproduce:

1. Open Fennec.
2. Open Options->Preferences and enter information in sync fields.
3. Tap "Connect"

Expected results:
Device is connected to sync server.

Actual results:
Nothing happens.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Is this for a clean profile that has never been synced before?
Is the 'connect' button disabled?

Comment 2

[ahoza]

The button doesn't look to be disabled, but it acts as if it were.
I've tried with an account that I've successfully synced in the previous week.
I've also created a new sync account and tried to sync with it. Couldn't connect either. 
As for Fennec, on Nokia N900, I've deleted profile folder before installing the latest build.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Can you get a screenshot? We recently landed code that will make the Sync UI look like it is connecting when Fennec starts - _if_ the user has already filled in the account name, password and sync key previously.

We do this because Sync will be auto-connecting in a few seconds anyway.

You might have found a regression from that - or you are just seeing the correct behavior (if the button is disabled)

Comment 4

[ahoza]

Attachment: Screenshot

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Did you type the account name, password, and sync key? Or did they auto-fill?

Comment 6

[Aakash Desai [:aakashd]]

I typed in the account name, password and sync key and the connect button did nothing.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #6)
> I typed in the account name, password and sync key and the connect button did
> nothing.

Doesn't seem to be a regression from bug 602077.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I used an email address instead of an account name (non email address), password, and sync from a clean install (no profile) on Droid 2, and the connect button did nothing.

Trying to go to about:sync-log gives error message of :"The URL is not valid and cannot be loaded."

Comment 9

[Philipp von Weitershausen [:philikon]]

(In reply to comment #8)
> Trying to go to about:sync-log gives error message of :"The URL is not valid
> and cannot be loaded."

Sync no longer writes the log by default. You can change that by creating the services.sync.log.appender.debugLog preference as a Boolean and set it to true. You should see errors in the error console, too, though.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

In error console:
Error: Weave is not defined  Source File: chrome://browser/content/sync.js Line: 75

Comment 11

[Philipp von Weitershausen [:philikon]]

(In reply to comment #9)
> Sync no longer writes the log by default. You can change that by creating the
> services.sync.log.appender.debugLog preference as a Boolean and set it to true.

Ugh, sorry, this should be services.sync.log.appender.debugLog.enabled = true (forgot the .enabled)

Comment 12

[juan becerra [:juanb]]

I tried to Sync Now using the Tools menu item on Mac on the latest nightly, then I went to about:sync-log, and there's no update since the 15th. Shift reloading after Sync Now doesn't change this.

Comment 13

[juan becerra [:juanb]]

After talking to tchung, I rescind my blocking request. I was under the impression the sync'ing process was not working, instead of the logging part, which is not a blocking problem.

Comment 14

[Philipp von Weitershausen [:philikon]]

(In reply to comment #13)
> After talking to tchung, I rescind my blocking request. I was under the
> impression the sync'ing process was not working, instead of the logging part,
> which is not a blocking problem.

As I've noted in comment 9, Sync will no longer log to disk by default (for obvious performance reasons), but as noted in comment 11 you can flip it back on using the services.sync.log.appender.debugLog.enabled pref.

Comment 15

[Tony Chung [:tchung]]

can we get this approved to block beta 2 please?

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

We found this bug is a regression from bug 586867, which needed some code to be added to mobile/build.mk

Comment 17

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Seems to work for me now

Comment 18

[[:fabrice] Fabrice Desré]

Comment on attachment 484100 [details] [diff] [review]
patch

Works here for me also.

Comment 19

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/55edc5093be0

Comment 20

[ahoza]

Verified as fixed on BuildID: Mozilla /5.0 (Maemo;Linux rmv7l;rv:2.0b8pre)Gecko/20101019 Firefox/4.0b8pre Fennec /4.0b2pre

Comment 21

[Tony Chung [:tchung]]

(In reply to comment #20)
> Verified as fixed on BuildID: Mozilla /5.0 (Maemo;Linux
> rmv7l;rv:2.0b8pre)Gecko/20101019 Firefox/4.0b8pre Fennec /4.0b2pre

Adriana, please also verify this is also fixed on Android before marking RESOLVED FIXED.

Comment 22

[Tony Chung [:tchung]]

(In reply to comment #21)
> (In reply to comment #20)
> > Verified as fixed on BuildID: Mozilla /5.0 (Maemo;Linux
> > rmv7l;rv:2.0b8pre)Gecko/20101019 Firefox/4.0b8pre Fennec /4.0b2pre
> 
> Adriana, please also verify this is also fixed on Android before marking
> RESOLVED FIXED.

I mean VERIFIED Fixed

Comment 23

[ahoza]

Verified as fixed on HTC Desire A8181, Motorola Droid 2 with buildID:
Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre)Gecko/20101019 Firefox/4.0b8pre Fennec /4.0b2pre