586867 - Weave should be built from browser/ and should work in a firefox on xulrunner setup

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

All of Weave lives in services/ and browser/.  We should move Weave out of tier-toolkit and remove the configure bits.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: POC

Probably should move browser/browservars.mk to browser/config/config.mk

Thoughts appreciated.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: POC

Add remove helps

Comment 3

[(not currently active) Ted Mielczarek]

I don't really understand the purpose of this patch. Can you elaborate? Having to sprinkle that include browservars.mk all around seems pretty crappy.

Comment 4

[Matt Brubeck (:mbrubeck)]

This will need a similar patch for the mobile-browser repo.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

The basic idea is that things that only affect the browser app shouldn't be configure variables.

Comment 6

[Mike Hommey [:glandium]]

Why not simply remove all these ifdefs ?

(also, you could use tier_app_dirs in browser/build.mk instead of DIRS in browser/Makefile.in)

Comment 8

[Mike Hommey [:glandium]]

Note that if services-sync is not made part of xulrunner, then resource://services-sync/some-file urls don't work on firefox-on-top-of-xulrunner setups.

Comment 9

[Mike Hommey [:glandium]]

Attachment: Part to have resource://services-sync work with firefox-on-xulrunner with services-sync on the application side

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 468445 [details] [diff] [review]
Part to have resource://services-sync work with firefox-on-xulrunner with services-sync on the application side

PhiliKON, can you review this?

I think we should just WONTFIX this bug because sync is on for good now, but I'm leaving it open to deal with this patch.

Comment 12

[Philipp von Weitershausen [:philikon]]

Comment on attachment 468445 [details] [diff] [review]
Part to have resource://services-sync work with firefox-on-xulrunner with services-sync on the application side

It doesn't seem right to me to do this without changing the build setup over from toolkit to browser as well.

Comment 13

[Mike Hommey [:glandium]]

Attachment: Define sync services as app tiers, not platform

This is the other patch I apply on debian to have sync build and work properly in FF-on-xulrunner setup.

Comment 14

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 478775 [details] [diff] [review]
Define sync services as app tiers, not platform

Note that fennec needs the same thing.

Comment 15

[Philipp von Weitershausen [:philikon]]

Comment on attachment 468445 [details] [diff] [review]
Part to have resource://services-sync work with firefox-on-xulrunner with services-sync on the application side

Note that this needs to go to fx-sync.

Comment 16

[Mike Hommey [:glandium]]

Requesting to land this on m-c because Linux distros using firefox-on-xulrunner setups need both patches to build and work properly (at least SuSE and Debian, not sure for others).

Comment 17

[Mike Hommey [:glandium]]

Landed on fx-sync
http://hg.mozilla.org/services/fx-sync/rev/db40d6f8c7a2

Comment 18

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Changing the summary to reflect what this bug became.

Comment 19

[Wolfgang Rosenauer [:wolfiR]]

So part of that landed in m-c now but what about the build changes?

Comment 20

[Mike Hommey [:glandium]]

m-c part landed
http://hg.mozilla.org/mozilla-central/rev/111e055a49dc

Comment 21

[Mike Hommey [:glandium]]

Backed-out
http://hg.mozilla.org/mozilla-central/rev/f64feb757627

Comment 22

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

So, as we discussed on IRC, the problem with the existing patch is that anything built after browser/app doesn't get packaged on Mac.  The fix is to move services/sync before browser and add some big scary comments to the next person to wander down this road.

Comment 23

[Mike Hommey [:glandium]]

Attachment: Define sync services as app tiers, not platform

Take 2.

Comment 24

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 483448 [details] [diff] [review]
Define sync services as app tiers, not platform

I'd like the comment to say why ("they won't get packaged properly on mac"), but other than that, it's good.

Comment 25

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/36aa9c19420e

Comment 26

[Stuart Parmenter]

fyi, this broke Fennec builds, as comment #4 said it would....

Comment 27

[Matt Brubeck (:mbrubeck)]

Attachment: mobile-browser patch

Comment 28

[Matt Brubeck (:mbrubeck)]

Comment on attachment 484112 [details] [diff] [review]
mobile-browser patch

Nevermind, I just found bug 605100.