Closed
Bug 605177
Opened 12 years ago
Closed 12 years ago
Fix build warnings in editor/
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file, 1 obsolete file)
12.51 KB,
patch
|
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Attachment #484013 -
Flags: review?(ehsan)
Comment 1•12 years ago
|
||
Comment on attachment 484013 [details] [diff] [review] Patch v1 >diff --git a/editor/txtsvc/src/nsTextServicesDocument.cpp b/editor/txtsvc/src/nsTextServicesDocument.cpp >- PRInt32 nodeIndex, tcount; >- PRBool hasEntry; >+ PRInt32 tcount; >+ PRInt32 nodeIndex = 0; >+ PRBool hasEntry = PR_FALSE; Why are you not initializing tcount as well? Looks good otherwise.
Attachment #484013 -
Flags: review?(ehsan)
Assignee | ||
Comment 2•12 years ago
|
||
Because tcount is initialized unconditionally later in the function. How about @@ -1846,1 +1847,1 @@ -tcount = mOffsetTable.Length(); +PRInt32 tcount = mOffsetTable.Length(); instead?
Assignee | ||
Updated•12 years ago
|
Attachment #484013 -
Flags: review?(ehsan)
Comment 3•12 years ago
|
||
Comment on attachment 484013 [details] [diff] [review] Patch v1 (In reply to comment #2) > Because tcount is initialized unconditionally later in the function. How about > > @@ -1846,1 +1847,1 @@ > -tcount = mOffsetTable.Length(); > +PRInt32 tcount = mOffsetTable.Length(); > > instead? That makes more sense. r=me with that change.
Attachment #484013 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Done.
Attachment #484013 -
Attachment is obsolete: true
Attachment #485136 -
Flags: approval2.0?
Updated•12 years ago
|
Attachment #485136 -
Flags: approval2.0? → approval2.0+
Comment 5•12 years ago
|
||
Temporarily assigning to me so that this patch shows up in my "needs landing" query. Will assign back to Ms2ger once I land this.
Assignee: Ms2ger → ehsan
Whiteboard: [build_warning] → [build_warning][needs landing]
Comment 6•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8f95ff16a6ba
Assignee: ehsan → Ms2ger
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][needs landing] → [build_warning]
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•