605177 - Fix build warnings in editor/

Status: RESOLVED FIXED

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 484013 [details] [diff] [review]
Patch v1

Comment 1

[:Ehsan Akhgari]

Comment on attachment 484013 [details] [diff] [review]
Patch v1

>diff --git a/editor/txtsvc/src/nsTextServicesDocument.cpp b/editor/txtsvc/src/nsTextServicesDocument.cpp
>-  PRInt32 nodeIndex, tcount;
>-  PRBool hasEntry;
>+  PRInt32 tcount;
>+  PRInt32 nodeIndex = 0;
>+  PRBool hasEntry = PR_FALSE;

Why are you not initializing tcount as well?

Looks good otherwise.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Because tcount is initialized unconditionally later in the function. How about

@@ -1846,1 +1847,1 @@
-tcount = mOffsetTable.Length();
+PRInt32 tcount = mOffsetTable.Length();

instead?

Comment 3

[:Ehsan Akhgari]

Comment on attachment 484013 [details] [diff] [review]
Patch v1

(In reply to comment #2)
> Because tcount is initialized unconditionally later in the function. How about
> 
> @@ -1846,1 +1847,1 @@
> -tcount = mOffsetTable.Length();
> +PRInt32 tcount = mOffsetTable.Length();
> 
> instead?

That makes more sense.  r=me with that change.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 485136 [details] [diff] [review]
Patch v2

Done.

Comment 5

[:Ehsan Akhgari]

Temporarily assigning to me so that this patch shows up in my "needs landing" query.  Will assign back to Ms2ger once I land this.

Comment 6

[:Ehsan Akhgari]

http://hg.mozilla.org/mozilla-central/rev/8f95ff16a6ba