605459 - Installing any add-on from Add-ons Manager shows empty EULA dialog

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect, P1)

Description

[Jorge Villalobos [:jorgev] (he/him)]

If you install the YSlow add-on from its description page (https://addons.mozilla.org/en-US/firefox/addon/5369/), everything works as expected. There's no EULA or other roadblocks, it installs right away.

If you install it from the Add-ons Manager window (on 3.6 at least), a EULA dialog is presented with only the text "None". The dialog can be accepted and the installation continues.

Looking at the response from the API, I can see this in all results:
<eula>None</eula>

I tried with other add-ons, and the result is the same.

Comment 1

[Justin Scott [:fligtar]]

This needs a production patch.

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/compare/5.12.1.1...5.12.1.2
Also in master:
http://github.com/jbalogh/zamboni/commit/3ee42c7

Comment 3

[krupa raj[:krupa]]

Verified that no EULA is shown to users while installing YSLow from the add-ons manager(on 3.6)

For add-ons with EULA, it is displayed before install (as expected).

Comment 4

[krupa raj[:krupa]]

Attachment: post-fix screenshot

Comment 5

[Dave Townsend [:mossop]]

This seems to have reverted

Comment 7

[Jeff Balogh (:jbalogh)]

Pushing again in bug 607982.

Comment 8

[krupa raj[:krupa]]

verified