Last Comment Bug 605503 - Port |Bug 570387 - PlacesDBUtils should register itself in the idle-daily category| to SeaMonkey
: Port |Bug 570387 - PlacesDBUtils should register itself in the idle-daily cat...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b2
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
Depends on: 570387 605657
Blocks: 570388
  Show dependency treegraph
 
Reported: 2010-10-19 10:03 PDT by Serge Gautherie (:sgautherie)
Modified: 2011-01-29 23:20 PST (History)
2 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Package PlacesCategoriesStarter.js [Checked in: Comment 6] (1.10 KB, patch)
2010-10-19 10:16 PDT, Serge Gautherie (:sgautherie)
bugspam.Callek: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2010-10-19 10:03:44 PDT

    
Comment 1 Serge Gautherie (:sgautherie) 2010-10-19 10:16:20 PDT
Created attachment 484353 [details] [diff] [review]
(Av1) Package PlacesCategoriesStarter.js
[Checked in: Comment 6]

Should fix
{
+bin/components/PlacesCategoriesStarter.js
}
Comment 2 Marco Bonardo [::mak] 2010-10-19 15:01:30 PDT
you should also kill any code that calls PlacesUtils.startPlacesDBUtils() since now the service will start by itself
Comment 3 Justin Wood (:Callek) (Away until Aug 29) 2010-10-19 15:24:39 PDT
Comment on attachment 484353 [details] [diff] [review]
(Av1) Package PlacesCategoriesStarter.js
[Checked in: Comment 6]

Without checking package-compare or stuff, I'll treat it as a rs+. but I'm comfortable here.
Comment 4 Justin Wood (:Callek) (Away until Aug 29) 2010-10-19 15:26:11 PDT
(In reply to comment #2)
> you should also kill any code that calls PlacesUtils.startPlacesDBUtils() since
> now the service will start by itself

FYI: http://mxr.mozilla.org/comm-central/search?string=startPlacesDBUtils returns no comm-central users.
Comment 5 Marco Bonardo [::mak] 2010-10-19 15:33:46 PDT
most likely it was never activated on SM. This change makes that code more toolkit-ish (Apart the packaging), so it should be better.
Comment 6 Serge Gautherie (:sgautherie) 2010-10-19 16:06:42 PDT
Comment on attachment 484353 [details] [diff] [review]
(Av1) Package PlacesCategoriesStarter.js
[Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/4abc23bbf32f
Comment 7 Serge Gautherie (:sgautherie) 2010-10-19 16:24:24 PDT
I filed bug 605657 for SM 2.0.x.

Note You need to log in before you can comment on or make changes to this bug.