Port |Bug 431558 - implement preventive maintenance for places.sqlite| to SeaMonkey 2.0

RESOLVED FIXED

Status

SeaMonkey
Startup & Profiles
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({fixed-seamonkey2.0.11})

SeaMonkey 2.0 Branch
fixed-seamonkey2.0.11
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Noticed while working on bug 605503 (for SM 2.1).

PS: Maybe it will have a good effect on my currently 20 MB file, which takes a few seconds to load(!?).
(Assignee)

Comment 1

7 years ago
Created attachment 484974 [details] [diff] [review]
(Av1) Call PlacesUtils.startPlacesDBUtils()
[Checked in: Comment 6]

We also need to import utils.js there:
the other PlacesUtils.* in that file probably get it from elsewhere.
Should I copy the full global scope getter that exists elsewhere?
Attachment #484974 - Flags: review?(kairo)
(Assignee)

Comment 2

7 years ago
Comment on attachment 484974 [details] [diff] [review]
(Av1) Call PlacesUtils.startPlacesDBUtils()
[Checked in: Comment 6]

Ah, maybe the import could be inside the anonymous function: do we care!?
(Assignee)

Updated

7 years ago
Blocks: 605503
(Assignee)

Updated

7 years ago
Component: Build Config → Startup & Profiles
QA Contact: build-config → profile-manager

Comment 3

7 years ago
Does the 1.9.1 platform even support all this? Have you verified that?
(Assignee)

Comment 4

7 years ago
(In reply to comment #3)
> Does the 1.9.1 platform even support all this? Have you verified that?

What is "all this" and what kind of verification are you looking for?

Bug 431558 was checked in in m-1.9.1, a SeaMonkey 2.0.x profile has a places.sqlite file, the error console doesn't report any issue when starting with this patch.

Updated

7 years ago
Attachment #484974 - Flags: review?(kairo) → review+

Comment 5

7 years ago
(In reply to comment #4)
> Bug 431558 was checked in in m-1.9.1

That's what I was looking for ;-)
(Assignee)

Updated

7 years ago
Attachment #484974 - Flags: approval-seamonkey2.0.10?

Updated

7 years ago
Attachment #484974 - Flags: approval-seamonkey2.0.10? → approval-seamonkey2.0.10+
(Assignee)

Comment 6

7 years ago
Comment on attachment 484974 [details] [diff] [review]
(Av1) Call PlacesUtils.startPlacesDBUtils()
[Checked in: Comment 6]

http://hg.mozilla.org/releases/comm-1.9.1/rev/4989d277c9ec
Attachment #484974 - Attachment description: (Av1) Call PlacesUtils.startPlacesDBUtils() → (Av1) Call PlacesUtils.startPlacesDBUtils() [Checked in: Comment 6]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Keywords: fixed-seamonkey2.0.10
Resolution: --- → FIXED
(Assignee)

Comment 7

7 years ago
Comment on attachment 484974 [details] [diff] [review]
(Av1) Call PlacesUtils.startPlacesDBUtils()
[Checked in: Comment 6]

"approval-seamonkey2.0.9=?":
Just in case you would want to include it yet...
Attachment #484974 - Flags: approval-seamonkey2.0.9?

Comment 8

7 years ago
Comment on attachment 484974 [details] [diff] [review]
(Av1) Call PlacesUtils.startPlacesDBUtils()
[Checked in: Comment 6]

2.0.9 has been shipped a few days ago, no approvals can be taken for it any more.
Attachment #484974 - Flags: approval-seamonkey2.0.9?
You need to log in before you can comment on or make changes to this bug.