605657 - Port |Bug 431558 - implement preventive maintenance for places.sqlite| to SeaMonkey 2.0

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Serge Gautherie (:sgautherie)]

Noticed while working on bug 605503 (for SM 2.1).

PS: Maybe it will have a good effect on my currently 20 MB file, which takes a few seconds to load(!?).

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Call PlacesUtils.startPlacesDBUtils() [Checked in: Comment 6]

We also need to import utils.js there:
the other PlacesUtils.* in that file probably get it from elsewhere.
Should I copy the full global scope getter that exists elsewhere?

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 484974 [details] [diff] [review]
(Av1) Call PlacesUtils.startPlacesDBUtils()
[Checked in: Comment 6]

Ah, maybe the import could be inside the anonymous function: do we care!?

Comment 3

[Robert Kaiser]

Does the 1.9.1 platform even support all this? Have you verified that?

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Does the 1.9.1 platform even support all this? Have you verified that?

What is "all this" and what kind of verification are you looking for?

Bug 431558 was checked in in m-1.9.1, a SeaMonkey 2.0.x profile has a places.sqlite file, the error console doesn't report any issue when starting with this patch.

Comment 5

[Robert Kaiser]

(In reply to comment #4)
> Bug 431558 was checked in in m-1.9.1

That's what I was looking for ;-)

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 484974 [details] [diff] [review]
(Av1) Call PlacesUtils.startPlacesDBUtils()
[Checked in: Comment 6]

http://hg.mozilla.org/releases/comm-1.9.1/rev/4989d277c9ec

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 484974 [details] [diff] [review]
(Av1) Call PlacesUtils.startPlacesDBUtils()
[Checked in: Comment 6]

"approval-seamonkey2.0.9=?":
Just in case you would want to include it yet...

Comment 8

[Robert Kaiser]

Comment on attachment 484974 [details] [diff] [review]
(Av1) Call PlacesUtils.startPlacesDBUtils()
[Checked in: Comment 6]

2.0.9 has been shipped a few days ago, no approvals can be taken for it any more.