60552 - Toolbar buttons should have width >= height

Status: NEW

(Core :: XUL, defect)

Description

[Matthew T (active 1999-2002)]

Build: 2000111520

To reproduce:
* Switch to the Classic theme, if you are not already using it.
* Mouse over the `Next' button in a Messenger three-pane window, or the `New'
  button, `Open' button, or `Save' button in a Composer window.

What you should see:
* The button is at least as wide as it is high -- in this case, the button is
  square because its content is narrower than it is high.

What you actually see:
* The button is considerably narrower than it is high, making it look weird.

For dual menubuttons, this measurement should use the button part of the 
menubutton, not the menubutton as a whole.

Comment 1

[hangas]

Sending to Andrew

Comment 2

[hangas]

Themes Triage Team P3, be really nice to have min-width here

Comment 3

[andreww]

setting milestone.

Comment 4

[andreww]

Attachment: patch for messenger.css

Comment 5

[andreww]

Attachment: patch for editortoolbars.css

Comment 6

[andreww]

ready for review.

Comment 7

[timeless]

r=timeless

Comment 8

[Joe Hewitt (gone)]

sr=hewitt

Comment 9

[andreww]

fix checked into trunk.

Comment 10

[Patty Mac]

Marking verified on Mac (2001-03-19-12-Mtrunk).

Comment 11

[andreww]

Reopening - the change I made was not the best way to do this and Pinkerton feels 
this should be a toolkit fix. Sending to him to filter to whomever.

Comment 12

[andreww]

reassigning .... now.

Comment 13

[Mike Pinkerton (not reading bugmail)]

box improvements needed

Comment 14

[Charles Manske]

I really think we should file a separate bug for the request to support
"equal-size" or whatever evaughan want's to call the attribute to make different
buttons the same size.
Changing platform to All and milestone, since 0.8.1 has passed!

Comment 15

[Dan Rosen]

i could take a stab at this...

Comment 16

[Matthew T (active 1999-2002)]

When I filed this bug I also filed bug 60553 for making different buttons the 
same width, in the knowledge that that was a separate issue from making them 
wider than they were high. Stuff about equal-size should go in that bug, not 
this one. Restoring original summary.

This bug may be considered fixed now, but from reading the patch I see that it 
just applies a hard-coded width. So it won't work properly once we can choose 
graphic-only buttons (bug 22056), or once we can choose between small or large 
toolbar icons (bug 62444).

Comment 17

[Dan Rosen]

> This bug may be considered fixed now, but from reading the patch I see that it
> just applies a hard-coded width.

Yeah, that's why this was reopened (see andreww's comments). Just checked out
60553, thanks for the info on that. Any opinion what ought to be done here?

Comment 18

[Matthew T (active 1999-2002)]

I guess this would be XBL for the toolbar button widget. Each button would need 
to check how high it is, and make sure it's at least as wide as that.

Comment 19

[Dan Rosen]

That'd be a solution; another more generic one might be to implement a CSS
extension to do this sort of thing, but I don't know what drawbacks that might
have...

If we were to take the XBL route, which seems likely to me, I'd prefer to have a
"button-with-width-greater-than-height" sort of binding and let toolbar buttons
extend that... Sound reasonable?

Comment 20

[Dan Rosen]

->0.9.3 (not a netscape rtm stopper, per pdt)

Comment 21

[Dan Rosen]

[spam] [e-mail]'s bugs subject to redistribution by chofmann. R!

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.