60553 - All buttons in a toolbar should be as wide as the widest one

Status: NEW

(Core :: XUL, defect)

Description

[Matthew T (active 1999-2002)]

To reproduce:
* Switch to the Classic theme, if you are not using it already.
* Mouse over the buttons in the toolbar of a Navigator, Messenger, or Composer
  window.

What you should see:
* All buttons are the same width.

What you actually see:
* Buttons are different widths, depending on how wide their icon and button text
  happens to be. This results in the buttons having variable target areas which
  are completely independent from common the button actions are, and that's just
  Wrong.

Problem occurs with:
* 2000111520 build, Mac OS 9.0

Does not occur with:
* Internet Explorer 5.0, Windows 98

For dual menubuttons, the width of the button part of the menubutton (not the 
menubutton as a whole) should be the same as the width of other buttons in the 
toolbar.

I'm sticking this in XP Apps: GUI, because I don't think this is a Themes issue. 
Firstly, the width for the toolbar buttons needs to be recalculated whenever a 
button is added to or removed from the toolbar, something which I don't think 
themes are capable of. And secondly, this problem applies across all themes given 
that a theme can't know how long toolbar button text is going to be in a given 
localization.

Comment 1

[Matthew T (active 1999-2002)]

This needs to be implemented after bug 60552, otherwise it will be impossible to 
tell whether bug 60552 has been properly fixed without creating test chrome for 
it.

Comment 2

[Henri Sivonen (:hsivonen)]

In the case of the browser window, making buttons wider would make the location bar 
shorter. Of course, this wouldn't be a problem, if the user could move the location bar 
below the navigation bar is (s)he so wished.

Comment 3

[andreww]

seems like themes still need to play a role here. A skin designer may decide to
not have their buttons all the same size and would need to be able to override
any default width behavior.

Comment 4

[andreww]

ccing pinkerton since he's taken the bug which this depends on - and this bug 
might even be the real one to fix instead.

Comment 5

[Dan Rosen]

Nominating 1.0. A solution talked about in bug 60552 would be simply to
implement an "equal-size" or "equal-size-children" or some such attribute or
property on box. I wonder if hyatt or evaughan have kicked that idea around.
Reassigning, for the moment...

Comment 6

[David Hyatt]

So this is essentially a request to support equal-size.  Not gonna happen for 
1.0 but happy to supply guidelines if someone wants to take this on.  Futuring.

Comment 7

[David Hyatt]

--> default owner