Closed Bug 605586 Opened 14 years ago Closed 14 years ago

[Mac default] Style the Findbar

Categories

(SeaMonkey :: Themes, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b2

People

(Reporter: stefanh, Assigned: stefanh)

Details

Attachments

(2 files, 1 obsolete file)

The View Source Findbar looks a bit odd in Mac default:
- it needs some more heigh
- the color of the bottom border is wrong
Attached patch Make findbar look better (obsolete) — Splinter Review
Note: we don't need the min-height, it's already in pinstripe.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #484439 - Flags: superreview?(neil)
Attachment #484439 - Flags: review?(mnyromyr)
Actually, I now see that the findbar looks bad in the browser as well. Hmm, wouldn't it look bad on win/nix too? I mean, wouldn't they need the view source styling for the browser findbar?
In that case, maybe we could put the styling in one place (optionally we should flip the help findbar as well)
Hmm, right... we have those overlays...
I'll have a new patch up that also fixes navigator
Summary: [Mac default] Style the View Source Findbar → [Mac default] Style the Findbar
Attached patch New versionSplinter Review
Attachment #484439 - Attachment is obsolete: true
Attachment #484487 - Flags: superreview?(neil)
Attachment #484487 - Flags: review?(mnyromyr)
Attachment #484439 - Flags: superreview?(neil)
Attachment #484439 - Flags: review?(mnyromyr)
I filed bug 605622 for the help findbar
(In reply to comment #3)
> Actually, I now see that the findbar looks bad in the browser as well. Hmm,
> wouldn't it look bad on win/nix too? I mean, wouldn't they need the view source
> styling for the browser findbar?
You're absolutely right, it does look bad on win/nix. (Although the view source styling isn't 100% perfect because it could do with 1px of top border.)
Attachment #484487 - Flags: superreview?(neil) → superreview+
Attachment #484487 - Flags: review?(mnyromyr) → review+
http://hg.mozilla.org/comm-central/rev/cec5d81ab835
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: