Closed
Bug 605586
Opened 14 years ago
Closed 14 years ago
[Mac default] Style the Findbar
Categories
(SeaMonkey :: Themes, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b2
People
(Reporter: stefanh, Assigned: stefanh)
Details
Attachments
(2 files, 1 obsolete file)
51.24 KB,
image/png
|
Details | |
6.98 KB,
patch
|
mnyromyr
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
The View Source Findbar looks a bit odd in Mac default: - it needs some more heigh - the color of the bottom border is wrong
Assignee | ||
Comment 1•14 years ago
|
||
Note: we don't need the min-height, it's already in pinstripe.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #484439 -
Flags: superreview?(neil)
Attachment #484439 -
Flags: review?(mnyromyr)
Assignee | ||
Comment 2•14 years ago
|
||
Assignee | ||
Comment 3•14 years ago
|
||
Actually, I now see that the findbar looks bad in the browser as well. Hmm, wouldn't it look bad on win/nix too? I mean, wouldn't they need the view source styling for the browser findbar?
Assignee | ||
Comment 4•14 years ago
|
||
In that case, maybe we could put the styling in one place (optionally we should flip the help findbar as well)
Assignee | ||
Comment 5•14 years ago
|
||
Hmm, right... we have those overlays...
Assignee | ||
Comment 6•14 years ago
|
||
I'll have a new patch up that also fixes navigator
Summary: [Mac default] Style the View Source Findbar → [Mac default] Style the Findbar
Assignee | ||
Comment 7•14 years ago
|
||
Attachment #484439 -
Attachment is obsolete: true
Attachment #484487 -
Flags: superreview?(neil)
Attachment #484487 -
Flags: review?(mnyromyr)
Attachment #484439 -
Flags: superreview?(neil)
Attachment #484439 -
Flags: review?(mnyromyr)
Assignee | ||
Comment 8•14 years ago
|
||
I filed bug 605622 for the help findbar
Comment 9•14 years ago
|
||
(In reply to comment #3) > Actually, I now see that the findbar looks bad in the browser as well. Hmm, > wouldn't it look bad on win/nix too? I mean, wouldn't they need the view source > styling for the browser findbar? You're absolutely right, it does look bad on win/nix. (Although the view source styling isn't 100% perfect because it could do with 1px of top border.)
Updated•14 years ago
|
Attachment #484487 -
Flags: superreview?(neil) → superreview+
Updated•14 years ago
|
Attachment #484487 -
Flags: review?(mnyromyr) → review+
Assignee | ||
Comment 10•14 years ago
|
||
http://hg.mozilla.org/comm-central/rev/cec5d81ab835
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
You need to log in
before you can comment on or make changes to this bug.
Description
•