[Mac default] Style the Findbar

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1b2
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
The View Source Findbar looks a bit odd in Mac default:
- it needs some more heigh
- the color of the bottom border is wrong
(Assignee)

Comment 1

7 years ago
Created attachment 484439 [details] [diff] [review]
Make findbar look better

Note: we don't need the min-height, it's already in pinstripe.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #484439 - Flags: superreview?(neil)
Attachment #484439 - Flags: review?(mnyromyr)
(Assignee)

Comment 2

7 years ago
Created attachment 484440 [details]
Screenshots before/after
(Assignee)

Comment 3

7 years ago
Actually, I now see that the findbar looks bad in the browser as well. Hmm, wouldn't it look bad on win/nix too? I mean, wouldn't they need the view source styling for the browser findbar?
(Assignee)

Comment 4

7 years ago
In that case, maybe we could put the styling in one place (optionally we should flip the help findbar as well)
(Assignee)

Comment 5

7 years ago
Hmm, right... we have those overlays...
(Assignee)

Comment 6

7 years ago
I'll have a new patch up that also fixes navigator
Summary: [Mac default] Style the View Source Findbar → [Mac default] Style the Findbar
(Assignee)

Comment 7

7 years ago
Created attachment 484487 [details] [diff] [review]
New version
Attachment #484439 - Attachment is obsolete: true
Attachment #484487 - Flags: superreview?(neil)
Attachment #484487 - Flags: review?(mnyromyr)
Attachment #484439 - Flags: superreview?(neil)
Attachment #484439 - Flags: review?(mnyromyr)
(Assignee)

Comment 8

7 years ago
I filed bug 605622 for the help findbar

Comment 9

7 years ago
(In reply to comment #3)
> Actually, I now see that the findbar looks bad in the browser as well. Hmm,
> wouldn't it look bad on win/nix too? I mean, wouldn't they need the view source
> styling for the browser findbar?
You're absolutely right, it does look bad on win/nix. (Although the view source styling isn't 100% perfect because it could do with 1px of top border.)

Updated

7 years ago
Attachment #484487 - Flags: superreview?(neil) → superreview+

Updated

7 years ago
Attachment #484487 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 10

7 years ago
http://hg.mozilla.org/comm-central/rev/cec5d81ab835
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
You need to log in before you can comment on or make changes to this bug.