Last Comment Bug 605586 - [Mac default] Style the Findbar
: [Mac default] Style the Findbar
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Themes (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: seamonkey2.1b2
Assigned To: Stefan [:stefanh]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-19 13:31 PDT by Stefan [:stefanh]
Modified: 2010-10-31 12:46 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Make findbar look better (6.20 KB, patch)
2010-10-19 13:45 PDT, Stefan [:stefanh]
no flags Details | Diff | Splinter Review
Screenshots before/after (51.24 KB, image/png)
2010-10-19 13:45 PDT, Stefan [:stefanh]
no flags Details
New version (6.98 KB, patch)
2010-10-19 14:58 PDT, Stefan [:stefanh]
mnyromyr: review+
neil: superreview+
Details | Diff | Splinter Review

Description Stefan [:stefanh] 2010-10-19 13:31:00 PDT
The View Source Findbar looks a bit odd in Mac default:
- it needs some more heigh
- the color of the bottom border is wrong
Comment 1 Stefan [:stefanh] 2010-10-19 13:45:13 PDT
Created attachment 484439 [details] [diff] [review]
Make findbar look better

Note: we don't need the min-height, it's already in pinstripe.
Comment 2 Stefan [:stefanh] 2010-10-19 13:45:48 PDT
Created attachment 484440 [details]
Screenshots before/after
Comment 3 Stefan [:stefanh] 2010-10-19 14:25:04 PDT
Actually, I now see that the findbar looks bad in the browser as well. Hmm, wouldn't it look bad on win/nix too? I mean, wouldn't they need the view source styling for the browser findbar?
Comment 4 Stefan [:stefanh] 2010-10-19 14:27:01 PDT
In that case, maybe we could put the styling in one place (optionally we should flip the help findbar as well)
Comment 5 Stefan [:stefanh] 2010-10-19 14:34:20 PDT
Hmm, right... we have those overlays...
Comment 6 Stefan [:stefanh] 2010-10-19 14:58:12 PDT
I'll have a new patch up that also fixes navigator
Comment 7 Stefan [:stefanh] 2010-10-19 14:58:51 PDT
Created attachment 484487 [details] [diff] [review]
New version
Comment 8 Stefan [:stefanh] 2010-10-19 14:59:47 PDT
I filed bug 605622 for the help findbar
Comment 9 neil@parkwaycc.co.uk 2010-10-19 16:01:22 PDT
(In reply to comment #3)
> Actually, I now see that the findbar looks bad in the browser as well. Hmm,
> wouldn't it look bad on win/nix too? I mean, wouldn't they need the view source
> styling for the browser findbar?
You're absolutely right, it does look bad on win/nix. (Although the view source styling isn't 100% perfect because it could do with 1px of top border.)
Comment 10 Stefan [:stefanh] 2010-10-31 12:46:21 PDT
http://hg.mozilla.org/comm-central/rev/cec5d81ab835

Note You need to log in before you can comment on or make changes to this bug.