Make findbar appear above content and style it properly

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Help Documentation
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1b2
x86
All

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
We have the findbar above content in view source and the browser, so I think we should have it the same in help.
(Assignee)

Comment 1

7 years ago
Created attachment 484482 [details] [diff] [review]
flip the findbar and style it [Checked In: Comment 7]
Attachment #484482 - Flags: superreview?(neil)
Attachment #484482 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 2

7 years ago
If you're worried about the mac styling, see bug 605586
(Assignee)

Comment 3

7 years ago
  #help-sidebar-splitter {
   -moz-border-end: 1px solid #BEBEBE;
 }
+
+
+/* make findbar appear above content */

Ignore that extra line, I'll fix it on check-in

Comment 4

7 years ago
Comment on attachment 484482 [details] [diff] [review]
flip the findbar and style it [Checked In: Comment 7]

>+/* style findbar for being on top */
>+#FindToolbar {
>+  border-top: none;
Ideally the top border would actually be 1px solid ThreeDHighlight;
(same as a regular toolbar) (in all three windows) although the existing -moz-border-top-colors makes this a little trickier.
Attachment #484482 - Flags: superreview?(neil) → superreview+

Comment 5

7 years ago
(In reply to comment #4)
> (in all three windows)
But separately after this and bug 605586 are fixed of course.

Comment 6

7 years ago
Comment on attachment 484482 [details] [diff] [review]
flip the findbar and style it [Checked In: Comment 7]

r=me
Attachment #484482 - Flags: review?(iann_bugzilla) → review+

Comment 7

7 years ago
Comment on attachment 484482 [details] [diff] [review]
flip the findbar and style it [Checked In: Comment 7]

http://hg.mozilla.org/comm-central/rev/dfde00c9b4fc
Attachment #484482 - Attachment description: flip the findbar and style it → flip the findbar and style it [Checked In: Comment 7]
(Assignee)

Comment 8

7 years ago
Thanks for landing it Ian.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

7 years ago
JFTR, I noticed that we missed comment #3, so I fixed that in http://hg.mozilla.org/comm-central/rev/26435a548ad9
(Assignee)

Comment 10

7 years ago
(In reply to comment #5)
> (In reply to comment #4)
> > (in all three windows)
> But separately after this and bug 605586 are fixed of course.

ftr, I filed bug 608623.
You need to log in before you can comment on or make changes to this bug.