605622 - Make findbar appear above content and style it properly

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Stefan [:stefanh]]

We have the findbar above content in view source and the browser, so I think we should have it the same in help.

Comment 1

[Stefan [:stefanh]]

Attachment: flip the findbar and style it [Checked In: Comment 7]

Comment 2

[Stefan [:stefanh]]

If you're worried about the mac styling, see bug 605586

Comment 3

[Stefan [:stefanh]]

  #help-sidebar-splitter {
   -moz-border-end: 1px solid #BEBEBE;
 }
+
+
+/* make findbar appear above content */

Ignore that extra line, I'll fix it on check-in

Comment 4

[[e-mail]]

Comment on attachment 484482 [details] [diff] [review]
flip the findbar and style it [Checked In: Comment 7]

>+/* style findbar for being on top */
>+#FindToolbar {
>+  border-top: none;
Ideally the top border would actually be 1px solid ThreeDHighlight;
(same as a regular toolbar) (in all three windows) although the existing -moz-border-top-colors makes this a little trickier.

Comment 5

[[e-mail]]

(In reply to comment #4)
> (in all three windows)
But separately after this and bug 605586 are fixed of course.

Comment 6

[Ian Neal]

Comment on attachment 484482 [details] [diff] [review]
flip the findbar and style it [Checked In: Comment 7]

r=me

Comment 7

[Ian Neal]

Comment on attachment 484482 [details] [diff] [review]
flip the findbar and style it [Checked In: Comment 7]

http://hg.mozilla.org/comm-central/rev/dfde00c9b4fc

Comment 8

[Stefan [:stefanh]]

Thanks for landing it Ian.

Comment 9

[Stefan [:stefanh]]

JFTR, I noticed that we missed comment #3, so I fixed that in http://hg.mozilla.org/comm-central/rev/26435a548ad9

Comment 10

[Stefan [:stefanh]]

(In reply to comment #5)
> (In reply to comment #4)
> > (in all three windows)
> But separately after this and bug 605586 are fixed of course.

ftr, I filed bug 608623.