test_taskbar_jumplistitems.js leaks items

RESOLVED FIXED in Firefox 7

Status

()

Core
Widget: Win32
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jdm, Assigned: bbondy)

Tracking

(Blocks: 1 bug)

Trunk
mozilla9
x86
Windows 7
Points:
---

Firefox Tracking Flags

(firefox7 fixed, firefox8 fixed)

Details

(Whiteboard: [xpcshell-leak][qa-])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

7 years ago
== BloatView: ALL (cumulative) LEAK STATISTICS, default process 1928

     |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->|
                                              Per-Inst   Leaked    Total      Rem      Mean       StdDev     Total      Rem      Mean       StdDev
   0 TOTAL                                          21      244     5574       10 (  310.86 +/-   408.18)    15681       10 ( 1666.64 +/-  1933.76)
  52 nsCryptoHash                                   28       28        1        1 (    1.00 +/-     0.00)        3        1 (    1.40 +/-     0.55)
 114 nsSimpleURI                                    56      168        5        3 (    3.14 +/-     1.35)       63        3 (   10.99 +/-     5.24)
 119 nsStringBuffer                                  8       48     1705        6 (  791.34 +/-   421.27)     8511        6 ( 3038.74 +/-  1664.35)
(Reporter)

Updated

7 years ago
OS: Mac OS X → Windows 7

Comment 1

7 years ago
I wrote this so I suppose I should fix it. How series is this?
(Reporter)

Comment 2

7 years ago
I'm one of numerous xpcshell tests leaking, but leaks don't turn the tree orange at the moment.
(Reporter)

Updated

7 years ago
Whiteboard: [xpcshell-leak]
(Reporter)

Updated

7 years ago
Blocks: 606067
No longer blocks: 606067
Depends on: 469523
(Reporter)

Updated

7 years ago
Blocks: 469523
No longer depends on: 469523
(Assignee)

Updated

6 years ago
Assignee: nobody → netzen
(Assignee)

Comment 3

6 years ago
I noticed these leaks when running this test so I'll take this one.
(Assignee)

Comment 4

6 years ago
Created attachment 555620 [details] [diff] [review]
test_taskbar_jumplistitems.js leaks items

Virtual destructor was missing on the base class causing the derived class' destructor to not be hit.
Attachment #555620 - Flags: review?(jmathies)
(Assignee)

Comment 5

6 years ago
I think this one should probably be promoted above Nightly by the way because I think every 120 seconds it will leak more and more memory.  If you leave the browser open this can contribute to it getting slower.
(Assignee)

Comment 6

6 years ago
Created attachment 555630 [details] [diff] [review]
test_taskbar_jumplistitems.js leaks items v2

Accidentally had an extra semicolon.
Attachment #555620 - Attachment is obsolete: true
Attachment #555630 - Flags: review?(jmathies)
Attachment #555620 - Flags: review?(jmathies)
(Assignee)

Comment 7

6 years ago
This leak is probably not seen by other tests because it takes 120 seconds to start a new jumplist build and I'm not sure if any test runs that long.

Comment 8

6 years ago
Comment on attachment 555630 [details] [diff] [review]
test_taskbar_jumplistitems.js leaks items v2

oops.
Attachment #555630 - Flags: review?(jmathies) → review+
(Assignee)

Comment 9

6 years ago
I will push this to inbound, but should this be also pushed to aurora or beta channels?  If so what is the process for me to do that or request that?

Comment 10

6 years ago
(In reply to Brian R. Bondy [:bbondy] from comment #9)
> I will push this to inbound, but should this be also pushed to aurora or
> beta channels?  If so what is the process for me to do that or request that?

You can request branch landing via flags on the patch once it's landed. Drivers will then decide if it's worth the risk or if it should roll out normally.
(Assignee)

Comment 11

6 years ago
Created attachment 555733 [details] [diff] [review]
Rebased to mozilla-central tip so it doesn't require my jump list icon task
Attachment #555630 - Attachment is obsolete: true
Attachment #555733 - Flags: review+
(Assignee)

Comment 12

6 years ago
ok cool, thanks for the info!

Comment 13

6 years ago
Out of curiosity, worst case how big is the leak?
(Assignee)

Comment 14

6 years ago
15KiB every 2 minutes that the browser is left open.  Or 10MiB/day.
(Assignee)

Comment 15

6 years ago
Sorry that's if the leak is the same as what the xpcshell leaks.  I'm guessing it is +/- similar though.
(Assignee)

Comment 16

6 years ago
I'm sure it's fine but I'm running though try since I'm paranoid:

http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=45a9fd7932c4
http://hg.mozilla.org/mozilla-central/rev/8177de770dd2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
(Assignee)

Updated

6 years ago
Attachment #555733 - Flags: approval-mozilla-beta?
Attachment #555733 - Flags: approval-mozilla-aurora?
Comment on attachment 555733 [details] [diff] [review]
Rebased to mozilla-central tip so it doesn't require my jump list icon task

Approved to land for aurora and beta per todays driver meeting.
Attachment #555733 - Flags: approval-mozilla-beta?
Attachment #555733 - Flags: approval-mozilla-beta+
Attachment #555733 - Flags: approval-mozilla-aurora?
Attachment #555733 - Flags: approval-mozilla-aurora+

Comment 19

6 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/abb9bc5f7993
http://hg.mozilla.org/releases/mozilla-beta/rev/e8c0eb11e0c1
status-firefox7: --- → fixed
status-firefox8: --- → fixed
I filed bug 685266 to get a static analysis which checks for this case.
(Assignee)

Comment 21

6 years ago
I tried searching briefly for similar errors but didn't find any at the time.  Great idea Ehsan, thanks.

Updated

6 years ago
Whiteboard: [xpcshell-leak] → [xpcshell-leak], [qa-]
Whiteboard: [xpcshell-leak], [qa-] → [xpcshell-leak][qa-]
You need to log in before you can comment on or make changes to this bug.