Closed Bug 605930 Opened 9 years ago Closed 9 years ago

[RTL]Pressing on the search icon on the awesome page shows the dialog in LTR style


(Firefox for Android Graveyard :: General, defect)

Not set


(Not tracked)



(Reporter: nhirata, Assigned: vingtetun)



(5 files)

Attached image N900 Screenshot
Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b8pre) Gecko/20101020 Firefox/4.0b8pre Fennec/4.0b2pre
Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101020 Firefox/4.0b8pre Fennec/4.0b2pre

1. set browser to RTL (ie download/install arabic plugin :

Note : plugin installed notification will not show due to another bug)
2. click on awesome bar to go to awesome page
3. click on the search icon

a list of search sites and a RTL pointer pointing to the magnifying glass icon

1) no search sites
2) no pointer to the magnifying glass.

1. madhava noticed that there was an issue with RTL and the new theme
Attached image favicon click
Note: arrow is also pointing in the wrong location for clicking on the favicon when the browser is set to RTL.
Note: Issue 3. Clicking on the bookmark icon in the control panel also shows the arrow issue.
Separating the search engine issue as a different issue : Bug 606056
Retitled this bug.
Summary: [RTL]Pressing on the search icon on the awesome page is LTR style and does not show any search sites → [RTL]Pressing on the search icon on the awesome page shows the dialog in LTR style
Attached patch PatchSplinter Review
I have fixed the issues by doing 2 things:
 * adding a dir="ltr" to the arrowbox container  to have the inner arrow always on the left part of the box
 * adding container.dir="ltr" otherwise we're wrong when we think about normal/reverse mode in rtl

These changes does not affect the layout of the content, just the way the box is ordered
Attachment #485007 - Flags: review?(mark.finkle)
Attachment #485007 - Flags: review?(mark.finkle) → review+
Closed: 9 years ago
Resolution: --- → FIXED
Cannot verify for search engines in Awesomepage (search icon is disabled until plugins are installed), however favorites and site page are fixed.

Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b8pre) Gecko/20101022 Firefox/4.0b8pre Fennec/4.0b2pre
Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101022 Firefox/4.0b8pre Fennec/4.0b2pre
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.