605935 - Use private-browsing-transition-complete instead of sessionstore-browser-state-restored

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Ian Gilman [:iangilman]]

From bug 604458: 

(In reply to comment #12)
> As a side note, should we be observing private-browsing-transition-complete in
> our main PB handling code in tabview/ui.js? Right now we're observing
> private-browsing-change-granted, private-browsing, and
> sessionstore-browser-state-restored.

You should be observing private-browsing-transition-complete instead of
sessionstore-browser-state-restored.  Please file a separate bug for that
though.

Comment 1

[Ian Gilman [:iangilman]]

Attachment: patch v1

No test needed, as it's just refactoring.

Comment 2

[Ian Gilman [:iangilman]]

This patch requires the changes in bug 603721

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 487958 [details] [diff] [review]
patch v1

Then I'll approve it when that other patch gets checked in - please renominate then.

Comment 4

[Ian Gilman [:iangilman]]

It turns out this patch doesn't actually depend on bug 603721; I had built this on top of that, but in fact there is no overlap. Removing dependency.

Comment 5

[Kevin Hanes]

Moving to b9

Comment 6

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/8bb78383bdb6