Closed Bug 605935 Opened 9 years ago Closed 9 years ago

Use private-browsing-transition-complete instead of sessionstore-browser-state-restored

Categories

(Firefox Graveyard :: Panorama, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iangilman, Assigned: iangilman)

References

Details

Attachments

(1 file)

From bug 604458: 

(In reply to comment #12)
> As a side note, should we be observing private-browsing-transition-complete in
> our main PB handling code in tabview/ui.js? Right now we're observing
> private-browsing-change-granted, private-browsing, and
> sessionstore-browser-state-restored.

You should be observing private-browsing-transition-complete instead of
sessionstore-browser-state-restored.  Please file a separate bug for that
though.
Status: NEW → ASSIGNED
Attached patch patch v1Splinter Review
No test needed, as it's just refactoring.
Attachment #487958 - Flags: feedback?(ehsan)
Attachment #487958 - Flags: feedback?(ehsan) → review+
Attachment #487958 - Flags: approval2.0?
Blocks: 588597
No longer blocks: 588597
This patch requires the changes in bug 603721
Depends on: 603721
Comment on attachment 487958 [details] [diff] [review]
patch v1

Then I'll approve it when that other patch gets checked in - please renominate then.
Attachment #487958 - Flags: approval2.0? → approval2.0-
No longer depends on: 603721
It turns out this patch doesn't actually depend on bug 603721; I had built this on top of that, but in fact there is no overlap. Removing dependency.
Attachment #487958 - Flags: approval2.0- → approval2.0+
Blocks: 617511
Depends on: 594644
Moving to b9
Blocks: 598154
No longer blocks: 597043
http://hg.mozilla.org/mozilla-central/rev/8bb78383bdb6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.