605978 - land mozmill 1.5.1 and related tests on m-c

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

Attachment: patch to land mozmill 1.5.1 on m-c

we have a rare green run of mozmill 1.5.1 on macosx, macosx64, win7, and linux opt-unittest on the auto-tools staging buildbot:

http://tools-staging-master.mv.mozilla.com:8010/waterfall

This seems like a good opportunity to release 1.5.1 to pypi and push to mozilla-central.  Patch attached.

[Note that the following buildbotcustom patch is used for this master: http://k0s.org/mozilla/hg/buildbotcustom-patches/file/6355a0b15e4c/bug-516984 ]

Comment 1

[Jeff Hammel]

Note that this patch is from a mercurial queue.  While the patch may cleanly apply, it may be better to clone the patch queue and use that to apply it, as mercurial seems to do better at deleting things via a patch queue than just a straight patch.

mq repository:

http://k0s.org/mozilla/hg/mozilla-central-patches/

Comment 2

[cmtalbert]

Comment on attachment 484827 [details] [diff] [review]
patch to land mozmill 1.5.1 on m-c

looks like all the right changes have made it in :)

Comment 3

[cmtalbert]

Landed http://hg.mozilla.org/mozilla-central/rev/29d2042e54aa

Comment 4

[Jeff Hammel]

We should probably take out firefox\testPrivateBrowsing\testStartStopPBMode.js as this fails on debug (always on staging) and occassionally fails on opt (on my local linux box and on the tools' win7 slave)

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Are those still the same failures? Can you please attach the important lines as attachment to this bug?

Comment 6

[Aaron Train [:aaronmt]]

Verified fixed with http://hg.mozilla.org/mozilla-central/rev/29d2042e54aa

Comment 7

[Jeff Hammel]

(In reply to comment #5)
> Are those still the same failures? Can you please attach the important lines as
> attachment to this bug?

They are available here: 

http://tools-staging-master.mv.mozilla.com:8010/builders/Rev3%20MacOSX%20Leopard%2010.5.8%20mozilla-central%20debug%20test%20mozmill-all/builds/3/steps/run_mozmill/logs/stdio

I can paste as a comment, but don't really want to download an upload and have been yelled at for pasting logs as comments before.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The only error I can see in this log is testStartStopPbMode.js which is now tracked in bug 606971.