Closed Bug 606077 Opened 14 years ago Closed 14 years ago

Stop Autoplay extension broken (can't play flash) after landing of compartments

Categories

(Core :: XPConnect, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta9+

People

(Reporter: fehe, Assigned: mrbkap)

References

()

Details

(Keywords: regression)

The Stop Autoplay extension is broken by compartments and flash can no longer be played if the extension is enabled.

Considering the number of unintended breakages due to compartments landing, this is possibly also one such bug.

Note that this bug is different than bug 604420, as the patch in bug 484992, which fixes the bug for extensions link Adblock Plus, does not fix it for Stop Autoplay.

Regressed with: http://hg.mozilla.org/tracemonkey/rev/9cb987478e60

STR:
1. Create a new profile
2. Install Stop Autoplay 1.0: https://addons.mozilla.org/en-US/firefox/addon/1765/versions/ and restart
3. Visit a page with flash (e.g. youtube.com)
4. Notice that the extension's click to play button is no longer available (no way to enable the flash content) -- the plugin area remains blank.
5. Compare this with a build prior to TM cset 9cb987478e60
Blake, is this a dup of something we fixed today?
No, this is a dupe or depends on bug 601803 (the extension does adoptNode across compartments).
Let's retest once bug 601803 is fixed, then.
Depends on: 601803
blocking2.0: --- → ?
Depends on: 611982
No longer depends on: 611982
Yeah, let's re-test once bug 601803 is fixed, if it's still a problem, we need to look into it for Firefox 4.
Assignee: nobody → mrbkap
blocking2.0: ? → beta9+
Verified fixed by bug 601803.

Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101204 Firefox/4.0b8pre ID:20101204030328

http://hg.mozilla.org/mozilla-central/rev/cd392793b0c0
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.