add accessibility service (kNS_ACCESSIBILITY_SERVICE_CID) to service cache

RESOLVED FIXED in mozilla7

Status

()

Core
XPCOM
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: surkov, Assigned: tbsaunde)

Tracking

(Blocks: 1 bug, {access, perf})

Trunk
mozilla7
access, perf
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
follow up from bug 570275

bz: May be worth a followup bug to add the accessibility service to the service
cache...

surkvo: we keep accessibiltiy service instance in cache in a11y and return it when we
were asked, but if this is going to speed up things then it's worth to do.

bz: Yeah; it'll avoid going through the service manager at all to get the service..
(Reporter)

Updated

7 years ago
Blocks: 454202
Keywords: access, perf
(Reporter)

Comment 1

7 years ago
note, bug 628922 makes layout to use the accessibility service cached in a11y. For other places that should start accessibility if necessary then accessibility service manager should be used, it's worth to fix this bug for these cases (for that you need to fix xpcom/build/ServiceList.h, Service.cpp files)
(Assignee)

Comment 2

6 years ago
Created attachment 541985 [details] [diff] [review]
bug 606085 - add accessibility service to service list in xpcom/build/ServiceList.h
(Assignee)

Comment 3

6 years ago
Comment on attachment 541985 [details] [diff] [review]
bug 606085 - add accessibility service to service list in xpcom/build/ServiceList.h

I'm not sure if there's supposed to be an ordering to the expandos / includes.
Attachment #541985 - Flags: review?(surkov.alexander)
Attachment #541985 - Flags: review?(benjamin)
(Reporter)

Comment 4

6 years ago
Comment on attachment 541985 [details] [diff] [review]
bug 606085 - add accessibility service to service list in xpcom/build/ServiceList.h

Review of attachment 541985 [details] [diff] [review]:
-----------------------------------------------------------------

no my review is needed in this case (no a11y code is changed and iirc no a11y related code is affected)
Attachment #541985 - Flags: review?(surkov.alexander)
(Reporter)

Updated

6 years ago
Assignee: nobody → trev.saunders

Comment 5

6 years ago
Comment on attachment 541985 [details] [diff] [review]
bug 606085 - add accessibility service to service list in xpcom/build/ServiceList.h

All the other services use InitialCaps, please follow that convention. r=me with that change.
Attachment #541985 - Flags: review?(benjamin) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 542628 [details] [diff] [review]
patch v2

correct capatolization, I hadn't noticed that.
Attachment #541985 - Attachment is obsolete: true
Created attachment 543089 [details] [diff] [review]
bustage fix

FYI, mozilla-central is burning....  this fixed it in my tree.

Comment 8

6 years ago
Comment on attachment 543089 [details] [diff] [review]
bustage fix

Thanks, yes this looks fine!
Pushed the bustage fix:
http://hg.mozilla.org/mozilla-central/rev/2a75e12a105a
(Assignee)

Comment 10

6 years ago
(In reply to comment #7)
> Created attachment 543089 [details] [diff] [review] [review]
> bustage fix
> 
> FYI, mozilla-central is burning....  this fixed it in my tree.

dam, yeah we need that ifdef.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Target Milestone: --- → mozilla7
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.