LayerManagerD3D9.cpp compilation failure on mingw

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

474 bytes, patch
bas
: review+
Benjamin Smedberg
: approval2.0+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Created attachment 485016 [details] [diff] [review]
fix v1.0

After landing bug 601928 I get following failure when compiling on mingw:

mozilla-central/gfx/layers/d3d9/LayerManagerD3D9.cpp:266:22: error: call of overloaded 'AppendInt(HRESULT&)' is ambiguous
../../dist/include/nsTSubstring.h:415:12: note: candidates are: void nsACString_internal::AppendInt(PRUint64)                                             
../../dist/include/nsTSubstring.h:408:12: note:                 void nsACString_internal::AppendInt(PRInt64)                                              
../../dist/include/nsTSubstring.h:401:12: note:                 void nsACString_internal::AppendInt(PRUint32)                                             
../../dist/include/nsTSubstring.h:394:12: note:                 void nsACString_internal::AppendInt(PRInt32)

An explicit cast of HRESULT to PRUint32 fixes the problem.
(Assignee)

Updated

7 years ago
Attachment #485016 - Attachment is patch: true
Attachment #485016 - Flags: review?(bas.schouten)
(Assignee)

Updated

7 years ago
QA Contact: layout → jacek
Attachment #485016 - Flags: review?(bas.schouten) → review+
(Assignee)

Updated

7 years ago
Attachment #485016 - Flags: approval2.0?
Assignee: nobody → jacek
QA Contact: jacek → layout

Updated

7 years ago
Attachment #485016 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 1

7 years ago
http://hg.mozilla.org/mozilla-central/rev/18d274f80069
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.