606427 - Enhance UI for Search Engines

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[ahoza]

Attachment: No Search Engine Enabled screenshot

Device: Nokia N900
BuildID: Mozilla /5.0 (Maemo;Linux armv7l;rv:2.0b8pre)Gecko/20101021 Firefox/4.0b8pre Fennec /4.0b2pre 


Steps to reproduce:

Scenario 1:

1. Open Fennec.
2. Go to Options->Add-ons
3. Disable all search engines.
4. Tap awesome bar and then "Search Engine" icon

Expected results:
User should not be allowed to disable all default search engines or
"No enabled search engines" should be displayed while in Awesome bar-> magnifier glass icon (see screenshot) or
"Search engine" button is disabled when no seaarch engines are enabled


Scenario 2:

1. Open Fennec.
2. Install 2-3 extra search engines (go to: addons.mozilla.org/en-US/mobile/, bugzilla.mozilla.com, cnn.com tap the site's favicon and choose "Add Search Engine")
3. Tap awesome bar and then magnifier glass icon.
4. Observe associated icon for each search engine

Expected results:
The icons should have the same size.

Actual results:
Default search engines icons are bigger (see screenshot)
 
Scenario 3:

1. Open Fennec.
2. Install one extra add-on.
3. Go to Options->Add-ons and disable Wikipedia search engine
4. Tap awesome bar and then magnifier glass icon.

Expected results:
Display should look good.

Actual results:
Separators are not aligned. (see screenshot)

Comment 1

[ahoza]

Attachment: Icons

Comment 2

[ahoza]

Attachment: Separators

Comment 4

[Wesley Johnston (:wesj)]

Whoops. Wrong bug. Sorry :(

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I thought we fixed the icon sizing in bug 606205 and we disable the the search
button if no engines are installed in bug 606056?

Comment 6

[Wesley Johnston (:wesj)]

I think we do too. All three situations work for me now.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Sold!

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101025 Namoroka/4.0b8pre Fennec/4.0b2pre