606473 - Enable plugin hooks once WindowsDllInterceptor supports 64-bit

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jim Mathies [:jimm]]

http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/src/nsPluginNativeWindowWin.cpp#495

and

http://mxr.mozilla.org/mozilla-central/source/dom/plugins/PluginInstanceChild.cpp#1349

Comment 1

[Jim Mathies [:jimm]]

bah, sorry for the spam, that was the wrong bug #.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 4

[Benjamin Smedberg]

Since I'm backed up on reviews and other priorities all this win64 stuff which I think is pretty low priority may have to wait 4-6 weeks.

Comment 5

[Armen [:armenzg]]

Modifying blocking issues since this does not block work on the releng side but as to affect the product.

FTR this bug might start getting attention as we are aiming to release a Windows 64-bit version of Firefox sometime this year.

Comment 6

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4c1c8236bac9

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/4c1c8236bac9

Comment 8

[Armen [:armenzg]]

I have filed a make check test failures that I believe is related to the code in this bug.
Would you please be able to have a look? Thanks.

Bug 681238 - TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to add hook

Comment 9

[Makoto Kato [:m_kato]]

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #8)
> I have filed a make check test failures that I believe is related to the
> code in this bug.
> Would you please be able to have a look? Thanks.
> 
> Bug 681238 - TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to add
> hook

Get/SetWindowLongPtr hook works (I have checked it on debugger.)  Bug 681238 depends on hooked API.  GetVersionEx has complex MOV code on x64.