Closed Bug 606473 Opened 9 years ago Closed 8 years ago

Enable plugin hooks once WindowsDllInterceptor supports 64-bit

Categories

(Core :: Plug-ins, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: jimm, Assigned: m_kato)

References

Details

Attachments

(1 file)

Depends on: 604302
bah, sorry for the spam, that was the wrong bug #.
Blocks: support-win64
No longer blocks: tracking_win64
Attached patch fixSplinter Review
Assignee: nobody → m_kato
Status: NEW → ASSIGNED
Attachment #528062 - Attachment is patch: true
Attachment #528062 - Flags: review?(benjamin)
Duplicate of this bug: 654110
Since I'm backed up on reviews and other priorities all this win64 stuff which I think is pretty low priority may have to wait 4-6 weeks.
Modifying blocking issues since this does not block work on the releng side but as to affect the product.

FTR this bug might start getting attention as we are aiming to release a Windows 64-bit version of Firefox sometime this year.
Blocks: tracking_win64
No longer blocks: support-win64
Attachment #528062 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/4c1c8236bac9
Hardware: x86 → x86_64
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/4c1c8236bac9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
I have filed a make check test failures that I believe is related to the code in this bug.
Would you please be able to have a look? Thanks.

Bug 681238 - TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to add hook
(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #8)
> I have filed a make check test failures that I believe is related to the
> code in this bug.
> Would you please be able to have a look? Thanks.
> 
> Bug 681238 - TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to add
> hook

Get/SetWindowLongPtr hook works (I have checked it on debugger.)  Bug 681238 depends on hooked API.  GetVersionEx has complex MOV code on x64.
You need to log in before you can comment on or make changes to this bug.