Last Comment Bug 606473 - Enable plugin hooks once WindowsDllInterceptor supports 64-bit
: Enable plugin hooks once WindowsDllInterceptor supports 64-bit
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla8
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
: 654110 (view as bug list)
Depends on: 604302
Blocks: tracking_win64
  Show dependency treegraph
 
Reported: 2010-10-22 07:23 PDT by Jim Mathies [:jimm]
Modified: 2011-08-23 22:23 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.34 KB, patch)
2011-04-24 23:20 PDT, Makoto Kato [:m_kato]
benjamin: review+
Details | Diff | Review

Comment 1 Jim Mathies [:jimm] 2010-10-22 07:28:45 PDT
bah, sorry for the spam, that was the wrong bug #.
Comment 2 Makoto Kato [:m_kato] 2011-04-24 23:20:51 PDT
Created attachment 528062 [details] [diff] [review]
fix
Comment 3 Makoto Kato [:m_kato] 2011-05-02 08:05:22 PDT
*** Bug 654110 has been marked as a duplicate of this bug. ***
Comment 4 Benjamin Smedberg [:bsmedberg] 2011-05-02 08:52:15 PDT
Since I'm backed up on reviews and other priorities all this win64 stuff which I think is pretty low priority may have to wait 4-6 weeks.
Comment 5 Armen Zambrano [:armenzg] - Engineering productivity 2011-07-11 11:38:09 PDT
Modifying blocking issues since this does not block work on the releng side but as to affect the product.

FTR this bug might start getting attention as we are aiming to release a Windows 64-bit version of Firefox sometime this year.
Comment 7 :Ehsan Akhgari (busy, don't ask for review please) 2011-07-28 08:25:16 PDT
http://hg.mozilla.org/mozilla-central/rev/4c1c8236bac9
Comment 8 Armen Zambrano [:armenzg] - Engineering productivity 2011-08-23 06:19:25 PDT
I have filed a make check test failures that I believe is related to the code in this bug.
Would you please be able to have a look? Thanks.

Bug 681238 - TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to add hook
Comment 9 Makoto Kato [:m_kato] 2011-08-23 22:23:41 PDT
(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #8)
> I have filed a make check test failures that I believe is related to the
> code in this bug.
> Would you please be able to have a look? Thanks.
> 
> Bug 681238 - TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to add
> hook

Get/SetWindowLongPtr hook works (I have checked it on debugger.)  Bug 681238 depends on hooked API.  GetVersionEx has complex MOV code on x64.

Note You need to log in before you can comment on or make changes to this bug.