Windows DLL blocklist support for Windows x64

RESOLVED FIXED in Firefox 6

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
Firefox 6
x86_64
Windows Vista
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Bug 524904 is for x86 only.  To support blocklist support for x64, we need implement this.
(Assignee)

Comment 1

9 years ago
Posted patch WIP v0.1 (obsolete) — Splinter Review
- add detect mov instruction
Assignee: nobody → m_kato

Updated

9 years ago
Blocks: 606473
(Assignee)

Comment 2

9 years ago
Posted patch fix v1Splinter Review
It works on Vista.  After testing on Win7, I send a review
Attachment #484211 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Attachment #496783 - Flags: review?(vladimir)
Comment on attachment 496783 [details] [diff] [review]
fix v1

Hmm, looks fine; I didn't look into the instruction decode in detail, though.  Also, I assume that the assumption we're making is that the PULONG argument showed up on 64-bit systems, and that on 32-bit it doesn't matter?
Attachment #496783 - Flags: review?(vladimir) → review+
(Assignee)

Comment 4

9 years ago
(In reply to comment #3)
> Comment on attachment 496783 [details] [diff] [review]
> fix v1
> 
> Hmm, looks fine; I didn't look into the instruction decode in detail, though. 
> Also, I assume that the assumption we're making is that the PULONG argument
> showed up on 64-bit systems, and that on 32-bit it doesn't matter?

When disassembling LdrLoadDll on Win7, 2nd parameter uses as 64-bit (PULONG is 64-bit).  If using ULONG instead, flag comparing may be fail since upper 32bit is garbage.
(Assignee)

Comment 5

8 years ago
Posted patch fix v2Splinter Review
we should not use RAX becuase RAX is used by syscall, so injecting TrackPopupMenu doesn't work well.
(Assignee)

Updated

8 years ago
Attachment #513396 - Flags: review?(dtownsend)
Attachment #513396 - Flags: review?(dtownsend) → review?(vladimir)
(Assignee)

Updated

8 years ago
Blocks: 637123

Updated

8 years ago
No longer blocks: 637308
(Assignee)

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/c062731105cf
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
You need to log in before you can comment on or make changes to this bug.