Closed Bug 604302 Opened 16 years ago Closed 15 years ago

Windows DLL blocklist support for Windows x64

Categories

(Firefox :: General, defect)

x86_64
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 6

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 524904 is for x86 only. To support blocklist support for x64, we need implement this.
Attached patch WIP v0.1 (obsolete) — — Splinter Review
- add detect mov instruction
Assignee: nobody → m_kato
Blocks: 606473
Attached patch fix v1 — — Splinter Review
It works on Vista. After testing on Win7, I send a review
Attachment #484211 - Attachment is obsolete: true
Attachment #496783 - Flags: review?(vladimir)
Comment on attachment 496783 [details] [diff] [review] fix v1 Hmm, looks fine; I didn't look into the instruction decode in detail, though. Also, I assume that the assumption we're making is that the PULONG argument showed up on 64-bit systems, and that on 32-bit it doesn't matter?
Attachment #496783 - Flags: review?(vladimir) → review+
(In reply to comment #3) > Comment on attachment 496783 [details] [diff] [review] > fix v1 > > Hmm, looks fine; I didn't look into the instruction decode in detail, though. > Also, I assume that the assumption we're making is that the PULONG argument > showed up on 64-bit systems, and that on 32-bit it doesn't matter? When disassembling LdrLoadDll on Win7, 2nd parameter uses as 64-bit (PULONG is 64-bit). If using ULONG instead, flag comparing may be fail since upper 32bit is garbage.
Attached patch fix v2 — — Splinter Review
we should not use RAX becuase RAX is used by syscall, so injecting TrackPopupMenu doesn't work well.
Attachment #513396 - Flags: review?(dtownsend)
Attachment #513396 - Flags: review?(dtownsend) → review?(vladimir)
Blocks: 637123
No longer blocks: 637308
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: