606837 - Gray out Panorama background on inactive windows

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Current situation: ugly line and two grays

In Firefox proper, when the window is inactive, the entire chrome section, including toolbar, becomes a lighter gray. Perhaps the entire Panorama background should become a lighter gray as well, so as not to produce the ugly current situation (see attachment).

Assigning to Aza to confirm spec.

Comment 1

[Aza Raskin [:aza]]

Mitcho is exactly right. The background color of the screen plus the title bar's inactive color should be lighter and match.

Comment 2

[Kevin Hanes]

bugspam (moving b9 to b10)

Comment 3

[Kevin Hanes]

bugspam (removing b9)

Comment 4

[Kevin Hanes]

Punt

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Window states with patch v1

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 506125 [details]
Window states with patch v1

Hmm, was hoping to flag multiple people for ui-review?... no dice.

Comment 8

[Michael Yoshitaka Erlewine [:mitcho]]

Sent to try, just in case, and so people can check out the builds.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 506125 [details]
Window states with patch v1

looks good to me.  Stephen might have an opinion on the exact values used for the inactive state (perhaps it gets a little too dark at the bottom?)  Fixing the line is important though, so we should probably check this in immediately and make any tweaks in follow up bugs.

Comment 10

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #9)
> perhaps it gets a little too dark at the bottom?

Indeed, I tried to keep the same gradient differential, so it may be darkish at the bottom... maybe in inactive mode it should actually be "flat" and thus without a gradient at all? Or just a subtler one? Stephen?

Comment 11

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1.1

I made a little mistake so mac try failed spectacularly. Fixed and sending back to try. Design is same as v1.

Comment 12

[Michael Yoshitaka Erlewine [:mitcho]]

Passed try.

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 506229 [details] [diff] [review]
Patch v1.1

>--- a/browser/themes/pinstripe/browser/tabview/tabview.css
>+++ b/browser/themes/pinstripe/browser/tabview/tabview.css
>@@ -5,16 +5,20 @@ body {
>   font-size: 12px;
>   line-height: 16px;
> }
> 
> #bg {
>   background: -moz-linear-gradient(top,#C4C4C4,#9E9E9E);
> }
> 
>+#bg.unfocused {

Use :-moz-window-inactive

>+  background: -moz-linear-gradient(top,#E1E1E1,#BBBBBB);

"top," is redundant

Comment 14

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1.2

(In reply to comment #13)
> Use :-moz-window-inactive

Ah, thanks Dāo! That can lighten this patch a bit, too.

Comment 15

[Stephen Horlander [:shorlander]]

Comment on attachment 506125 [details]
Window states with patch v1

This looks good.

It does seem a little dark. The native values for the inactive window gradient would be rgb(237,237,237) to rgb(216,216,216) this is also a bit flatter.

I am also not sure about keeping the dark search overlay for the inactive window. It seems too close to the actual active colors when you would expect a lighter window in the background.

It would be best to use the same values for the background and lighten the overlay and probably the search box. I will attach a screenshot of what I had in mind.

Comment 16

[Stephen Horlander [:shorlander]]

Attachment: Panorama inactive window with search

Comment 17

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #16)
> Created attachment 506415 [details]
> Panorama inactive window with search

Thanks Stephen!

I used those new values. What do you think?

Inactive: https://skitch.com/mitcho/rk7b8/minefield-group-your-tabs
Inactive search: https://skitch.com/mitcho/rk7bn/minefield-group-your-tabs

Comment 18

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1.3, with inactive values from Stephen

Stephen, you can ui-review based on those skitch links I posted (sorry, a little short on time right now).

Comment 19

[Stephen Horlander [:shorlander]]

(In reply to comment #17)
> (In reply to comment #16)
> > Created attachment 506415 [details]
> > Panorama inactive window with search
> 
> Thanks Stephen!
> 
> I used those new values. What do you think?
> 
> Inactive: https://skitch.com/mitcho/rk7b8/minefield-group-your-tabs
> Inactive search: https://skitch.com/mitcho/rk7bn/minefield-group-your-tabs

Looks good! -moz-mac-chrome-inactive should give the same(or close) values instead of hardcoding.

Comment 20

[Stephen Horlander [:shorlander]]

(In reply to comment #19)
> (In reply to comment #17)
> > (In reply to comment #16)
> > > Created attachment 506415 [details]
> > > Panorama inactive window with search
> > 
> > Thanks Stephen!
> > 
> > I used those new values. What do you think?
> > 
> > Inactive: https://skitch.com/mitcho/rk7b8/minefield-group-your-tabs
> > Inactive search: https://skitch.com/mitcho/rk7bn/minefield-group-your-tabs
> 
> Looks good! -moz-mac-chrome-inactive should give the same(or close) values
> instead of hardcoding.

Actually, that is wrong :) Ignore that.

Comment 21

[Ian Gilman [:iangilman]]

Comment on attachment 506436 [details] [diff] [review]
Patch v1.3, with inactive values from Stephen

>+#searchbox:-moz-window-inactive {
>+	background-color: #BBBBBB;

You and your tab characters!

r+ with that addressed

Comment 22

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 506436 [details] [diff] [review]
Patch v1.3, with inactive values from Stephen

Bugzilla attachment.cgi temporarily down. Requesting approval in the mean time...

Comment 23

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 506436 [details] [diff] [review]
Patch v1.3, with inactive values from Stephen

a=beltzner

Comment 24

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Comment 25

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/8af189735840

Comment 26

[Tracy Walker [:tracy]]

verified with nightly build of minefield.