Gray out Panorama background on inactive windows

VERIFIED FIXED in Firefox 4.0b11

Status

defect
P3
normal
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: mitcho, Assigned: mitcho)

Tracking

unspecified
Firefox 4.0b11
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][visual][Mac])

Attachments

(4 attachments, 4 obsolete attachments)

In Firefox proper, when the window is inactive, the entire chrome section, including toolbar, becomes a lighter gray. Perhaps the entire Panorama background should become a lighter gray as well, so as not to produce the ugly current situation (see attachment).

Assigning to Aza to confirm spec.

Comment 1

9 years ago
Mitcho is exactly right. The background color of the screen plus the title bar's inactive color should be lighter and match.
Blocks: 598154
Priority: P4 → P3
Target Milestone: --- → Firefox 4.0

Updated

9 years ago
Assignee: aza → ian
Assignee: ian → nobody

Comment 2

9 years ago
bugspam (moving b9 to b10)
Blocks: 608028

Comment 3

9 years ago
bugspam (removing b9)
No longer blocks: 598154

Comment 4

9 years ago
Punt
No longer blocks: 608028
Target Milestone: Firefox 4.0 → Future
Assignee: nobody → mitcho
Blocks: 627096
Target Milestone: Future → ---
Posted patch Patch v1 (obsolete) — Splinter Review
Attachment #506124 - Flags: review?(ian)
Attachment #506125 - Flags: ui-review?(faaborg)
Comment on attachment 506125 [details]
Window states with patch v1

Hmm, was hoping to flag multiple people for ui-review?... no dice.
Attachment #506125 - Flags: feedback?(shorlander)
Status: NEW → ASSIGNED
Sent to try, just in case, and so people can check out the builds.
Comment on attachment 506125 [details]
Window states with patch v1

looks good to me.  Stephen might have an opinion on the exact values used for the inactive state (perhaps it gets a little too dark at the bottom?)  Fixing the line is important though, so we should probably check this in immediately and make any tweaks in follow up bugs.
Attachment #506125 - Flags: ui-review?(faaborg) → ui-review+
(In reply to comment #9)
> perhaps it gets a little too dark at the bottom?

Indeed, I tried to keep the same gradient differential, so it may be darkish at the bottom... maybe in inactive mode it should actually be "flat" and thus without a gradient at all? Or just a subtler one? Stephen?
Posted patch Patch v1.1 (obsolete) — Splinter Review
I made a little mistake so mac try failed spectacularly. Fixed and sending back to try. Design is same as v1.
Attachment #506124 - Attachment is obsolete: true
Attachment #506229 - Flags: review?(ian)
Attachment #506124 - Flags: review?(ian)
Passed try.
Comment on attachment 506229 [details] [diff] [review]
Patch v1.1

>--- a/browser/themes/pinstripe/browser/tabview/tabview.css
>+++ b/browser/themes/pinstripe/browser/tabview/tabview.css
>@@ -5,16 +5,20 @@ body {
>   font-size: 12px;
>   line-height: 16px;
> }
> 
> #bg {
>   background: -moz-linear-gradient(top,#C4C4C4,#9E9E9E);
> }
> 
>+#bg.unfocused {

Use :-moz-window-inactive

>+  background: -moz-linear-gradient(top,#E1E1E1,#BBBBBB);

"top," is redundant
Attachment #506229 - Flags: review-
Attachment #506229 - Flags: review?(ian)
Posted patch Patch v1.2 (obsolete) — Splinter Review
(In reply to comment #13)
> Use :-moz-window-inactive

Ah, thanks Dāo! That can lighten this patch a bit, too.
Attachment #506229 - Attachment is obsolete: true
Attachment #506395 - Flags: review?(ian)
Comment on attachment 506125 [details]
Window states with patch v1

This looks good.

It does seem a little dark. The native values for the inactive window gradient would be rgb(237,237,237) to rgb(216,216,216) this is also a bit flatter.

I am also not sure about keeping the dark search overlay for the inactive window. It seems too close to the actual active colors when you would expect a lighter window in the background.

It would be best to use the same values for the background and lighten the overlay and probably the search box. I will attach a screenshot of what I had in mind.
Attachment #506125 - Flags: feedback?(shorlander) → feedback+
(In reply to comment #16)
> Created attachment 506415 [details]
> Panorama inactive window with search

Thanks Stephen!

I used those new values. What do you think?

Inactive: https://skitch.com/mitcho/rk7b8/minefield-group-your-tabs
Inactive search: https://skitch.com/mitcho/rk7bn/minefield-group-your-tabs
Stephen, you can ui-review based on those skitch links I posted (sorry, a little short on time right now).
Attachment #506395 - Attachment is obsolete: true
Attachment #506436 - Flags: ui-review?(shorlander)
Attachment #506436 - Flags: review?(ian)
Attachment #506395 - Flags: review?(ian)
(In reply to comment #17)
> (In reply to comment #16)
> > Created attachment 506415 [details]
> > Panorama inactive window with search
> 
> Thanks Stephen!
> 
> I used those new values. What do you think?
> 
> Inactive: https://skitch.com/mitcho/rk7b8/minefield-group-your-tabs
> Inactive search: https://skitch.com/mitcho/rk7bn/minefield-group-your-tabs

Looks good! -moz-mac-chrome-inactive should give the same(or close) values instead of hardcoding.
(In reply to comment #19)
> (In reply to comment #17)
> > (In reply to comment #16)
> > > Created attachment 506415 [details]
> > > Panorama inactive window with search
> > 
> > Thanks Stephen!
> > 
> > I used those new values. What do you think?
> > 
> > Inactive: https://skitch.com/mitcho/rk7b8/minefield-group-your-tabs
> > Inactive search: https://skitch.com/mitcho/rk7bn/minefield-group-your-tabs
> 
> Looks good! -moz-mac-chrome-inactive should give the same(or close) values
> instead of hardcoding.

Actually, that is wrong :) Ignore that.
Comment on attachment 506436 [details] [diff] [review]
Patch v1.3, with inactive values from Stephen

>+#searchbox:-moz-window-inactive {
>+	background-color: #BBBBBB;

You and your tab characters!

r+ with that addressed
Attachment #506436 - Flags: review?(ian) → review+
Comment on attachment 506436 [details] [diff] [review]
Patch v1.3, with inactive values from Stephen

Bugzilla attachment.cgi temporarily down. Requesting approval in the mean time...
Attachment #506436 - Flags: approval2.0?
Comment on attachment 506436 [details] [diff] [review]
Patch v1.3, with inactive values from Stephen

a=beltzner
Attachment #506436 - Flags: approval2.0? → approval2.0+
Attachment #506436 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/8af189735840
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b11
verified with nightly build of minefield.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.