Closed
Bug 606859
Opened 15 years ago
Closed 15 years ago
Unable to add Sherlock search plugin
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
VERIFIED
FIXED
Firefox 4.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta8+ |
People
(Reporter: mail, Assigned: Gavin)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
|
8.67 KB,
patch
|
Details | Diff | Splinter Review |
Am unable to add any Sherlock search plugins recently - haven't checked with builds before and after but bug 599751 seems like the obvious candidate esp. as the error is:
_onLoad: Failed to init engine!
ReferenceError: valueEnd is not defined
Linked url gives example to try.
|
Assignee | |
Comment 1•15 years ago
|
||
Ineed, valueEnd is used outside the block where it is declared - let makes that an error.
Blocks: 599751
blocking2.0: --- → beta8+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Assignee: nobody → gavin.sharp
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
|
|
Assignee | |
Comment 3•15 years ago
|
||
|
||
Comment 4•15 years ago
|
||
This bug was caused by not applying some of the whitespace changes :-(
To be specific, Serge had outdented the block in question (which was an else after return, so should never have been indented in the first place) which would have meant that let would have worked.
|
|
Assignee | |
Comment 5•15 years ago
|
||
Flags: in-testsuite+
|
Reporter | |
Comment 6•15 years ago
|
||
Confirm now works as expected again.
|
|
Assignee | |
Comment 7•15 years ago
|
||
Thanks for catching this, Charles.
|
||
Updated•15 years ago
|
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•