We don't register Thunderbird as the default .eml handler on linux

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
OS Integration
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Usul, Assigned: hiro)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
Thunderbird 13.0
All
Linux
Dependency tree / graph
Bug Flags:
wanted-thunderbird +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
STR :

1) install TB - make Tb the default client
2) create an account
3) Save an email from the account
4) close TB
5) double click on saved email

Mail.app starts :(
Flags: wanted-thunderbird+
Keywords: helpwanted
you mean bug 300393 ?
(Reporter)

Updated

7 years ago
Duplicate of this bug: 300393
(Reporter)

Comment 3

7 years ago
(In reply to comment #1)
> you mean bug 300393 ?

Yes and I missed it when I searched.
Duplicate of this bug: 693092
(Reporter)

Updated

6 years ago
Depends on: 309708
(Assignee)

Comment 5

5 years ago
Created attachment 595325 [details] [diff] [review]
Fix for Linux

This is only effective with --enable-gio option.
Attachment #595325 - Flags: review?(mbanner)
Comment on attachment 595325 [details] [diff] [review]
Fix for Linux

Errm, note that this bug was about mac and not linux.
Attachment #595325 - Flags: review?(mbanner) → review?(mconley)
Hey Chris,

I feel like this is more your domain than mine.  How does everything look here, GIO-wise?

-Mike
(Assignee)

Comment 8

5 years ago
(In reply to Mark Banner (:standard8) from comment #6)
> Comment on attachment 595325 [details] [diff] [review]
> Fix for Linux
> 
> Errm, note that this bug was about mac and not linux.

The bug for linux (and Mac), bug 300393, had been duplicated this bug..
Comment on attachment 595325 [details] [diff] [review]
Fix for Linux

Review of attachment 595325 [details] [diff] [review]:
-----------------------------------------------------------------

Just one nit - but other than that, this looks really good to me.  Thanks Hiro.

::: mail/components/shell/nsMailGNOMEIntegration.cpp
@@ +158,5 @@
>    *aIsDefaultClient = true;
> +
> +  for (unsigned int i = 0; i < NS_ARRAY_LENGTH(sAppTypes); i++) {
> +    if (aApps & sAppTypes[i].type)
> +      *aIsDefaultClient &= checkDefault(sAppTypes[i].protocols, NS_ARRAY_LENGTH(sAppTypes[i].protocols));

I like how you've reduced the repetitive if statements we had before.  Can you break this up into two lines?
Attachment #595325 - Flags: review?(mconley) → review+
(Assignee)

Comment 10

5 years ago
Created attachment 596928 [details] [diff] [review]
Revised patch

Carrying over review+.
Assignee: nobody → hiikezoe
Attachment #595325 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #596928 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Blocks: 726969
Checked in: http://hg.mozilla.org/comm-central/rev/7150237ed78f

Branched out Mac to bug 726969 so we can track that separately.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed, helpwanted
Resolution: --- → FIXED
Summary: We don't register Thunderbird as the default .eml handler → We don't register Thunderbird as the default .eml handler on linux
Target Milestone: --- → Thunderbird 13.0

Updated

5 years ago
OS: Mac OS X → Linux
Hardware: x86 → All
You need to log in before you can comment on or make changes to this bug.