606934 - We don't register Thunderbird as the default .eml handler on linux

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Ludovic Hirlimann [:Usul]]

STR :

1) install TB - make Tb the default client
2) create an account
3) Save an email from the account
4) close TB
5) double click on saved email

Mail.app starts :(

Comment 1

[Matthias Versen [:Matti]]

you mean bug 300393 ?

Comment 3

[Ludovic Hirlimann [:Usul]]

(In reply to comment #1)
> you mean bug 300393 ?

Yes and I missed it when I searched.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix for Linux

This is only effective with --enable-gio option.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 595325 [details] [diff] [review]
Fix for Linux

Errm, note that this bug was about mac and not linux.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hey Chris,

I feel like this is more your domain than mine.  How does everything look here, GIO-wise?

-Mike

Comment 8

[Hiroyuki Ikezoe (:hiro)]

(In reply to Mark Banner (:standard8) from comment #6)
> Comment on attachment 595325 [details] [diff] [review]
> Fix for Linux
> 
> Errm, note that this bug was about mac and not linux.

The bug for linux (and Mac), bug 300393, had been duplicated this bug..

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 595325 [details] [diff] [review]
Fix for Linux

Review of attachment 595325 [details] [diff] [review]:
-----------------------------------------------------------------

Just one nit - but other than that, this looks really good to me.  Thanks Hiro.

::: mail/components/shell/nsMailGNOMEIntegration.cpp
@@ +158,5 @@
>    *aIsDefaultClient = true;
> +
> +  for (unsigned int i = 0; i < NS_ARRAY_LENGTH(sAppTypes); i++) {
> +    if (aApps & sAppTypes[i].type)
> +      *aIsDefaultClient &= checkDefault(sAppTypes[i].protocols, NS_ARRAY_LENGTH(sAppTypes[i].protocols));

I like how you've reduced the repetitive if statements we had before.  Can you break this up into two lines?

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Attachment: Revised patch

Carrying over review+.

Comment 11

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/7150237ed78f

Branched out Mac to bug 726969 so we can track that separately.