Closed Bug 607108 Opened 12 years ago Closed 12 years ago

focus group name field after creating new group

Categories

(Firefox Graveyard :: Panorama, defect, P4)

defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 7

People

(Reporter: luis, Assigned: ttaubert)

References

Details

Attachments

(1 file, 2 obsolete files)

When I create a 'new folder' in finder or other file managers, the folder name field is immediately focused so that I can type the new folder's name. 

I have the same expectation when creating a new group, but instead I get search.

Current behavior:
1) click and drag to create new tab group
2) type 'foo' to name the group, hit enter
3) get told there are no search results for foo.

Expected behavior:
1) click and drag to create new tab group
2) type 'foo' to name the group, hit enter
3) the group is now named 'foo'

Would be nice for this to Just Work. :)
That certainly seems like the sort of behavior we want! Adding it to the b9 (fit n' finish beta) list so we can discuss it more when we get there.
Blocks: 598154
Priority: -- → P4
bugspam (moving b9 to b10)
Blocks: 608028
bugspam (removing b9)
No longer blocks: 598154
Punting
No longer blocks: 608028
Target Milestone: --- → Future
Assignee: nobody → tim.taubert
Blocks: 660175
Status: NEW → ASSIGNED
Hardware: x86 → All
Target Milestone: Future → ---
Attached patch patch v1 (obsolete) — Splinter Review
@Alex: the patch focuses the title input field when using mouse drag to create a new tab group. Shall we also focus the input field when creating a group via dragging a tabItem onto an orphan tab? Without the orphan tab concept we would immediately create a new group when dragging a tab out of its group.

I don't feel like it's the right thing to focus the input field when not explicitly creating a new group but it's up to you :)
Attachment #537601 - Flags: feedback?(raymond)
Comment on attachment 537601 [details] [diff] [review]
patch v1

+  if (options.focusTitle)
+    this.focusTitle();
+

Nit: Please add a comment about options.focusTitle to the method input variable options.
Attachment #537601 - Flags: feedback?(raymond) → feedback+
Attached patch patch v2 (obsolete) — Splinter Review
Attachment #537601 - Attachment is obsolete: true
Attachment #537755 - Flags: review?(ehsan)
Attachment #537755 - Flags: review?(ehsan) → review+
Backed out due to mochitest-other orange.
Whiteboard: [inbound]
Attached patch patch v3Splinter Review
Extended patch (and test) to auto-focus the title field when creating a new group by dragging a tab onto an orphan tab (as requested by Limi).
Attachment #537755 - Attachment is obsolete: true
Attachment #538527 - Flags: review?(ehsan)
Do we know what was wrong with the original patch which caused this to be backed out?
(In reply to comment #12)
> Do we know what was wrong with the original patch which caused this to be
> backed out?

I relanded all other patches except bug 633190 - that was actually causing this intermittent orange. So this patch should be safe.
Attachment #538527 - Flags: review?(ehsan) → review+
http://hg.mozilla.org/mozilla-central/rev/d58376753a93
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110615 Firefox/7.0a1

Verified issue on Ubuntu 11.04 x86, Mac OS X 10.6, Win 7 x86, WinXP using the steps from the Description.

Issue no longer present - changing status to Verified.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.