607227 - Hide menu Bookmarks > "Bookmark all Tabs" unless the user invokes the menu using the keyboard

Status: RESOLVED DUPLICATE of bug 588011

(Firefox :: Menus, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug is to remove the command Bookmarks > Bookmark All Tabs from the traditional menu bar.  This command is still available on the context menu of the tab strip.

The rationale is that this command had extremely low usage in our usability metrics coming from test pilot, especially relative to the surrounding very high usage menu items.  Additionally this command increases the number of commands that we have listed before the user can start viewing their actual bookmarks, which is the overall purpose of the bookmarks menu.

Comment 1

[Jesse Ruderman]

I think "context menu of the tab bar" is an awkward and undiscoverable location for this feature.

Comment 2

[u88484]

I can take this if the decision has been finalized to remove this.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Note, for performance reasons I have a patch implementing this in Bug 588011.

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

The UX team is very eager to get this bug landed over the next few days in order to make Beta 11.  If anyone can get a patch for this bug posted soon, we will push hard for reviews and approval (even though this isn't blocking).

You can view all of the related bugs to clean up the traditional menu bar here: http://areweprettyyet.com/4/traditionalMenu/

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

taking based on comment 3

Comment 6

[Verdi [:verdi] Best to slack me]

FWIW, "Bookmark all Tabs" is a tip I published in our mainstream newsletter. It's great for when you are researching a topic.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

>It's great for when you are researching a topic.

yeah, and those users are going to love tab multi-select (bug 566510) and panorama.  I'm all for people doing aggregate bookmarking, I just want it to be more direct manipulation (or at least context menu).

Comment 8

[Brian Carpenter [:geeknik]]

Bug #611568 has patch that removes "Bookmark all Tabs" from the bookmarks menu.

Comment 9

[Brian Carpenter [:geeknik]]

Disregard comment #8, I will let Marco handle this one unless he wants me to knock it out of the park real quick. =)

Comment 10

[Brian Carpenter [:geeknik]]

Attachment: Removes Bookmark All Tabs from the browser menu

Uploaded this patch per limi in #developers.

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 506662 [details] [diff] [review]
Removes Bookmark All Tabs from the browser menu

sorry but the string is still used in the tabs context menu, as well as the command, plus this is not the way we intend to remove this menuitem (as others items we are removing it should still appear for keyboard access, like the ones in Bug 626825)

Comment 12

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

fixed in bug 588011

Comment 13

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

To clarify the behavior, mouse interactions won't see the entry in the menu, while keyboard interactions will see it (to expose the keyboard shortcut).

The removal is based on the functionality implemented in bug 607224.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This bug has been marked for all platforms. But with todays nighlty build on OS X the menu entry is still visible.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Asking for blocking now that it hasn't been fixed by bug 588011.

Comment 16

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to comment #14)
> This bug has been marked for all platforms. But with todays nighlty build on OS
> X the menu entry is still visible.

that's the wanted behavior, bug 607224 doesn't work on Mac.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks for the clarification Marco. Marking as verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b11pre) Gecko/20110201 Firefox/4.0b11pre

Litmus test has been updated:
https://litmus.mozilla.org/show_test.cgi?id=10033

Comment 18

[Steffen Wilberg]

Adjusting summary to the fix (to correct awpy), and duping to bug 588011 where it happened.