Closed
Bug 607234
Opened 14 years ago
Closed 13 years ago
Remove "Release Notes" from the Help menu
Categories
(Firefox :: Menus, defect)
Firefox
Menus
Tracking
()
VERIFIED
FIXED
Firefox 4.0b11
People
(Reporter: faaborg, Assigned: geeknik)
References
(Blocks 2 open bugs, )
Details
(Whiteboard: [target-betaN])
Attachments
(1 file, 2 obsolete files)
3.32 KB,
patch
|
Dolske
:
review+
Dolske
:
approval2.0+
|
Details | Diff | Splinter Review |
This bug is to remove the "Release Notes" item in the Help menu on all platforms. The rationale is that this menu had extremely low usage in our usability metrics coming in through Test Pilot. The original plan was to relocate this command to the Home tab, however since that isn't landing for Firefox 4, we could consider making the current version in the about window a hyperlink to the release notes. It is also worth considering that users may be more likely to google the Firefox release notes for their version than attempt to find a UI path in the product itself.
Comment 1•14 years ago
|
||
The link already got removed from the website, so removing it from the browser is going to leave the release notes link-less... Not sure that's such a good idea.
Reporter | ||
Comment 2•14 years ago
|
||
Find a new home in the About window (by hyperlinking the current version number) would work. Either way release notes has already been removed for Windows 7 users, this bug is just catching the other platforms up (and perhaps at the same time bringing the functionality back to windows 7 users through a different path).
Comment 3•14 years ago
|
||
I agree, the About window seems like the right place for the release notes, since it's related to what version you're running.
Whiteboard: [target-betaN]
Comment 4•14 years ago
|
||
This seems to have been already done, as there's no release notes link under "Help" anymore, at least on Linux. Now we have no links whatsoever to the release notes, neither on the website or in the app.
Reporter | ||
Comment 5•14 years ago
|
||
Sorry about that, filed the follow up bug 622289
Comment 6•14 years ago
|
||
(In reply to comment #4) > This seems to have been already done, as there's no release notes link under > "Help" anymore, at least on Linux. Now we have no links whatsoever to the > release notes, neither on the website or in the app. Are you talking about the app menu? It should still be there in the main menubar (http://mxr.mozilla.org/mozilla-central/source/browser/base/content/baseMenuOverlay.xul#101).
Reporter | ||
Comment 7•13 years ago
|
||
The UX team is very eager to get this bug landed over the next few days in order to make Beta 11. If anyone can get a patch for this bug posted soon, we will push hard for reviews and approval (even though this isn't blocking). You can view all of the related bugs to clean up the traditional menu bar here: http://areweprettyyet.com/4/traditionalMenu/
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → brian.carpenter
Assignee | ||
Comment 8•13 years ago
|
||
Attachment #506659 -
Flags: review?(dolske)
Comment 9•13 years ago
|
||
Comment on attachment 506659 [details] [diff] [review] Removes Release Notes from Help Menu You'll need to remove openReleaseNotes() from browser/base/content/utilityOverlay.js.
Assignee | ||
Comment 10•13 years ago
|
||
Same patch as before, just removed openReleaseNotes() from browser/base/content/utilityOverlay.js.
Attachment #506669 -
Flags: review?(dolske)
Updated•13 years ago
|
Attachment #506659 -
Attachment is obsolete: true
Attachment #506659 -
Flags: review?(dolske)
Comment 11•13 years ago
|
||
Comment on attachment 506669 [details] [diff] [review] Updated Patch >- var formatter = Components.classes["@mozilla.org/toolkit/URLFormatterService$ >- .getService(Components.interfaces.nsIURLFormatter); The $ makes me think you copied this from a terminal into a file. Probably need to attach an actual patch.
Assignee | ||
Comment 12•13 years ago
|
||
Didn't notice the copy/paste goof. This is a valid patch now.
Attachment #506669 -
Attachment is obsolete: true
Attachment #506670 -
Flags: review?(dolske)
Attachment #506669 -
Flags: review?(dolske)
Updated•13 years ago
|
Flags: in-litmus?
Comment 13•13 years ago
|
||
Comment on attachment 506670 [details] [diff] [review] Attempt #3 We could probably also remove pref("app.releaseNotesURL", ...) from the 3 (!) firefox-branding.js pref files, along with the one remaining spot this pref is used (/toolkit/content/about.xhtml)... But probably not worth it this close to a release, and I do see some addons referring to the pref.
Attachment #506670 -
Flags: review?(dolske)
Attachment #506670 -
Flags: review+
Attachment #506670 -
Flags: approval2.0+
Updated•13 years ago
|
Keywords: checkin-needed
Comment 14•13 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/332b2da9de82 In future please use 'hg export' for your patch if you're going to use checkin-needed.
Keywords: checkin-needed
Assignee | ||
Comment 15•13 years ago
|
||
Nobody told me about that command, but I will remember it for the next time. Thanks!
Comment 16•13 years ago
|
||
Thanks Brian, that would be very helpful. Does this bug need to be closed now?
Assignee | ||
Comment 17•13 years ago
|
||
Per comment #13, I believe it can be marked as resolved. If we need to revisit it after the 4.0 release, we can.
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Flags: in-testsuite-
Target Milestone: --- → Firefox 4.0b11
Version: unspecified → Trunk
Comment 18•13 years ago
|
||
Verified fixes with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11pre) Gecko/20110131 Firefox/4.0b11pre ID:20110131064734 The menu entry has been removed from the litmus test: https://litmus.mozilla.org/show_test.cgi?id=10031
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•