607517 - land buildbotcustom changes for talos to be able to install release builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[alice nodelman [:alice] [:anode]]

buildbotcustom patch in bug 599162.

Will require reconfigs of all talos masters.

Staged green.  Low risk as will be inactive code until other patches start using the code in question.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #1)
> buildbotcustom patch in bug 599162.
> 
> Will require reconfigs of all talos masters.
> 
> Staged green.  Low risk as will be inactive code until other patches start
> using the code in question.

Unclear from this comment, and the flags. Are you saying that a reconfig is enough? Or do you also want this done in a downtime?

Comment 2

[alice nodelman [:alice] [:anode]]

I marked both needs-treeclosure and needs-downtime as I figured that we should be careful.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

Alice, there is no needs-downtime flag.  You set the needs-reconfig flag as well as treeclosure, which could lead to this landing as part of a non-downtime reconfig.  I have cleared that flag for safety.

Comment 4

[alice nodelman [:alice] [:anode]]

If there was a doc explaining this process it would be easier to get the right settings.

Comment 5

[alice nodelman [:alice] [:anode]]

Any idea when this could be landed?

Comment 6

[Armen [:armenzg]]

Let's aim for Friday.

Patch in attachment 482735 [details] [diff] [review] is not risky and only a reconfigure is needed (I don't know why it would need a CLOSED tree - let me know if I misunderstand it).

alice is this patch wanted only for "default" or for 0.7.x as well?

Comment 7

[alice nodelman [:alice] [:anode]]

Whatever is production is where this needs to be landed, I'm unsure if that means 'default' or some other branch... so, probably land everywhere?

Comment 8

[Armen [:armenzg]]

0.7.x is used for releases only (at least for just a little longer).

I will land it both places.

Comment 9

[Armen [:armenzg]]

The patch was quite bitrotten.

Could you please attach new patches please?
You can carry forward the r+ and we can land it without needing a treeclosure but only a reconfig.

Comment 10

[alice nodelman [:alice] [:anode]]

Posted updated patch.

Comment 11

[alice nodelman [:alice] [:anode]]

Can this get in on the next downtime?

Comment 12

[Armen [:armenzg]]

No need for a downtime. A reconfigure should do.

This is the patch:
> https://bugzilla.mozilla.org/attachment.cgi?id=490177

Comment 13

[alice nodelman [:alice] [:anode]]

This doesn't require a downtime and has been sitting for a long time - can I request that this be landed before it becomes bitrotted again?

Comment 14

[Chris AtLee [:catlee]]

It will get landed tomorrow morning.

Comment 15

[[e-mail] (:bhearsum)]

Done.

Comment 16

[alice nodelman [:alice] [:anode]]

Thanks releng!