Closed Bug 607518 Opened 13 years ago Closed 13 years ago

After performed Paste & Go and Paste & Search , Ctrl+Z makes blank, Ctrl+Z is necessary twice to undo it

Categories

(Firefox :: Address Bar, defect)

Product:
Firefox
Component:
Address Bar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- -

People

(Reporter: alice0775, Assigned: fryn)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
2.45 KB, patch
Gavin
: review+
Gavin
: approval2.0+
Details | Diff | Splinter Review 
After landing Bug 599793.
Ctrl+Z is necessary twice to undo it.

First Ctrl+Z makes blank.
Second Ctrl+Z get previous value.

I think that first Ctrl+Z should get previous value.

Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Open any page
3. Copy URL( or text) string to clipboard
4. Paste & Go( or Paste & Search)
5. Try to undo (Ctrl+Z or right-click > Undo)

Actual Results:
 Blank.

Expected Results:
 Should be previous value.
blocking2.0: --- → ?
Sorry invalid
No longer blocks: 599793
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
Blocks: 599793
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
(In reply to comment #1)
> Sorry invalid

You mean this should be marked INVALID?
I don't think it's invalid. Seems like perhaps we should be using selectAll() rather than .value="".
Right, I just thought of that too.
Assignee: nobody → fryn
Status: REOPENED → ASSIGNED
Target Milestone: Firefox 4.0 → ---
Sorry spam .
This is valid bug.
Reopened
Assignee: fryn → nobody
Status: ASSIGNED → REOPENED
Target Milestone: --- → Firefox 4.0
Attached patch patch — — Splinter Review 
Assignee: nobody → fryn
Status: REOPENED → ASSIGNED

        Attachment #486237 -
        Flags: review?(gavin.sharp)

    
  
Target Milestone: Firefox 4.0 → ---

    
    

    
  
Comment on attachment 486237 [details] [diff] [review]
patch

Had to look up bug 473368 comment 3 to make sure we were using the right one again :)

        Attachment #486237 -
        Flags: review?(gavin.sharp) → review+
blocking2.0: ? → -

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/a75778b8f736
Status: ASSIGNED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.