607518 - After performed Paste & Go and Paste & Search , Ctrl+Z makes blank, Ctrl+Z is necessary twice to undo it

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Alice0775 White]

After landing Bug 599793.
Ctrl+Z is necessary twice to undo it.

First Ctrl+Z makes blank.
Second Ctrl+Z get previous value.

I think that first Ctrl+Z should get previous value.

Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Open any page
3. Copy URL( or text) string to clipboard
4. Paste & Go( or Paste & Search)
5. Try to undo (Ctrl+Z or right-click > Undo)

Actual Results:
 Blank.

Expected Results:
 Should be previous value.

Comment 1

[Alice0775 White]

Sorry invalid

Comment 2

[Frank Yan (:fryn)]

(In reply to comment #1)
> Sorry invalid

You mean this should be marked INVALID?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I don't think it's invalid. Seems like perhaps we should be using selectAll() rather than .value="".

Comment 4

[Frank Yan (:fryn)]

Right, I just thought of that too.

Comment 5

[Alice0775 White]

Sorry spam .
This is valid bug.
Reopened

Comment 6

[Frank Yan (:fryn)]

Attachment: patch

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 486237 [details] [diff] [review]
patch

Had to look up bug 473368 comment 3 to make sure we were using the right one again :)

Comment 8

[Frank Yan (:fryn)]

http://hg.mozilla.org/mozilla-central/rev/a75778b8f736