Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove DDRAW junk from configure, missed part

RESOLVED FIXED in mozilla6

Status

()

Core
Build Config
--
trivial
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({regression})

Trunk
mozilla6
x86
Windows Server 2003
regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(status2.0 wontfix)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Moving patch to here, per bug 600714 comment 7.
Flags: in-testsuite-
(Assignee)

Comment 1

7 years ago
Created attachment 486266 [details] [diff] [review]
(Av1) Missed cleanup, s/if/case/
Attachment #486266 - Flags: review?(gavin.sharp)
Comment on attachment 486266 [details] [diff] [review]
(Av1) Missed cleanup, s/if/case/

I'm not the right person to review this - sorry, I should have mentioned that in the other bug.
Attachment #486266 - Flags: review?(gavin.sharp)
(Assignee)

Updated

7 years ago
Attachment #486266 - Flags: review?(vladimir)
(Assignee)

Comment 3

7 years ago
vladimir, ping for review.
(Assignee)

Updated

7 years ago
Attachment #486266 - Flags: review?(ted.mielczarek)
Attachment #486266 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

7 years ago
Comment on attachment 486266 [details] [diff] [review]
(Av1) Missed cleanup, s/if/case/

"approval2.0=?":
Remove dead configure code. No risk.
Attachment #486266 - Flags: review?(vladimir) → approval2.0?
Attachment #486266 - Flags: approval2.0? → approval2.0-
(Assignee)

Comment 5

6 years ago
Created attachment 526523 [details] [diff] [review]
(Av1a) Missed cleanup, s/if/case/
[Checked in: Comment 6]

Av1, unbitrotted.

Succeeded as
http://tbpl.mozilla.org/?tree=MozillaTry&rev=7698a175084a
Attachment #486266 - Attachment is obsolete: true
Attachment #526523 - Flags: review+
(Assignee)

Updated

6 years ago
status2.0: --- → wontfix
Keywords: checkin-needed
Target Milestone: --- → mozilla6
(Assignee)

Comment 6

6 years ago
Comment on attachment 526523 [details] [diff] [review]
(Av1a) Missed cleanup, s/if/case/
[Checked in: Comment 6]

http://hg.mozilla.org/mozilla-central/rev/5c5d9ed49e5e
Attachment #526523 - Attachment description: (Av1a) Missed cleanup, s/if/case/ → (Av1a) Missed cleanup, s/if/case/ [Checked in: Comment 6]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
(Assignee)

Comment 7

6 years ago
Created attachment 526586 [details] [diff] [review]
(Bv1-CC) Sync' comm-central
[Checked in: Comment 9]

I can add MOZILLA_5_0_BRANCH checks if you want, but we don't really care.
Attachment #526586 - Flags: review?(bugspam.Callek)
Comment on attachment 526586 [details] [diff] [review]
(Bv1-CC) Sync' comm-central
[Checked in: Comment 9]

Good call, no need for a branch-specific ifdef here.
Attachment #526586 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 9

6 years ago
Comment on attachment 526586 [details] [diff] [review]
(Bv1-CC) Sync' comm-central
[Checked in: Comment 9]

http://hg.mozilla.org/comm-central/rev/fa49e872eab7
Attachment #526586 - Attachment description: (Bv1-CC) Sync' comm-central → (Bv1-CC) Sync' comm-central [Checked in: Comment 9]
You need to log in before you can comment on or make changes to this bug.