Closed
Bug 607544
Opened 15 years ago
Closed 14 years ago
Remove DDRAW junk from configure, missed part
Categories
(Firefox Build System :: General, defect)
Tracking
(status2.0 wontfix)
RESOLVED
FIXED
mozilla6
| Tracking | Status | |
|---|---|---|
| status2.0 | --- | wontfix |
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
|
8.98 KB,
patch
|
sgautherie
:
review+
|
Details | Diff | Splinter Review |
|
1.45 KB,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
Moving patch to here, per bug 600714 comment 7.
Flags: in-testsuite-
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #486266 -
Flags: review?(gavin.sharp)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 486266 [details] [diff] [review]
(Av1) Missed cleanup, s/if/case/
I'm not the right person to review this - sorry, I should have mentioned that in the other bug.
Attachment #486266 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #486266 -
Flags: review?(vladimir)
|
|
Assignee | |
Comment 3•15 years ago
|
||
vladimir, ping for review.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #486266 -
Flags: review?(ted.mielczarek)
|
||
Updated•15 years ago
|
Attachment #486266 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Comment on attachment 486266 [details] [diff] [review]
(Av1) Missed cleanup, s/if/case/
"approval2.0=?":
Remove dead configure code. No risk.
Attachment #486266 -
Flags: review?(vladimir) → approval2.0?
|
||
Updated•15 years ago
|
Attachment #486266 -
Flags: approval2.0? → approval2.0-
|
|
Assignee | |
Comment 5•14 years ago
|
||
Av1, unbitrotted.
Succeeded as
http://tbpl.mozilla.org/?tree=MozillaTry&rev=7698a175084a
Attachment #486266 -
Attachment is obsolete: true
Attachment #526523 -
Flags: review+
|
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Comment 6•14 years ago
|
||
Comment on attachment 526523 [details] [diff] [review]
(Av1a) Missed cleanup, s/if/case/
[Checked in: Comment 6]
http://hg.mozilla.org/mozilla-central/rev/5c5d9ed49e5e
Attachment #526523 -
Attachment description: (Av1a) Missed cleanup, s/if/case/ → (Av1a) Missed cleanup, s/if/case/
[Checked in: Comment 6]
|
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Comment 7•14 years ago
|
||
I can add MOZILLA_5_0_BRANCH checks if you want, but we don't really care.
Attachment #526586 -
Flags: review?(bugspam.Callek)
|
||
Comment 8•14 years ago
|
||
Comment on attachment 526586 [details] [diff] [review]
(Bv1-CC) Sync' comm-central
[Checked in: Comment 9]
Good call, no need for a branch-specific ifdef here.
Attachment #526586 -
Flags: review?(bugspam.Callek) → review+
|
|
Assignee | |
Comment 9•14 years ago
|
||
Comment on attachment 526586 [details] [diff] [review]
(Bv1-CC) Sync' comm-central
[Checked in: Comment 9]
http://hg.mozilla.org/comm-central/rev/fa49e872eab7
Attachment #526586 -
Attachment description: (Bv1-CC) Sync' comm-central → (Bv1-CC) Sync' comm-central
[Checked in: Comment 9]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•