607584 - CR in a paragraph with an id attribute creates a second paragraph of same id

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Steps to reproduce:

1. in the editor, have a paragraph with id="foo" and make sure the pref making
   a CR key create a new paragraph is on
2. hit CR

Actual result: two paragraphs holding id="foo"...
Expected result: newly created paragraph has no id

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #1

Comment 2

[(no longer active)]

Comment on attachment 486317 [details] [diff] [review]
fix #1

This looks good, but it requires a test as well.  Can you please add a test for it?

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: proposed test for fix #1

Comment 4

[(no longer active)]

Comment on attachment 486889 [details] [diff] [review]
proposed test for fix #1

r=me on the XUL test, but as I mentioned to Daniel over IRC, we'd also need a simple html test case as well, which I'm going to write soon.

Comment 5

[(no longer active)]

Attachment: HTML test case

Comment 6

[(no longer active)]

Temporarily assigning it to myself so that this shows up in my "needs landing" query.  Will assign back to Daniel once I land this.

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/42ef3b083779
http://hg.mozilla.org/mozilla-central/rev/8b3c024874d5
http://hg.mozilla.org/mozilla-central/rev/2b6e6d573158