Closed Bug 607584 Opened 10 years ago Closed 10 years ago

CR in a paragraph with an id attribute creates a second paragraph of same id

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: glazou, Assigned: glazou)

References

Details

Attachments

(3 files)

Steps to reproduce:

1. in the editor, have a paragraph with id="foo" and make sure the pref making
   a CR key create a new paragraph is on
2. hit CR

Actual result: two paragraphs holding id="foo"...
Expected result: newly created paragraph has no id
Attached patch fix #1Splinter Review
Assignee: nobody → daniel
Status: NEW → ASSIGNED
Attachment #486317 - Flags: review?(ehsan)
Comment on attachment 486317 [details] [diff] [review]
fix #1

This looks good, but it requires a test as well.  Can you please add a test for it?
Attachment #486317 - Flags: review?(ehsan) → review+
Attachment #486889 - Flags: review?(ehsan)
Comment on attachment 486889 [details] [diff] [review]
proposed test for fix #1

r=me on the XUL test, but as I mentioned to Daniel over IRC, we'd also need a simple html test case as well, which I'm going to write soon.
Attachment #486889 - Flags: review?(ehsan) → review+
Attachment #486317 - Flags: approval2.0?
Attached patch HTML test caseSplinter Review
Attachment #486936 - Flags: review?(roc)
Temporarily assigning it to myself so that this shows up in my "needs landing" query.  Will assign back to Daniel once I land this.
Assignee: daniel → ehsan
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/42ef3b083779
http://hg.mozilla.org/mozilla-central/rev/8b3c024874d5
http://hg.mozilla.org/mozilla-central/rev/2b6e6d573158
Assignee: ehsan → daniel
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b8
Version: unspecified → Trunk
Depends on: 611457
You need to log in before you can comment on or make changes to this bug.