607961 - Make post-uploadsymbols script convert text symbols to binary format

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[(not currently active) Ted Mielczarek]

In bug 607951 I'm adding a script that will be run after "make uploadsymbols". It's going to start out as a no-op just to get something in place. In this bug, I'll make it actually convert text-format symbols to binary (but leave the text-format symbols in place for a transition period).

This will increase our disk usage on the symbol server by a bit during transition, until we can start deleting the text-format symbols (once the new Socorro is rolled out).

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: post-upload-symbols script that converts text symbols to binary format

I've been using this script for testing locally and it does the job just fine. We'll need to have the symbol_convert binary on the server somewhere, I've just hardcoded a path for it, which should be fine.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: post-upload-symbols script that converts text symbols to binary format

I added --verbose and --dry-run options to the script, and also made it able to accept multiple index files on the commandline, so I can use it for batch conversion in bug 607969.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 488170 [details] [diff] [review]
post-upload-symbols script that converts text symbols to binary format

This isn't particularly complicated. You pass one or more symbol index files on the cmdline, and the script takes each .sym file listed, runs symbol_convert on it to produce a file with the same name but a .bin extension, and appends the relative path to the .bin file to the index file.

Comment 4

[(not currently active) Ted Mielczarek]

This isn't going to land until we fix all the blockers and sort out the deployment timeframe in bug 607831, FWIW.

Comment 5

[Chris AtLee [:catlee]]

Comment on attachment 488170 [details] [diff] [review]
post-upload-symbols script that converts text symbols to binary format

Need to make this python2.4 compatible, or get python2.5 on the server.

Also, need to check the return value of the converter subprocess.

Comment 6

[(not currently active) Ted Mielczarek]

WONTFIXing in lieu of bug 789493.