Add a post-uploadsymbols command

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: ted, Assigned: catlee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

The patch in bug 607946 allows specifying POST_SYMBOL_UPLOAD_CMD, a command that will be run on the symbol server after symbols are uploaded. I'd like to deploy a script and get our buildbot configs using it so that I have the flexibility to change our symbol format or storage in the near future (bug 607831).
Chris and Wolfgang, since you're not using the uploadsymbols target to upload your symbols, once I fix this bug you'll have to modify your symbol upload process to call the same script after uploading. That way your symbols will continue to work when we modify the script to convert the symbols to a new format.
Blocks: 607961
No longer blocks: 607831
Looks like an easy change here. Could you please post in this bug the command we need to use once it's available/implemented?
Created attachment 486624 [details] [diff] [review]
Add post-symbol-upload command to environment

This is not quite the right patch, since I don't know where the post-upload script will live yet, but I think it's mostly right. I probably need to copy this logic to all the other config.pys that live in this repo as well, I'm sure.
Created attachment 486625 [details] [diff] [review]
No-op post-symbol-upload.py

This is a placeholder, the functional version will be added in bug 607961. This is just to get something in place so that making it functional requires changes only on the symbol server. (Actually making it do conversion requires some logistical changes.)
Attachment #486625 - Flags: review?(catlee)
CCing some Camino folks, since I know their symbol upload process isn't 100% the same as what's in mozilla-central. It does look like Camino uses upload_symbols.sh, which is good, but I'm not sure that it will all work out of the box. You might need to port some bits of bug 607946, and you will need the environment var set properly in your build environment.
(In reply to comment #5)
> the box. You might need to port some bits of bug 607946

Bug 607946 looks to me like it's only doing 2 things:

1) 'export'ing the symbols index filename, which we'd have to add to our Makefile

2) making some changes to upload_symbols.sh to send along the new environment variable, which we should get for free--although for 2.0.x it'll need to be landed in CVS ;)

There's not more I'm missing, right?

> environment var set properly in your build environment.

OK.  That's '/path/to/post-symbol-upload.py' from the patch on this bug (which eventually will have some sort of on-server path, like SYMBOL_SERVER_PATH does)?

Assuming this is all that's needed, I'll also have to make corresponding changes to the Mac OS X symbols upload architecture, right?
Ok, sounds like you don't need any code changes then, just the environment change. The actual path to use will wind up in a patch on this bug soon.

Good point: re OS X symbols. I'm planning a mass conversion of existing symbols on the symbol server, but for new uploads you'll have to convert them. Let me know (or file a new bug) if you need any help with this. We're probably going to want a process in place for when we upload things like Flash symbols as well.
(Assignee)

Updated

8 years ago
Attachment #486625 - Flags: review?(catlee) → review+
Comment on attachment 486625 [details] [diff] [review]
No-op post-symbol-upload.py

Pushed to build/tools:
http://hg.mozilla.org/build/tools/rev/483307ade8a1
Attachment #486625 - Flags: checked-in+
Depends on: 609270
Attachment #486624 - Attachment is obsolete: true
Created attachment 487963 [details] [diff] [review]
Add post-symbol-upload command to environment

This patch includes the correct path for the post-upload command. I grepped all the files in buildbot-configs for SYMBOL_SERVER_PATH and edited them as I thought appropriate. It's possible that I missed something or did something wrong, certainly. For example, I'm not 100% confident of the release_master.py changes.
Attachment #487963 - Flags: review?(philipp)
Attachment #487963 - Flags: review?(kairo)
Attachment #487963 - Flags: review?(gozer)
Attachment #487963 - Flags: review?(catlee)
(Assignee)

Updated

8 years ago
Attachment #487963 - Flags: review?(catlee) → review+
(Assignee)

Comment 10

8 years ago
Bits of this may need porting to buildbot-0.8.0 land.

Updated

8 years ago
Attachment #487963 - Flags: review?(kairo) → review+
Comment on attachment 487963 [details] [diff] [review]
Add post-symbol-upload command to environment

thunderbird/ bits looking good
Attachment #487963 - Flags: review?(gozer) → review+
Comment on attachment 487963 [details] [diff] [review]
Add post-symbol-upload command to environment

Calendar bits look fine, sorry for the delay!
Attachment #487963 - Flags: review?(philipp) → review+
Blocks: 628731
Attachment #487963 - Attachment is obsolete: true
Created attachment 508481 [details] [diff] [review]
Add post-symbol-upload command to environment.

Rebased version of the patch.
Depends on: 630532
(Assignee)

Updated

8 years ago
Assignee: ted.mielczarek → catlee
Priority: -- → P2
If this takes time to deploy, we can reprocess crashes on Socorro to get the symbols in.  Let me know.
(Assignee)

Comment 15

8 years ago
Comment on attachment 508481 [details] [diff] [review]
Add post-symbol-upload command to environment.

http://hg.mozilla.org/build/buildbot-configs/rev/a13e44636b0d
Attachment #508481 - Flags: checked-in+
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.