Closed Bug 608036 Opened 9 years ago Closed 9 years ago

Cleanup some of client.mk

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

Details

Attachments

(1 file)

Attached patch clean it upSplinter Review
There are a few parts of client.mk that can use a bit of cleaning...

Most of this was found while I was working on Bug 607775. Explanations to follow
Attachment #486661 - Flags: review?(khuey)
Comment on attachment 486661 [details] [diff] [review]
clean it up

>-#
>-CVS = cvs
>+

Not used here, and sync's to what c-c has.

>-RUN_AUTOCONF_LOCALLY = 1

When no longer have an in-tree version of the configures, so must run them locally anyway.

>-	$(wildcard $(TOPSRCDIR)/config/chrome-versions.sh) \
>-  $(wildcard $(addsuffix confvars.sh,$(wildcard $(TOPSRCDIR)/*/))) \
>+	$(wildcard $(addsuffix confvars.sh,$(wildcard $(TOPSRCDIR)/*/))) \

tab-vs-space, and there is no longer a chrome-versions.sh

>-ifdef MOZ_TOOLS
>-  CONFIGURE = $(TOPSRCDIR)/configure
>-endif
>-

Not needed since we have that ifeq for TOPSRCDIR and OBJDIR above. This is always set right, independant of MOZ_TOOLS

>-.PHONY: checkout real_checkout depend build profiledbuild maybe_clobber_profiledbuild export libs alldep install clean realclean distclean cleansrcdir pull_all build_all clobber clobber_all pull_and_build_all everything configure preflight_all preflight postflight postflight_all
>+.PHONY: checkout real_checkout depend build profiledbuild maybe_clobber_profiledbuild export libs alldep install clean realclean distclean cleansrcdir pull_all build_all clobber clobber_all pull_and_build_all everything configure preflight_all preflight postflight postflight_all upload sdk

adding the new |upload| and |sdk| targets to .PHONY for correctness.
http://hg.mozilla.org/mozilla-central/rev/63c2aed72f69
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.