608103 - Message Display panel clipped on Windows 7

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Message Display cropped

The Message Display and Keyboard Navigation pref panels are clipped on Windows 7 (default system DPI and font settings). See attached images.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Keyboard Navigation cropped

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

I already checked on Linux and Windows XP, no problem there. This is Win7-only.

Comment 3

[Philip Chee]

I played around with some user styles in Stylish and came up with this:

@-moz-document url(chrome://communicator/content/pref/preferences.xul) {
  radio,
  checkbox {
    margin-top: 0.5px !important;
    margin-bottom: 0.5px !important;
  }
}

0px works better but looks a bit cramped.

Comment 4

[Philip Chee]

You may want to use the |:-moz-system-metric(windows-default-theme)| pseudo selector to limit the effects to Windows.

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #3)
> I played around with some user styles in Stylish and came up with this:

Yes, that does the trick. I can f+ a patch if you come up with one. ;-)

Comment 6

[Philip Chee]

You need to check the appearance in all the other panels. And also on Modern/Win7

Comment 7

[Philip Chee]

OK not Modern since these styles will go into the classic theme.

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #6)
> You need to check the appearance in all the other panels.

O'Really? I did. Anyway, we need a patch. Will try to come up with something later today, unless the bug has been assigned until then.

Comment 9

[Edmund Wong (:ewong)]

Is this bug still valid?   Keyboard Navigation has changed such that 
find as you type section has moved to its own preference category and
on my current build:

Build identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.2a1pre) Gecko/20110424 Firefox/4.2a1pre SeaMonkey/2.2a1pre

The Message Display displays ok.

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Keyboard Navigation is OK now, adjusting summary.

Message Display is still affected; I still see attachment 486743 [details].

Comment 12

[Edmund Wong (:ewong)]

Attachment: Message Display panel clipped on Windows 7

Comment 13

[Ian Neal]

Comment on attachment 557485 [details] [diff] [review]
Message Display panel clipped on Windows 7

I think this needs feedback from some non-English locales as it might not look very good when you have longer labels. Perhaps Mnyromyr?

Comment 14

[Ian Neal]

Comment on attachment 557485 [details] [diff] [review]
Message Display panel clipped on Windows 7

Re-request review once you have had some f+

Comment 15

[Stanimir Stamenkov]

I've tried a Russian language and it seems o.k. but the labels there are wrapped on two lines with or without the patch, if that's important.

Comment 16

[Stanimir Stamenkov]

Attachment: Russian locale - w/o patch

Comment 17

[Stanimir Stamenkov]

Attachment: Russian locale - with patch

Comment 18

[Jens Hatlak (:InvisibleSmiley)]

FTR: Generally it's bad to align checkboxes horizontally (because it makes it hard to tell the checkbox-label relationship) but in this case there's enough space in between.

Comment 19

[Philip Chee]

> -      <vbox align="start">
> +      <hbox align="start">
Shouldn't this be <hbox pack="start"> ? changing the orientation of the box changes the direction of align and pack.

https://developer.mozilla.org/en/XUL_Tutorial/Element_Positioning#Box_Alignment
https://developer.mozilla.org/en/XUL/align
https://developer.mozilla.org/en/CSS/box-pack

Comment 20

[Edmund Wong (:ewong)]

Attachment: Message Display panel clipped on Windows 7 (v2) [Checkin: comment 21]

Comment 21

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 572266 [details] [diff] [review]
Message Display panel clipped on Windows 7 (v2) [Checkin: comment 21]

http://hg.mozilla.org/comm-central/rev/18d9e519334f