Closed Bug 608103 Opened 9 years ago Closed 8 years ago

Message Display panel clipped on Windows 7

Categories

(SeaMonkey :: Preferences, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.8

People

(Reporter: InvisibleSmiley, Assigned: ewong)

References

Details

Attachments

(4 files, 2 obsolete files)

Attached image Message Display cropped
The Message Display and Keyboard Navigation pref panels are clipped on Windows 7 (default system DPI and font settings). See attached images.
Attached image Keyboard Navigation cropped (obsolete) —
I already checked on Linux and Windows XP, no problem there. This is Win7-only.
Attachment #486744 - Attachment description: Keybaord Navigation cropped → Keyboard Navigation cropped
I played around with some user styles in Stylish and came up with this:

@-moz-document url(chrome://communicator/content/pref/preferences.xul) {
  radio,
  checkbox {
    margin-top: 0.5px !important;
    margin-bottom: 0.5px !important;
  }
}

0px works better but looks a bit cramped.
You may want to use the |:-moz-system-metric(windows-default-theme)| pseudo selector to limit the effects to Windows.
(In reply to comment #3)
> I played around with some user styles in Stylish and came up with this:

Yes, that does the trick. I can f+ a patch if you come up with one. ;-)
You need to check the appearance in all the other panels. And also on Modern/Win7
OK not Modern since these styles will go into the classic theme.
(In reply to comment #6)
> You need to check the appearance in all the other panels.

O'Really? I did. Anyway, we need a patch. Will try to come up with something later today, unless the bug has been assigned until then.
Is this bug still valid?   Keyboard Navigation has changed such that 
find as you type section has moved to its own preference category and
on my current build:

Build identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.2a1pre) Gecko/20110424 Firefox/4.2a1pre SeaMonkey/2.2a1pre

The Message Display displays ok.
Keyboard Navigation is OK now, adjusting summary.

Message Display is still affected; I still see attachment 486743 [details].
Summary: Message Display and Keyboard Navigation panels clipped on Windows 7 → Message Display panel clipped on Windows 7
Attachment #486744 - Attachment is obsolete: true
Duplicate of this bug: 676337
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #557485 - Flags: review?(iann_bugzilla)
Comment on attachment 557485 [details] [diff] [review]
Message Display panel clipped on Windows 7

I think this needs feedback from some non-English locales as it might not look very good when you have longer labels. Perhaps Mnyromyr?
Comment on attachment 557485 [details] [diff] [review]
Message Display panel clipped on Windows 7

Re-request review once you have had some f+
Attachment #557485 - Flags: review?(iann_bugzilla)
Attachment #557485 - Flags: feedback?(jh)
I've tried a Russian language and it seems o.k. but the labels there are wrapped on two lines with or without the patch, if that's important.
Attachment #557485 - Flags: feedback?(jh) → feedback?(stanio)
Attachment #557485 - Flags: feedback?(stanio) → feedback+
FTR: Generally it's bad to align checkboxes horizontally (because it makes it hard to tell the checkbox-label relationship) but in this case there's enough space in between.
> -      <vbox align="start">
> +      <hbox align="start">
Shouldn't this be <hbox pack="start"> ? changing the orientation of the box changes the direction of align and pack.

https://developer.mozilla.org/en/XUL_Tutorial/Element_Positioning#Box_Alignment
https://developer.mozilla.org/en/XUL/align
https://developer.mozilla.org/en/CSS/box-pack
Attachment #557485 - Attachment is obsolete: true
Attachment #572266 - Flags: review?(iann_bugzilla)
Attachment #572266 - Flags: feedback+
Attachment #572266 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Comment on attachment 572266 [details] [diff] [review]
Message Display panel clipped on Windows 7 (v2) [Checkin: comment 21]

http://hg.mozilla.org/comm-central/rev/18d9e519334f
Attachment #572266 - Attachment description: Message Display panel clipped on Windows 7 (v2) → Message Display panel clipped on Windows 7 (v2) [Checkin: comment 21]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.8
Depends on: 867210
You need to log in before you can comment on or make changes to this bug.