608133 - "GBM plugin" custom license mass-assigned to unrelated extensions

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Giorgio Maone [:ma1]]

While uploading a version 2.0.4 of NoScript, I noticed the license selector was set to "Custom license for add-on 722 v2.0.3.5", and the license text was completely unrelated to NoScript and new to me, starting with:

GBM plugin for Mozilla/Firefox/SeaMonkey (NPGBM.DLL)
----------------------------------------------------

Copyright (C) 2006-2010 Heiko Nitzsche

After that I checked FlashGot and other extensions which previously had a pre-defined FOSS license, and found the license info had been modified as well.

I already corrected my license choices, reverting it to GPL v2.0 for my public listings, and these changes seem to stick so far.

However you can still see the problem on other extensions, for instance here: https://addons.mozilla.org/en-US/firefox/addon/4490/license/2.6.1

Comment 1

[Jeff Balogh (:jbalogh)]

mysql> select addon_id,id from versions where license_id=1396 order by addon_id;
+----------+--------+
| addon_id | id     |
+----------+--------+
|     1731 |  73442 | 
|     1733 | 110062 | 
|     4490 | 119578 | 
|     4925 | 119787 | 
|     4925 | 119643 | 
|     5380 | 119831 | 
|     5684 | 119938 | 
|     6350 | 120010 | 
|     6581 | 119543 | 
|    11919 | 117915 | 
|    14179 | 120012 | 
|    14179 | 108331 | 
|    14550 | 120296 | 
|    15102 | 120242 | 
|    48583 | 119677 | 
|    54959 | 119835 | 
|    55308 | 120299 | 
|    90018 | 119696 | 
|   162140 | 119974 | 
|   175989 | 120027 | 
|   235805 | 118574 | 
|   241858 | 119700 | 
|   241858 | 119664 | 
|   241858 | 119654 | 
|   241858 | 119530 | 
+----------+--------+
25 rows in set (0.00 sec)

Comment 2

[Jeff Balogh (:jbalogh)]

There are 7 licenses that are not builtin that are linked to more than one add-on.

mysql> select license_id, l.created, count(*) c, count(distinct addon_id) from versions v inner join licenses l on l.id=v.license_id  where license_id is not null and builtin=0 group by license_id having count(distinct addon_id) > 1;
+------------+---------------------+-----+--------------------------+
| license_id | created             | c   | count(distinct addon_id) |
+------------+---------------------+-----+--------------------------+
|       1391 | 2010-10-14 17:52:55 | 131 |                      102 | 
|       1392 | 2010-10-15 00:12:31 |  15 |                       13 | 
|       1395 | 2010-10-15 04:32:02 |  65 |                       42 | 
|       1396 | 2010-10-15 06:54:16 |  27 |                       22 | 
|       1405 | 2010-10-16 19:48:37 |   4 |                        4 | 
|       1406 | 2010-10-16 22:26:55 |  14 |                       11 | 
|       1419 | 2010-10-17 20:53:38 |   3 |                        2 | 
+------------+---------------------+-----+--------------------------+

I think this was busted after we pushed 5.11.2, but will not happen now that we have 5.11.2.5.

Comment 3

[Jeff Balogh (:jbalogh)]

Attachment: versions & licenses before the switch

Comment 4

[Jeff Balogh (:jbalogh)]

Attachment: sql updates + correlations

Fixed up with the sql in here.