Closed Bug 60826 Opened 24 years ago Closed 24 years ago

GBK characters can not be dispalyed properly

Categories

(Core :: Internationalization, defect, P1)

Product:
Core
Component:
Internationalization
Platform:
Sun
Solaris
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: masaki.katakai, Assigned: bstell)

References

(
URL
)

Details

(Keywords: intl)

Attachments

(11 files)

snapshot on Solaris
19.46 KB, image/gif
Details
patch, just added "gbk-0"
680 bytes, patch
Details | Diff | Splinter Review
patches to use a GBK without the ascii glyphs
5.35 KB, patch
Details | Diff | Splinter Review
GBK no ascii header file
1.48 KB, text/plain
Details
GBK no ascii cpp file
1.44 KB, text/plain
Details
with gbk-0 fonts on Solaris
131.75 KB, image/jpeg
Details
patch for makefile.win
787 bytes, patch
Details | Diff | Splinter Review
revised GBK no ascii header file
1.35 KB, text/plain
Details
Snapshot showing the display problem for 0xfe50-0xfe9f characters on a Simplified Chinese windows 2000 system
115.78 KB, image/jpeg
Details
patch to map GBK 0xFE50 - 0xFE9F to private use ala microsoft 936-2000
2.11 KB, patch
Details | Diff | Splinter Review
A screenshot on RH6.2J with gbk fonts.
111.95 KB, image/jpeg
Details
Please try to browse sample URL. Some characters are displayed as '?'. I'll attach the snapshots. It seems that only "gb13000.1993-1" fonts are usable for GBK. Is that correct? In Solaris platform, "gbk-0" are used for GBK. I'm not sure this is reasonable fix or not, but after I changed nsFontMetricsGTK.cpp to include "gbk-0", the characters can be displayed. I'll attach the patch. Please evaluate.
Attached image snapshot on Solaris —
Katakai san, I assign this to you since you have a patch, cc to erik, bstell.
Assignee: nhotta → katakai
Hi Katakai-san, The fix is correct, but please make it align properly with the lines above and below, and please do not use tabs in Mozilla source (only spaces). Thanks. r=erik
I thought your fix would be correct, since it uses the same charset as the other GBK. I.e. they both point to GBK, which says "x-gbk". However, I just had a look at that charset, and it appears to include the ASCII characters (0x00-0x7F), and so this is incorrect, since X Windows double-byte fonts do not contain ASCII glyphs. This means that both of the entries that point to GBK are incorrect. You can see this by setting your Simplified Chinese font to a GBK font in Edit | Prefs | Fonts. ASCII chars will not display correctly. The correct fix would be to do something like nsUnicodeToBIG5NoAscii. Sorry, I hereby remove (undo) my earlier r=erik.
Blocks: 60916
I'd like to reassign to Frank.
Assignee: katakai → ftang
I'm reassigning to my self, bstell. I am currently responsible for Unix font issues.
Assignee: ftang → bstell
Added intl, nsbeta1 keywords This bug is a showstopper for Sun's Chinese versions (see snapshot)
Keywords: intl, nsbeta1
what is the date that this fix is needed for?
So... according to erik, we need to do the following to fix this bug 1. add a new Unicode Encoder which contains no ASCII and use a new font encoding name for it. 2. change the nsFontMetricsGTK.cpp
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: --- → mozilla0.8
Attached file GBK no ascii cpp file —
Katakai-san, Could you verify these patches / files? Would you try this with both a GB2312 font and an GBK font? (note: bug http://bugzilla.mozilla.org/show_bug.cgi?id=66744 re: using a GB2312 font for GBK) Thanks
Verified Brian's patch on Solaris. When I use gtk-0 fonts, glyphs can be displayed properly. I'll attach the snapshot. When GB2312 is used, yes, as bug 66744 is filed, some glyphs are missing.
Katakai-san, Are the blank spots at 817f, 827f, 837f okay?
Yes, I think so because I got the same result on terminal.
I had nhotta try these on mac. At checkin he will update the mac build info. Erik, would you review this please?
sr=erik
r=ftang please change the FillInfo to public from protected
Target Milestone: mozilla0.8 → mozilla0.9
Checked GBK display on a Simplified Chinese Windows 2000 system. Most characters can be displayed except those between 0xfe50-0xfe9f. Those characters are displayed as question marks. IE and 4.x don't have this problem.
Changed QA contact to ji@netscape.com. Xianglan, I changed QA contact to you since you have already tested this.
QA Contact: teruko → ji
the fix has been checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Brian, I checked 02/29 mtrunk build. The problem showing on Windows is not fixed. (Please see my comments on 2001-02-09 14:26 and the screenshot following that). Do you need me to file a seperate bug for that?
Frank, can you review this? Erik, can you super-review this? thanks
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
r=ftang
sr=brendan@mozilla.org, rubberstamp is appropriate here! /be
checked in
I don't see in the "View Bug Activity" who reopened this bug. http://bugzilla.mozilla.org/show_activity.cgi?id=60826 I don't see any statements why it was re-opened so I am closing it If there are remaining issues please re-open with a description.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
With 03/08 build, there are too many glyphs missing, like 0x8151, 0x8154, 0x8263... Please see attached screenshot. Katakai-san, do you see the problem on Solaris?
Hi, Have you set up font properties for zh-CN correctly? You need to use gtk-0 fonts for zh-CN. Otherwise, you will see the other bug 66744. On my environment of Solaris, after setting gtk-0 fonts, I've verified the characters are displayed properly.
Yes, after I use gbk fonts for zh_CN, all the glyphs can be displayed. Marked it as verified.
Status: RESOLVED → VERIFIED
And the problem on windows for the characters in 0xFE50 - 0xFE9F range is fixed as well.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: